Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0036231
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Discounts and Promotionsmajoralways2017-06-01 11:592017-07-03 16:59
ReportermalsasuaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityimmediateResolutionfixedFixed in VersionRR17Q2.1
StatusclosedFix in branchFixed in SCM revisionffd895c239c9
ProjectionnoneETAnoneTarget VersionRR17Q2.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression levelProduction - Confirmed Stable
Regression date2017-02-17
Regression introduced in releaseRR17Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eb6b4b84a3416e104ee4aa2f2704ecaa732cc084 [^]
Triggers an Emergency PackNo
Summary

0036231: Discounts are not applied when a product is not included in the store assortment

Descriptionwhen a discount is configured with "included product: All excluding defined", and there is some product in product tab, then the discount is not applied for any product
Steps To Reproducein backend:
. discount and promotion window:
  . discount: GPS_10_per
  . change "included product" field, from "Only those defined" to "All excluding defined"
in product tab there are two products: gps handled and gps touch screen

in POS:
. add new product: inspect repelent
expected behavior: discount GPS_10_per should be applied, but it is not applied. It is not applied for any discount
Proposed Solutionin discount master query, this part should be removed:
    hql += "and ((p.includedProducts = 'Y' and not exists (select 1 ";
    hql += " from PricingAdjustmentProduct pap, OBRETCO_Prol_Product ppl ";
    hql += " where pap.active = true and pap.priceAdjustment = p ";
    hql += " and pap.product.id = ppl.product.id ";
    hql += " and ppl.obretcoProductlist.id ='" + productList.getId() + "')) ";
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0036160 closedranjith_qualiantech_com Discounts are not applied when a product is not included in the store assortment 

-  Notes
(0097350)
hgbot (developer)
2017-06-13 11:16

 Repository: retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal
Changeset: ffd895c239c9a5444d8e7cf60be7ae14b5fee581
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 13 14:45:25 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/ffd895c239c9a5444d8e7cf60be7ae14b5fee581 [^]

Fixed issue 36231 : Validate Discount Product if includeProduct is set as "all excluding defined"

* For Discount Product, if includeProduct is set as "all excluding defined" then it should not be checked with assortment

---
M src/org/openbravo/retail/posterminal/master/Discount.java
---
(0097351)
hgbot (developer)
2017-06-13 11:16

 Repository: retail/backports/3.0RR17Q2.1/pi-mobile
Changeset: a40bbf6a4b2a419dc7a76abc8e3601e0802908b1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 13 14:45:31 2017 +0530
URL: http://code.openbravo.com/retail/backports/3.0RR17Q2.1/pi-mobile/rev/a40bbf6a4b2a419dc7a76abc8e3601e0802908b1 [^]

Verifies issue 36231 : Added automated test 'I36231_VerifyDiscountWithIncludeExcludeProducts'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36231_VerifyDiscountWithIncludeExcludeProducts.java
---
(0097805)
hgbot (developer)
2017-07-03 16:59

 Repository: tools/automation/pi-mobile
Changeset: a40bbf6a4b2a419dc7a76abc8e3601e0802908b1
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jun 13 14:45:31 2017 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a40bbf6a4b2a419dc7a76abc8e3601e0802908b1 [^]

Verifies issue 36231 : Added automated test 'I36231_VerifyDiscountWithIncludeExcludeProducts'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I36231_VerifyDiscountWithIncludeExcludeProducts.java
---

- Issue History
Date Modified Username Field Change
2017-06-12 16:15 ranjith_qualiantech_com Type defect => backport
2017-06-12 16:15 ranjith_qualiantech_com Target Version => RR17Q2.1
2017-06-13 11:16 hgbot Checkin
2017-06-13 11:16 hgbot Note Added: 0097350
2017-06-13 11:16 hgbot Status scheduled => resolved
2017-06-13 11:16 hgbot Resolution open => fixed
2017-06-13 11:16 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/a99eaea6ebd2ae64996cbbabdddf5e2d76131638 [^] => http://code.openbravo.com/retail/backports/3.0RR17Q2.1/org.openbravo.retail.posterminal/rev/ffd895c239c9a5444d8e7cf60be7ae14b5fee581 [^]
2017-06-13 11:16 hgbot Checkin
2017-06-13 11:16 hgbot Note Added: 0097351
2017-06-19 18:30 marvintm Review Assigned To => marvintm
2017-06-19 18:30 marvintm Status resolved => closed
2017-06-19 18:30 marvintm Fixed in Version => RR17Q2.1
2017-07-03 16:59 hgbot Checkin
2017-07-03 16:59 hgbot Note Added: 0097805

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker