Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0035840
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajoralways2017-04-26 08:352017-05-29 17:43
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityhighResolutionfixedFixed in Version3.0PR17Q3
StatusclosedFix in branchFixed in SCM revision6d26747ad4df
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035840: can't save record after failed save in tabs with a time reference

DescriptionIn tabs having at least one time reference field, the save button gets disabled after trying to save in case the request failed (ie. because a trigger prevented saving with current values).
Steps To Reproduce1. Open Process Request
2. Select Costing Background process
3. Keep Frequency with "02 - Every n minutes"
4. Set to blank "Interval in minutes" field
5. Save
  * OK -> An error message is shown because this is not a valid configuration
  * ERROR -> Save button gets disabled
  * ERROR -> JS error can be seen in dev console
ISC_Combined.js:254 Uncaught TypeError: Cannot read property 'startTime' of undefined
    at _2.formSaved (2e8cfb4….js:11424)
    at _2.formSavedComplete (ISC_Combined.js:12296)
    at _2.$49z (ISC_Combined.js:12296)
    at _2.eval (eval at isc__makeFunction (ISC_Combined.js:45), <anonymous>:3:18)
    at _2.isc_c_Class_fireCallback [as fireCallback] (ISC_Combined.js:254)
    at _2.isc_Class_fireCallback [as fireCallback] (ISC_Combined.js:314)
    at _2.isc_DataSource_fireResponseCallbacks [as fireResponseCallbacks] (ISC_Combined.js:10845)
    at _2.isc_DataSource__completeResponseProcessing [as $38b] (ISC_Combined.js:10842)
    at _2.isc_DataSource__handleJSONReply [as $377] (ISC_Combined.js:10735)
    at _2.isc.B.push.isc.A.$379 (ISC_Combined.js:10745)


​
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0035835 closedinigosanchez The scheduler fails to load some scheduled processes when an incorrect configuration should be done 
related to defect 0035944 closedcaristu unresponsive ui after uncaught error in EntityPersistenceEventObserver 

-  Notes
(0096183)
hgbot (developer)
2017-04-26 09:13

 Repository: erp/devel/pi
Changeset: 6d26747ad4df54db30adb2bda42bb62a19821d61
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Wed Apr 26 09:12:52 2017 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/6d26747ad4df54db30adb2bda42bb62a19821d61 [^]

fixed bug 35840: can't save after failed save in tabs with a time reference

  In tabs having at least one time reference field, the save button gets disabled
  after trying to save in case the request failed.

  Time reference updates data in client to convert value to correct TZ. When record
  fails to be saved in backend, the callback doesn't return the data which was
  expected by this function, trying thus to read a property from an undefined
  variable.

  Now it is checked if data exists before trying to operate with it.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0096248)
caristu (developer)
2017-04-28 08:34
edited on: 2017-04-28 08:34

 Code reviewed + tested OK in pi@5e818f0155f5
(0096910)
hudsonbot (developer)
2017-05-29 17:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/1ee70113bdc4 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2017-04-26 08:35 alostale New Issue
2017-04-26 08:35 alostale Assigned To => platform
2017-04-26 08:35 alostale Modules => Core
2017-04-26 08:35 alostale Triggers an Emergency Pack => No
2017-04-26 08:35 alostale Relationship added related to 0035835
2017-04-26 08:58 alostale Assigned To platform => alostale
2017-04-26 08:59 alostale Status new => acknowledged
2017-04-26 08:59 alostale Review Assigned To => caristu
2017-04-26 09:13 hgbot Checkin
2017-04-26 09:13 hgbot Note Added: 0096183
2017-04-26 09:13 hgbot Status acknowledged => resolved
2017-04-26 09:13 hgbot Resolution open => fixed
2017-04-26 09:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6d26747ad4df54db30adb2bda42bb62a19821d61 [^]
2017-04-28 08:34 caristu Note Added: 0096248
2017-04-28 08:34 caristu Status resolved => closed
2017-04-28 08:34 caristu Fixed in Version => 3.0PR17Q3
2017-04-28 08:34 caristu Note Edited: 0096248 View Revisions
2017-05-08 15:28 alostale Relationship added related to 0035944
2017-05-29 17:43 hudsonbot Checkin
2017-05-29 17:43 hudsonbot Note Added: 0096910

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker