Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0035612
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2017-03-24 13:342017-03-29 13:54
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7a9c13cef378
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomtaal
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0035612: SynchronizationPropertiesFileBuilder should not read template from source path

DescriptionThe SynchronizationPropertiesFileBuilder is currently reading a template from the source path, see [1]. It is not guaranteed that this development is deployed in an environment that contains the sources, so the template should be read from WebContent.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/72e395e33639/src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java#l275 [^]
Steps To ReproduceIn a multiserver environment:
- Rename the file src/org/openbravo/replication/symmetricds/util/engine-properties.ftl of the module org.openbravo.replicate.symmetricds. With this the lack of sources will be simulated.
- Try to start Tomcat. An error will be shown because the template propertiles file will not be found.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0095557)
hgbot (developer)
2017-03-24 13:40

Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 7a9c13cef378f084fdb5ecd61de8971dc3de76b7
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Fri Mar 24 13:39:17 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/7a9c13cef378f084fdb5ecd61de8971dc3de76b7 [^]

Fixes issue 35612: Template file is no longer read from the source path

Instead of reading the template from the source path, it is read from webcontent by using this command:

    URL resourceUrl = SynchronizationPropertiesFileBuilder.class.getResource(TEMPLATE_PATH);
    File f = new File(resourceUrl.getPath());

---
M src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java
---
(0095582)
hgbot (developer)
2017-03-27 09:19

Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: e9953da38eeaf0e26b7baa5fbda05b66d4ee2939
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Mar 27 09:18:38 2017 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/e9953da38eeaf0e26b7baa5fbda05b66d4ee2939 [^]

Related with issue 35612: Removes unused field

---
M src/org/openbravo/replication/symmetricds/util/SynchronizationPropertiesFileBuilder.java
---
(0095644)
mtaal (manager)
2017-03-29 13:54

Reviewed

- Issue History
Date Modified Username Field Change
2017-03-24 13:34 AugustoMauch New Issue
2017-03-24 13:34 AugustoMauch Assigned To => AugustoMauch
2017-03-24 13:34 AugustoMauch Triggers an Emergency Pack => No
2017-03-24 13:39 AugustoMauch Review Assigned To => mtaal
2017-03-24 13:40 hgbot Checkin
2017-03-24 13:40 hgbot Note Added: 0095557
2017-03-24 13:40 hgbot Status new => resolved
2017-03-24 13:40 hgbot Resolution open => fixed
2017-03-24 13:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/7a9c13cef378f084fdb5ecd61de8971dc3de76b7 [^]
2017-03-24 14:44 shuehner Issue Monitored: shuehner
2017-03-27 09:19 hgbot Checkin
2017-03-27 09:19 hgbot Note Added: 0095582
2017-03-29 13:54 mtaal Note Added: 0095644
2017-03-29 13:54 mtaal Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker