Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0035490

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

minor

have not tried

2017-03-12 13:13

2017-03-15 20:22

Reporter

shuehner

View Status

public

Assigned To

shuehner

Priority

normal

Resolution

fixed

Fixed in Version

3.0PR17Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

alostale

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0035490: SystemService logValidationResults logs a ERROR line always if there are no errors (shows in export.database)

Description

The 'Validating module' part of export.database calls to SystemService in erp sourcecode to do the validation + to log the result.

That logValidationResult method assembles a StringBuffer and logs it using log4j.error.

However if does not check if that String does contain anything so logs an 'empty' error all the time.

Note that this is minor for the moment as export.database does have bad log4j config so it does not show the log-level prefix at the moment. Fixing that manually show the problem clearly like this:

24623 [main] INFO org.openbravo.ddlutils.task.ExportDatabase - Validating Module...
25022 [main] ERROR org.openbravo.ddlutils.task.ExportDatabase -

Steps To Reproduce

Run export.database with any module in development and notice the extra empty line on Validating module.
With the debugging patch attached to this issue it will show the wrong log level clearly.

Tags

No tags attached.

35490_fix.diff [^] (445 bytes) 2017-03-12 13:14 [Show Content] [Hide Content]

diff -r b0b2a512d017 src/org/openbravo/service/system/SystemService.java
--- a/src/org/openbravo/service/system/SystemService.java	Sun Mar 12 12:06:39 2017 +0100
+++ b/src/org/openbravo/service/system/SystemService.java	Sun Mar 12 13:14:06 2017 +0100
@@ -168,7 +168,9 @@
         sb.append(err);
       }
     }
-    log.error(sb.toString());
+    if (sb.length() > 0) {
+      log.error(sb.toString());
+    }
     return sb.toString();
   }

debugging-do-not-commit-fix-log4j.diff [^] (941 bytes) 2017-03-12 13:15 [Show Content] [Hide Content]

# HG changeset patch
# Parent  1df715b5ede6e8fea3d1ca3aecf34fbb1fa6405b

diff -r 1df715b5ede6 -r 4475bab56cb4 src/org/openbravo/ddlutils/task/BaseDalInitializingTask.java
--- a/src/org/openbravo/ddlutils/task/BaseDalInitializingTask.java	Sun Mar 12 12:49:10 2017 +0100
+++ b/src/org/openbravo/ddlutils/task/BaseDalInitializingTask.java	Sun Mar 12 12:50:40 2017 +0100
@@ -61,7 +61,7 @@
     org.openbravo.utils.OBLogAppender.setProject(getProject());
     // "org.apache.log4j.ConsoleAppender");
     props.setProperty("log4j.appender.A.layout", "org.apache.log4j.PatternLayout");
-    props.setProperty("log4j.appender.A.layout.ConversionPattern", "%m%n");
+    props.setProperty("log4j.appender.A.layout.ConversionPattern", "%-4r [%t] %-5p %c - %m%n");
     // we don't want debug logging from Digester/Betwixt
     props.setProperty("log4j.logger.org.apache.commons", "WARN");
     props.setProperty("log4j.logger.org.hibernate", "WARN");

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

missing log info when check consistency fails

Notes
(0094956) shuehner (administrator) 2017-03-12 13:15	Note: the debugging patch is for dbsm repo so to use it need to recompile dbsm and use that jar

(0094968) hgbot (developer) 2017-03-13 07:49	Repository: erp/devel/pi Changeset: 0dd550bbbef217729547c193505710672401aa65 Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Mon Mar 13 07:48:48 2017 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/0dd550bbbef217729547c193505710672401aa65 [^] fixed bug 35490: SystemService logs a ERROR line always --- M src/org/openbravo/service/system/SystemService.java ---

(0094969) alostale (manager) 2017-03-13 07:51	reviewed

(0095293) hudsonbot (developer) 2017-03-15 20:22	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/54e102bef53e [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2017-03-12 13:13	shuehner	New Issue
2017-03-12 13:13	shuehner	Assigned To	=> platform
2017-03-12 13:13	shuehner	Modules	=> Core
2017-03-12 13:13	shuehner	Triggers an Emergency Pack	=> No
2017-03-12 13:14	shuehner	File Added: 35490_fix.diff
2017-03-12 13:15	shuehner	File Added: debugging-do-not-commit-fix-log4j.diff
2017-03-12 13:15	shuehner	Note Added: 0094956
2017-03-13 07:49	alostale	Assigned To	platform => shuehner
2017-03-13 07:49	hgbot	Checkin
2017-03-13 07:49	hgbot	Note Added: 0094968
2017-03-13 07:49	hgbot	Status	new => resolved
2017-03-13 07:49	hgbot	Resolution	open => fixed
2017-03-13 07:49	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/0dd550bbbef217729547c193505710672401aa65 [^]
2017-03-13 07:51	alostale	Review Assigned To	=> alostale
2017-03-13 07:51	alostale	Note Added: 0094969
2017-03-13 07:51	alostale	Status	resolved => closed
2017-03-13 07:51	alostale	Fixed in Version	=> 3.0PR17Q2
2017-03-13 09:17	alostale	Relationship added	related to 0035493
2017-03-15 20:22	hudsonbot	Checkin
2017-03-15 20:22	hudsonbot	Note Added: 0095293

Copyright © 2000 - 2009 MantisBT Group