Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0035441 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
feature request | [Retail Modules] Web POS | major | have not tried | 2017-03-07 10:08 | 2017-03-30 18:48 | |||
Reporter | adrianromero | View Status | public | |||||
Assigned To | asiermartirena | |||||||
Priority | urgent | Resolution | open | Fixed in Version | RR17Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | e87f5e23ba6b | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | marvintm | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0035441: [SER-QA 2526] The giftcard info dialog that appears from the menu must not show the refund button | |||||||
Description | When displaying the giftcard information dialog from the menu, the cashier is just querying information, so no action must be displayed in the dialog. The "Refund" button must be hidden. | |||||||
Steps To Reproduce | Just show a giftcard information dialog from the menu | |||||||
Proposed Solution | Apply the attached patch. | |||||||
Tags | SER-QA | |||||||
Attached Files | Issue35441.diff [^] (1,667 bytes) 2017-03-07 10:11 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0094979) hgbot (developer) 2017-03-13 12:20 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Mon Mar 13 11:04:42 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d [^] Fixed issue 35441: [SER-QA 2468] The giftcard info dialog that appears from the menu must not show the refund button Return button must be hidden if the popup is a searchAction popup. --- M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js --- |
(0094995) hgbot (developer) 2017-03-14 09:34 |
Repository: tools/automation/pi-mobile Changeset: b1261c8c8ffa9f963b3f68381027a59d374f5bb6 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Mon Mar 13 12:17:27 2017 +0100 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b1261c8c8ffa9f963b3f68381027a59d374f5bb6 [^] Verifies issue 35441: [SER-QA 2468] The giftcard info dialog that appears from the menu must not show the refund button Added test I35441_HideReturnButtonInGiftCardInformation. Added new TestId for ExtModules. --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/I35441_HideReturnButtonInGiftCardInformation.java --- |
(0095339) hgbot (developer) 2017-03-16 16:54 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: ec0f9050aec0d63cbc80ef61a9b80b3210d01a8a Author: Antonio Moreno <antonio.moreno <at> openbravo.com> Date: Thu Mar 16 16:54:18 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/ec0f9050aec0d63cbc80ef61a9b80b3210d01a8a [^] Related to issue 35441. The fix as it is designed is not correct, because it completely removed the functionality, instead of making it configurable. --- M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js --- |
(0095340) marvintm (manager) 2017-03-16 16:55 |
The fix is not correct. It's not right to simply remove a useful functionality. Instead, it should be changed so that it's possible to configure if it's available for the user or not. |
(0095503) asiermartirena (developer) 2017-03-22 13:57 edited on: 2017-03-22 13:57 |
Yes, that's the reason why the change have been back outed. I've already talked to Antonio and agreed to make it configurable by a preference. I'll implement it as soon as possible. |
(0095512) hgbot (developer) 2017-03-22 17:52 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 1ad41f8683443cffacb9030723686ea99ca54244 Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Mar 22 17:51:49 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/1ad41f8683443cffacb9030723686ea99ca54244 [^] Related to issue 35441: The giftcard info dialog that appears from the menu may not show the refund button --- M src-db/database/sourcedata/AD_PREFERENCE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js --- |
(0095518) hgbot (developer) 2017-03-22 19:09 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: c3aef7f4469f7448a1136041658bf1887ed04c7a Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Mar 22 19:04:46 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/c3aef7f4469f7448a1136041658bf1887ed04c7a [^] Related to issue 35441: Backed out changeset 1ad41f868344 (try errors) --- M src-db/database/sourcedata/AD_PREFERENCE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js --- |
(0095540) hgbot (developer) 2017-03-23 17:18 |
Repository: erp/pmods/org.openbravo.retail.giftcards Changeset: 4ab23e38c08717d1ffa8b27b8948fa58e7f91975 Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Thu Mar 23 16:52:58 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/4ab23e38c08717d1ffa8b27b8948fa58e7f91975 [^] Related to issue 35441: Backed out changeset c3aef7f4469f --- M src-db/database/sourcedata/AD_PREFERENCE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M web/org.openbravo.retail.giftcards/js/components/GiftCardDetails.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2017-03-07 10:08 | adrianromero | New Issue | |
2017-03-07 10:08 | adrianromero | Assigned To | => Retail |
2017-03-07 10:08 | adrianromero | Regression date | => 2017-03-21 |
2017-03-07 10:08 | adrianromero | Triggers an Emergency Pack | => No |
2017-03-07 10:09 | adrianromero | Tag Attached: SER-QA | |
2017-03-07 10:11 | adrianromero | File Added: Issue35441.diff | |
2017-03-13 12:20 | hgbot | Checkin | |
2017-03-13 12:20 | hgbot | Note Added: 0094979 | |
2017-03-13 12:20 | hgbot | Status | new => resolved |
2017-03-13 12:20 | hgbot | Resolution | open => fixed |
2017-03-13 12:20 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.giftcards/rev/e87f5e23ba6b1ca6b16a9b51cd1e76c7e504141d [^] |
2017-03-13 12:24 | jorge-garcia | Assigned To | Retail => jorge-garcia |
2017-03-13 13:33 | maite | Resolution time | => 1490050800 |
2017-03-13 13:33 | maite | Regression date | 2017-03-21 => |
2017-03-14 09:34 | hgbot | Checkin | |
2017-03-14 09:34 | hgbot | Note Added: 0094995 | |
2017-03-16 16:54 | hgbot | Checkin | |
2017-03-16 16:54 | hgbot | Note Added: 0095339 | |
2017-03-16 16:55 | marvintm | Assigned To | jorge-garcia => asiermartirena |
2017-03-16 16:55 | marvintm | Note Added: 0095340 | |
2017-03-16 16:55 | marvintm | Status | resolved => new |
2017-03-16 16:55 | marvintm | Resolution | fixed => open |
2017-03-16 16:55 | marvintm | Resolution time | 1490050800 => |
2017-03-16 16:55 | marvintm | Type | defect => feature request |
2017-03-21 13:01 | adrianromero | Summary | [SER-QA 2468] The giftcard info dialog that appears from the menu must not show the refund button => [SER-QA 2526] The giftcard info dialog that appears from the menu must not show the refund button |
2017-03-22 13:57 | asiermartirena | Note Added: 0095503 | |
2017-03-22 13:57 | asiermartirena | Note Edited: 0095503 | View Revisions |
2017-03-22 17:52 | hgbot | Checkin | |
2017-03-22 17:52 | hgbot | Note Added: 0095512 | |
2017-03-22 19:09 | hgbot | Checkin | |
2017-03-22 19:09 | hgbot | Note Added: 0095518 | |
2017-03-23 17:18 | hgbot | Checkin | |
2017-03-23 17:18 | hgbot | Note Added: 0095540 | |
2017-03-23 17:18 | asiermartirena | Status | new => scheduled |
2017-03-27 12:09 | asiermartirena | Status | scheduled => resolved |
2017-03-30 18:48 | marvintm | Review Assigned To | => marvintm |
2017-03-30 18:48 | marvintm | Status | resolved => closed |
2017-03-30 18:48 | marvintm | Fixed in Version | => RR17Q2 |
Copyright © 2000 - 2009 MantisBT Group |