0035350: Callout problem when working with comma (,) as decimal separator

Notes
(0094629) hgbot (developer) 2017-02-27 10:50	Repository: erp/backports/3.0PR16Q4.3 Changeset: acc61deacf8fec263e4d273510fcffb9c0a39a29 Author: Inigo Sanchez <inigo.sanchez <at> openbravo.com> Date: Mon Feb 27 10:49:29 2017 +0100 URL: http://code.openbravo.com/erp/backports/3.0PR16Q4.3/rev/acc61deacf8fec263e4d273510fcffb9c0a39a29 [^] Fixed issue 35350:Callout problem when working with comma as decimal separator The problem was raised when a default format were switched, it means, when decimal and group separator were switched. In this situation, when SimpleCalloutInformationProvider class was used to obtain the current element value and this current element was a BigDecimal, the format was not managed properly. This occurred because getCurrentElementValue method always retrieved a String element instead of Object element, in tyhis case BigDecimal. In this situation, managesUpdatedValuesForCallout method of FIC class compare if element is a String or not. If a BigDecimal is retrieved as String element, in this part of the code the format is not managed properly when decimal separator is comma. The code manage the comma separator as group separator and removed it. When the decimal separator is dot (.) the format is managed as expected although this method retrieves a String object (e.g. "1.23"). When decimal separator is comma (,) this BigDecimal (e.g. 1,24) is retrieved by getCurrentElementValue method as String value and the format is missed. This problem has been fixed by take into account type of current element inside getCurrentElementValue method. Now this method retrieves an object value. In this case, a BigDecimal is retrieved. Now the format is managed properly. --- M src/org/openbravo/erpCommon/ad_callouts/SimpleCalloutInformationProvider.java ---

(0094752) caristu (developer) 2017-03-03 15:37	Code reviewed + testing OK.

Issue History
Date Modified	Username	Field	Change
2017-02-23 16:20	inigosanchez	Type	defect => backport
2017-02-23 16:20	inigosanchez	Target Version	=> 3.0PR16Q4.3
2017-02-24 13:29	juabaez	Issue Monitored: juabaez
2017-02-27 10:49	inigosanchez	Regression level	Packaging and release => Production - QA Approved
2017-02-27 10:50	hgbot	Checkin
2017-02-27 10:50	hgbot	Note Added: 0094629
2017-02-27 10:50	hgbot	Status	scheduled => resolved
2017-02-27 10:50	hgbot	Resolution	open => fixed
2017-02-27 10:50	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/backports/3.0PR16Q4.3/rev/acc61deacf8fec263e4d273510fcffb9c0a39a29 [^]
2017-02-27 11:28	inigosanchez	Review Assigned To	=> caristu
2017-03-03 15:37	caristu	Note Added: 0094752
2017-03-03 15:37	caristu	Status	resolved => closed
2017-03-03 15:37	caristu	Fixed in Version	=> 3.0PR16Q4.3
2017-03-03 18:57	Practics	Issue Monitored: Practics