0035238: Check on router should use AbstractOpenbravoRouter instead of AbstractClientRouter

Description

I get the following exception [1] when adding a new router. The router correctly inherits from the AbstractOrganizationRouter.

[1]
195436 [http-bio-9080-exec-2] ERROR org.openbravo.service.json.DefaultJsonDataService - Error adding new object
org.openbravo.base.exception.OBException: ClassCastException: org.openbravo.retail.storeserver.synchronization.router.UserTerminalAccessRouter cannot be cast to org.openbravo.replication.symmetricds.extensions.AbstractClientFilteredRouter
    at org.openbravo.replication.symmetricds.eventhandler.CustomRouterEventHandler.check(CustomRouterEventHandler.java:74)
    at org.openbravo.replication.symmetricds.eventhandler.CustomRouterEventHandler.onCreate(CustomRouterEventHandler.java:52)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:497)
    at org.jboss.weld.util.reflection.SecureReflections$13.work(SecureReflections.java:267)
    at org.jboss.weld.util.reflection.SecureReflectionAccess.run(SecureReflectionAccess.java:52)
    at org.jboss.weld.util.reflection.SecureReflectionAccess.runAsInvocation(SecureReflectionAccess.java:137)
    at org.jboss.weld.util.reflection.SecureReflections.invoke(SecureReflections.java:263)
    at org.jboss.weld.introspector.jlr.WeldMethodImpl.invokeOnInstance(WeldMethodImpl.java:164)
    at org.jboss.weld.introspector.ForwardingWeldMethod.invokeOnInstance(ForwardingWeldMethod.java:51)
    at org.jboss.weld.injection.MethodInjectionPoint.invokeOnInstanceWithSpecialValue(MethodInjectionPoint.java:154)
    at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:245)
    at org.jboss.weld.event.ObserverMethodImpl.sendEvent(ObserverMethodImpl.java:233)
    at org.jboss.weld.event.ObserverMethodImpl.notify(ObserverMethodImpl.java:213)
    at org.jboss.weld.event.ObserverNotifier.notifyObserver(ObserverNotifier.java:117)
    at org.jboss.weld.event.ObserverNotifier.notifyObservers(ObserverNotifier.java:85)
    at org.jboss.weld.event.ObserverNotifier.fireEvent(ObserverNotifier.java:80)
    at org.jboss.weld.event.EventImpl.fire(EventImpl.java:69)
    at org.openbravo.client.kernel.event.PersistenceEventOBInterceptor.sendNewEvent(PersistenceEventOBInterceptor.java:97)
    at org.openbravo.client.kernel.event.PersistenceEventOBInterceptor.onSave(PersistenceEventOBInterceptor.java:86)
    at org.openbravo.client.kernel.event.PersistenceEventOBInterceptor$Proxy$_$$_WeldClientProxy.onSave(PersistenceEventOBInterceptor$Proxy$_$$_WeldClientProxy.java)
    at org.openbravo.dal.core.OBInterceptor.onSave(OBInterceptor.java:244)
    at org.hibernate.event.def.AbstractSaveEventListener.substituteValuesIfNecessary(AbstractSaveEventListener.java:413)
    at org.hibernate.event.def.AbstractSaveEventListener.performSaveOrReplicate(AbstractSaveEventListener.java:292)
    at org.hibernate.event.def.AbstractSaveEventListener.performSave(AbstractSaveEventListener.java:203)
    at org.hibernate.event.def.AbstractSaveEventListener.saveWithGeneratedId(AbstractSaveEventListener.java:143)
    at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.saveWithGeneratedOrRequestedId(DefaultSaveOrUpdateEventListener.java:210)
    at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.entityIsTransient(DefaultSaveOrUpdateEventListener.java:195)
    at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.performSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:117)
    at org.hibernate.event.def.DefaultSaveOrUpdateEventListener.onSaveOrUpdate(DefaultSaveOrUpdateEventListener.java:93)
    at org.hibernate.impl.SessionImpl.fireSaveOrUpdate(SessionImpl.java:685)
    at org.hibernate.impl.SessionImpl.saveOrUpdate(SessionImpl.java:677)
    at org.openbravo.dal.core.SessionHandler.save(SessionHandler.java:434)
    at org.openbravo.dal.service.OBDal.save(OBDal.java:303)
    at org.openbravo.service.json.DefaultJsonDataService.update(DefaultJsonDataService.java:924)
    at org.openbravo.service.json.DefaultJsonDataService.add(DefaultJsonDataService.java:860)
    at org.openbravo.service.datasource.DefaultDataSourceService.add(DefaultDataSourceService.java:219)
    at org.openbravo.service.datasource.DefaultDataSourceService.add(DefaultDataSourceService.java:210)
    at org.openbravo.service.datasource.DataSourceServlet.doPost(DataSourceServlet.java:854)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:650)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:452)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:58)
    at org.openbravo.service.datasource.DataSourceServlet.service(DataSourceServlet.java:153)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:731)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:218)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:505)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:169)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:103)
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:956)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:442)
    at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1083)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:640)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:318)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
    at java.lang.Thread.run(Thread.java:745)
Caused by: java.lang.ClassCastException: org.openbravo.retail.storeserver.synchronization.router.UserTerminalAccessRouter cannot be cast to org.openbravo.replication.symmetricds.extensions.AbstractClientFilteredRouter
    at org.openbravo.replication.symmetricds.eventhandler.CustomRouterEventHandler.check(CustomRouterEventHandler.java:67)
    ... 83 more

Steps To Reproduce

Create a new router record

Proposed Solution

Check using the AbstractOpenbravoRouter.

Notes
(0094269) hgbot (developer) 2017-02-13 14:29	Repository: erp/pmods/org.openbravo.replication.symmetricds Changeset: d0d84ef7a0cb78d5cc4138561b4a997e99332c0d Author: Martin Taal <martin.taal <at> openbravo.com> Date: Mon Feb 13 14:29:30 2017 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/d0d84ef7a0cb78d5cc4138561b4a997e99332c0d [^] Fixes issue 35238: Check on router should use AbstractOpenbravoRouter instead of AbstractClientRouter Check using AbstractOpenbravoRouter --- M src/org/openbravo/replication/symmetricds/eventhandler/CustomRouterEventHandler.java ---

(0094485) AugustoMauch (manager) 2017-02-20 17:30	Code reviewed and verified

Issue History
Date Modified	Username	Field	Change
2017-02-13 12:13	mtaal	New Issue
2017-02-13 12:13	mtaal	Assigned To	=> mtaal
2017-02-13 12:13	mtaal	Triggers an Emergency Pack	=> No
2017-02-13 12:14	mtaal	Review Assigned To	=> AugustoMauch
2017-02-13 12:14	mtaal	Description Updated	View Revisions
2017-02-13 14:29	hgbot	Checkin
2017-02-13 14:29	hgbot	Note Added: 0094269
2017-02-13 14:29	hgbot	Status	new => resolved
2017-02-13 14:29	hgbot	Resolution	open => fixed
2017-02-13 14:29	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/d0d84ef7a0cb78d5cc4138561b4a997e99332c0d [^]
2017-02-20 17:30	AugustoMauch	Note Added: 0094485
2017-02-20 17:30	AugustoMauch	Status	resolved => closed

Relationships [ Relation Graph ] [ Dependency Graph ]