Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034861
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] StoreServermajorhave not tried2017-01-08 09:092017-01-11 17:35
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision061d39ff979a
ProjectionnoneETAnoneTarget VersionRR17Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034861: Solve oracle issues in store server build

DescriptionThe build on oracle fails [1] and [2]. This because the insert statement here [1] does not have enough values.

There are also several other sql statements which are incorrect. See the changesets in this issue.


[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/4557d1c17a88/src/org/openbravo/replication/symmetricds/extensions/BatchDatabaseWriterControl.java#l94 [^]

[2]
https://ci.openbravo.com/view/storeserver/job/ret-ms-mix-db-central-oracle/29/artifact/SANDBOX/tomcat-logs/ret-ms-mix-db-central-oracle.log [^]

[3]
2017-01-07 15:47:56,696 [central-data-loader-1] ERROR org.jumpmind.symmetric.service.impl.DataLoaderService - Failed to load batch Store1-4
org.jumpmind.db.sql.SqlException: ORA-00947: not enough values

    at org.jumpmind.db.sql.AbstractSqlTemplate.translate(AbstractSqlTemplate.java:283)
    at org.jumpmind.db.sql.AbstractSqlTemplate.translate(AbstractSqlTemplate.java:274)
    at org.jumpmind.db.sql.JdbcSqlTransaction.executeCallback(JdbcSqlTransaction.java:381)
    at org.jumpmind.db.sql.JdbcSqlTransaction.execute(JdbcSqlTransaction.java:272)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl.doPreBatchAction(BatchDatabaseWriterControl.java:93)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl.beforeWrite(BatchDatabaseWriterControl.java:86)
    at org.openbravo.replication.symmetricds.extensions.BatchDatabaseWriterControl$Proxy$_$$_WeldClientProxy.beforeWrite(BatchDatabaseWriterControl$Proxy$_$$_WeldClientProxy.java)
    at org.jumpmind.symmetric.io.data.writer.AbstractDatabaseWriter.filterBefore(AbstractDatabaseWriter.java:278)
    at org.jumpmind.symmetric.io.data.writer.AbstractDatabaseWriter.write(AbstractDatabaseWriter.java:148)
    at org.jumpmind.symmetric.io.data.writer.NestedDataWriter.write(NestedDataWriter.java:64)
    at org.jumpmind.symmetric.model.ProcessInfoDataWriter.write(ProcessInfoDataWriter.java:65)
    at org.jumpmind.symmetric.io.data.writer.NestedDataWriter.write(NestedDataWriter.java:64)
    at org.jumpmind.symmetric.io.data.writer.TransformWriter.write(TransformWriter.java:207)
    at org.jumpmind.symmetric.io.data.DataProcessor.forEachDataInTable(DataProcessor.java:200)
    at org.jumpmind.symmetric.io.data.DataProcessor.forEachTableInBatch(DataProcessor.java:170)
Steps To ReproduceCheck the store server build
Proposed SolutionShare the same sql statement in different places to prevent wrong sql for oracle. There is already a symmetric ds trigger handler which also needs to enable/disable triggers [1].

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/file/4557d1c17a88/src/org/openbravo/replication/symmetricds/util/SymmetricDSTriggerHandler.java [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0034862RR17Q1.1 closedmtaal Disable trigger sql statement gives error in oracle 

-  Notes
(0093244)
hgbot (developer)
2017-01-08 09:36

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 061d39ff979ab5b184360d894c05885d8618eb68
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Jan 08 09:36:18 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/061d39ff979ab5b184360d894c05885d8618eb68 [^]

Fixes issue 34861: Disable trigger sql statement gives error in oracle
Use the same sql statement in both areas where to enable and disable sym-ds triggers

---
M src/org/openbravo/replication/symmetricds/extensions/BatchDatabaseWriterControl.java
M src/org/openbravo/replication/symmetricds/util/SymmetricDSTriggerHandler.java
---
(0093246)
hgbot (developer)
2017-01-08 13:17

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: b3a19becb31572b00aedfada915e432a9346e2eb
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Jan 08 13:14:26 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/b3a19becb31572b00aedfada915e432a9346e2eb [^]

Related to issue 34861: Disable trigger sql statement gives error in oracle
Backout of changeset as the sql statements are different for different cases, no re-use

---
M src/org/openbravo/replication/symmetricds/extensions/BatchDatabaseWriterControl.java
M src/org/openbravo/replication/symmetricds/util/SymmetricDSTriggerHandler.java
---
(0093247)
hgbot (developer)
2017-01-08 13:17

 Repository: erp/pmods/org.openbravo.replication.symmetricds
Changeset: 9db96249dcaa329faae2112f3b22343a73792de4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Jan 08 13:17:14 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/9db96249dcaa329faae2112f3b22343a73792de4 [^]

Related to issue 34861: Disable trigger sql statement gives error in oracle
List the columns in the insert statement to prevent oracle error

---
M src/org/openbravo/replication/symmetricds/extensions/BatchDatabaseWriterControl.java
---
(0093248)
hgbot (developer)
2017-01-08 17:56

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: b84614d40ad52e0e618c038127727a67da461d05
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Jan 08 17:55:54 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/b84614d40ad52e0e618c038127727a67da461d05 [^]

Related to issue 34861: Disable trigger sql statement gives error in oracle
Call stored procedure in a different way in case of oracle database

---
M src/org/openbravo/retail/storeserver/synchronization/InventoryWriterFilterAdapter.java
---
(0093250)
hgbot (developer)
2017-01-08 23:26

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 998e6867784e90d289bd80ab5e41184b47b1e33d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sun Jan 08 23:26:22 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/998e6867784e90d289bd80ab5e41184b47b1e33d [^]

Related to issue 34861: Disable trigger sql statement gives error in oracle
Remove semi-colon at end, does not work with Oracle

---
M src/org/openbravo/retail/storeserver/synchronization/FinancialAccountBalanceWriterFilterAdapter.java
---
(0093281)
hgbot (developer)
2017-01-09 18:56

 Repository: tools/automation/pi-mobile
Changeset: bc34d713c249b65eb2292a78328a93dbbd3dfd0d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jan 09 18:56:06 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/bc34d713c249b65eb2292a78328a93dbbd3dfd0d [^]

Related to issue 34861: Solve oracle issues in store server build
The getTOP method use the current server for the check if it should oracle or postgres
type of doing count. Add server type parameter to let the correct sql be created
for the target server.

---
M src-test/org/openbravo/test/mobile/retail/mobilecore/database/ConnectionHelper.java
M src-test/org/openbravo/test/mobile/retail/mobilecore/database/MobileCoreDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/offline/OfflineMS005_Cashmanagement.java
M src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store1/MS005_Cashmanagement.java
M src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2005_Cashmanagement.java
---
(0093288)
hgbot (developer)
2017-01-09 23:55

 Repository: tools/automation/pi-mobile
Changeset: 87655669046dfedcc385e29b180013191553ce26
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jan 09 23:54:53 2017 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/87655669046dfedcc385e29b180013191553ce26 [^]

Related to issue 34861: Solve oracle issues in store server build
Solve several queries which are invalid for oracle

---
M src-test/org/openbravo/test/mobile/retail/multiserver/selenium/tests/store2/MSS2005_Cashmanagement.java
M src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/SynchronizationChannels.java
M src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/SynchronizationRouters.java
M src-test/org/openbravo/test/mobile/retail/multiserver/unittests/tests/dbsynch/UnidirectionalBasicSynchronization.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/CMGa10_CashManagementDeposit.java
---
(0093339)
mtaal (manager)
2017-01-11 11:24

 Other related changes to pi-mobile test environment:
https://code.openbravo.com/tools/automation/pi-mobile/rev/a477d2a8ae71 [^]
https://code.openbravo.com/tools/automation/pi-mobile/rev/8abca78bc4d2 [^]
(0093340)
mtaal (manager)
2017-01-11 11:25

 Resolved by previous commits
(0093371)
AugustoMauch (manager)
2017-01-11 17:35

 Code reviewed and verified

- Issue History
Date Modified Username Field Change
2017-01-08 09:09 mtaal New Issue
2017-01-08 09:09 mtaal Assigned To => mtaal
2017-01-08 09:09 mtaal Triggers an Emergency Pack => No
2017-01-08 09:09 mtaal Status new => scheduled
2017-01-08 09:36 hgbot Checkin
2017-01-08 09:36 hgbot Note Added: 0093244
2017-01-08 09:36 hgbot Status scheduled => resolved
2017-01-08 09:36 hgbot Resolution open => fixed
2017-01-08 09:36 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.replication.symmetricds/rev/061d39ff979ab5b184360d894c05885d8618eb68 [^]
2017-01-08 10:19 mtaal Review Assigned To => AugustoMauch
2017-01-08 13:17 hgbot Checkin
2017-01-08 13:17 hgbot Note Added: 0093246
2017-01-08 13:17 hgbot Checkin
2017-01-08 13:17 hgbot Note Added: 0093247
2017-01-08 17:56 hgbot Checkin
2017-01-08 17:56 hgbot Note Added: 0093248
2017-01-08 23:26 hgbot Checkin
2017-01-08 23:26 hgbot Note Added: 0093250
2017-01-09 18:53 mtaal Status resolved => new
2017-01-09 18:53 mtaal Resolution fixed => open
2017-01-09 18:53 mtaal Summary Disable trigger sql statement gives error in oracle => Solve oracle issues in store server build
2017-01-09 18:53 mtaal Description Updated View Revisions
2017-01-09 18:56 hgbot Checkin
2017-01-09 18:56 hgbot Note Added: 0093281
2017-01-09 23:55 hgbot Checkin
2017-01-09 23:55 hgbot Note Added: 0093288
2017-01-11 11:24 mtaal Note Added: 0093339
2017-01-11 11:24 mtaal Status new => scheduled
2017-01-11 11:25 mtaal Note Added: 0093340
2017-01-11 11:25 mtaal Status scheduled => resolved
2017-01-11 11:25 mtaal Resolution open => fixed
2017-01-11 17:35 AugustoMauch Note Added: 0093371
2017-01-11 17:35 AugustoMauch Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker