Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034450 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] StoreServer | major | have not tried | 2016-11-09 13:43 | 2016-11-12 17:19 | |||
| Reporter | mtaal | View Status | public | |||||
| Assigned To | mtaal | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 24ecfabd909e | ||||
| Projection | none | ETA | none | Target Version | RR17Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | AugustoMauch | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034450: MultiServerJSONSymmetricDSStarter should use thread.start instead of thread.run | |||||||
| Description | See the code [1] here, it uses the run method. The run method blocks and waits for the runnable to finish executing. This was not the intention here. The intention here was to start a separate thread. [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/517c35b6e4c5/src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java#l66 [^] | |||||||
| Steps To Reproduce | Put timing log statements (System.err.println(System.currentTimeMillis()) in the doAction method. It will show a 1-2 seconds delay for executing the run method. | |||||||
| Proposed Solution | Use thread.start instead of thread.run | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0091280) hgbot (developer) 2016-11-09 13:50 |
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: 24ecfabd909ef0f7e4c4e6cd3e8d38929bf25f2b Author: Martin Taal <martin.taal <at> openbravo.com> Date: Wed Nov 09 13:44:07 2016 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/24ecfabd909ef0f7e4c4e6cd3e8d38929bf25f2b [^] Fixes issue 34450: MultiServerJSONSymmetricDSStarter should use thread.start instead of thread.run Use Thread.start instead of Thread.run --- M src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java --- |
|
(0091411) AugustoMauch (administrator) 2016-11-12 17:19 |
Code reviewed and verified in [1]@e4fcb8831b41 [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/ [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-11-09 13:43 | mtaal | New Issue | |
| 2016-11-09 13:43 | mtaal | Assigned To | => mtaal |
| 2016-11-09 13:43 | mtaal | OBNetwork customer | => No |
| 2016-11-09 13:43 | mtaal | Triggers an Emergency Pack | => No |
| 2016-11-09 13:50 | hgbot | Checkin | |
| 2016-11-09 13:50 | hgbot | Note Added: 0091280 | |
| 2016-11-09 13:50 | hgbot | Status | new => resolved |
| 2016-11-09 13:50 | hgbot | Resolution | open => fixed |
| 2016-11-09 13:50 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/24ecfabd909ef0f7e4c4e6cd3e8d38929bf25f2b [^] |
| 2016-11-09 13:51 | mtaal | Review Assigned To | => AugustoMauch |
| 2016-11-12 17:19 | AugustoMauch | Note Added: 0091411 | |
| 2016-11-12 17:19 | AugustoMauch | Status | resolved => closed |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |