Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0034290 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Quotations | major | always | 2016-10-25 16:30 | 2017-01-13 20:01 | |||
Reporter | rbianchini | View Status | public | |||||
Assigned To | mario_castello | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR17Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 0514ba64174f | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | RR16Q2.3 | SCM revision | ||||||
Review Assigned To | guilleaer | |||||||
Regression level | Production - Confirmed Stable | |||||||
Regression date | ||||||||
Regression introduced in release | RR16Q2.3 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e62ef3273a5a [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0034290: Error when create anorder from a quotation in some cases | |||||||
Description | If the client is configured to not allow negative stock, and the Web POS stock validation module is installed, when the cashier creates an order from a quotation that contains services, The message "Not enough stock" is shown and the order is not created. But if you add a service in an order, the normal flow is executed. This error is reproduced in 16Q2.3, but it cannot be reproduced in 16Q1.3 | |||||||
Steps To Reproduce | 1 - Install the module "Web POS stock validation" 2 - Configure the client to not allow negative stock 3 - Create a Product with product type "Service" 4 - Log in web pos and create a new Quotation with the product created in previous step 5 - In the menu, click the entry: Create Sales Order 6 - Firm the cuotation and create the sales order 7 - The message "Not enough stock" is shown (wrong, becouse a service is not stocked) | |||||||
Tags | No tags attached. | |||||||
Attached Files | fixStockValidation1.1.305.diff [^] (6,174 bytes) 2016-11-18 15:55 [Show Content]
fixStockValidation1.1.500.diff [^] (9,088 bytes) 2017-01-13 20:01 [Show Content] | |||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||||||||
|
Notes | |
(0090933) hgbot (developer) 2016-10-26 23:49 |
Repository: tools/automation/pi-mobile Changeset: e59ae827dabebdc1a79fe6ac41b48b318ef42128 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed Oct 26 15:49:03 2016 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e59ae827dabebdc1a79fe6ac41b48b318ef42128 [^] Related to issue 34290: Added automated test I34290_OrderFromQuotationWithServiceNotAllowNegativeStock --- A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/stockvalidation/I34290_OrderFromQuotationWithServiceNotAllowNegativeStock.java --- |
(0090934) hgbot (developer) 2016-10-27 00:11 |
Repository: erp/pmods/org.openbravo.retail.stockvalidation Changeset: 725abce813b2ab6f9776371f7caac52530daa7cf Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Wed Oct 26 16:11:29 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^] Fixed issue 34290: Added validation for not consulting the stock of the products that marked as not stocked --- M src/org/openbravo/retail/stockvalidation/OrderFromQuotationStockChecker.java M web/org.openbravo.retail.stockvalidation/js/modals.js --- |
(0091169) marvintm (manager) 2016-11-04 11:39 |
The general idea of the fix (not to check stock in case the product is not stockable) is correct, but the way this is implemented is not the most efficient. Instead of doing the request to the backend and then checking the property there, the request could be avoided entirely, which would save us quite a bit of overhead, and would also improve perceived performance by the user. |
(0091215) hgbot (developer) 2016-11-07 23:14 |
Repository: erp/pmods/org.openbravo.retail.stockvalidation Changeset: 0514ba64174fb31ff45e85f9e459dbb662bec0f2 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Nov 07 15:22:34 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/0514ba64174fb31ff45e85f9e459dbb662bec0f2 [^] Fixed issue 34290: Added validation for the products that have been marked as not stocked. Prevent to execute the stock validation process in the backend for this products. --- M web/org.openbravo.retail.stockvalidation/js/modals.js --- |
(0091464) rbianchini (developer) 2016-11-14 15:20 |
Hello, Can i have a patch for Openbravo 3.0 PR16Q2.3, please? |
(0093081) rbianchini (developer) 2016-12-30 15:34 |
Hello, Can i have a patch for Openbravo 3.0 RR16Q3.4, please? |
Issue History | |||
Date Modified | Username | Field | Change |
2016-10-25 16:30 | rbianchini | New Issue | |
2016-10-25 16:30 | rbianchini | Assigned To | => Retail |
2016-10-25 16:30 | rbianchini | Resolution time | => 1479178800 |
2016-10-25 16:30 | rbianchini | Regression level | => Production - Confirmed Stable |
2016-10-25 16:30 | rbianchini | Regression introduced in release | => RR16Q2.3 |
2016-10-25 16:30 | rbianchini | Triggers an Emergency Pack | => No |
2016-10-25 18:01 | mario_castello | Assigned To | Retail => mario_castello |
2016-10-25 20:06 | mario_castello | Status | new => acknowledged |
2016-10-25 20:43 | mario_castello | Status | acknowledged => scheduled |
2016-10-26 23:49 | hgbot | Checkin | |
2016-10-26 23:49 | hgbot | Note Added: 0090933 | |
2016-10-27 00:11 | hgbot | Checkin | |
2016-10-27 00:11 | hgbot | Note Added: 0090934 | |
2016-10-27 00:11 | hgbot | Status | scheduled => resolved |
2016-10-27 00:11 | hgbot | Resolution | open => fixed |
2016-10-27 00:11 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^] |
2016-11-04 11:39 | marvintm | Note Added: 0091169 | |
2016-11-04 11:39 | marvintm | Status | resolved => new |
2016-11-04 11:39 | marvintm | Resolution | fixed => open |
2016-11-04 11:39 | marvintm | Status | new => scheduled |
2016-11-07 23:14 | hgbot | Checkin | |
2016-11-07 23:14 | hgbot | Note Added: 0091215 | |
2016-11-07 23:14 | hgbot | Status | scheduled => resolved |
2016-11-07 23:14 | hgbot | Resolution | open => fixed |
2016-11-07 23:14 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/725abce813b2ab6f9776371f7caac52530daa7cf [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.stockvalidation/rev/0514ba64174fb31ff45e85f9e459dbb662bec0f2 [^] |
2016-11-11 14:06 | guilleaer | Resolution time | 1479178800 => 1479164400 |
2016-11-11 14:06 | guilleaer | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e62ef3273a5a [^] |
2016-11-11 16:47 | guilleaer | Review Assigned To | => guilleaer |
2016-11-11 16:47 | guilleaer | Status | resolved => closed |
2016-11-11 16:47 | guilleaer | Fixed in Version | => RR17Q1 |
2016-11-14 15:20 | rbianchini | Note Added: 0091464 | |
2016-11-18 15:55 | mario_castello | File Added: fixStockValidation1.1.305.diff | |
2016-11-28 19:52 | dmitry_mezentsev | Relationship added | caused by 0032368 |
2016-12-30 15:34 | rbianchini | Note Added: 0093081 | |
2017-01-13 18:32 | mario_castello | Relationship added | related to 0034954 |
2017-01-13 18:33 | mario_castello | Relationship deleted | related to 0034954 |
2017-01-13 19:40 | mario_castello | File Added: 34290fixStockValidation1.1.500.diff | |
2017-01-13 19:41 | mario_castello | Relationship added | has duplicate 0034954 |
2017-01-13 20:01 | mario_castello | File Deleted: 34290fixStockValidation1.1.500.diff | |
2017-01-13 20:01 | mario_castello | File Added: fixStockValidation1.1.500.diff |
Copyright © 2000 - 2009 MantisBT Group |