Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0034200
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2016-10-13 14:502016-12-16 18:37
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR17Q1
StatusclosedFix in branchFixed in SCM revision69400c6e986b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034200: client side callouts are executed twice when picking a value in a selector drop down

DescriptionWhen a selector field has associated a client side callout and a value for that field is picked from drop down list, the callout is executed twice.

Note when selecting the value from selector's popup the problem is not reproducible.
Steps To Reproduce1. Define a client side callout for Sales Order > Lines > Product field. Ie. paste following code in browser's console:

  OB.OnChangeRegistry.register('187', 'product',
    function(item, view, form, grid) {
     console.log('product changed');
    }
  )

2. Create a Sales Order line
3. Open product drop down and select any value
  -> ERROR: in console 'product changed' appears twice, but it is expected to appear just once
TagsPerformance
Attached Files? file icon 34200.export [^] (2,241 bytes) 2016-10-13 16:00

- Relationships Relation Graph ] Dependency Graph ]
duplicate of defect 0030808 closedplatform Hook call twice in onChange function javascript 
related to defect 00228213.0MP21 closedAugustoMauch Callout not executed when writing the whole name in a selector 

-  Notes
(0090560)
hgbot (developer)
2016-10-14 07:29

Repository: erp/devel/pi
Changeset: 69400c6e986bdcc84368f635553c8f8fe7fbdd5b
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Oct 13 15:59:17 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/69400c6e986bdcc84368f635553c8f8fe7fbdd5b [^]

fixed bug 34200: client side callouts executed twice

  When picking a value from a selector drop down, its associated client side
  callouts were executed twice.

  The problem was caused because in this situation fullIdentifierEntered flag
  was set to true and it causes the field blur event to trigger again the callouts.

  It has been prevented by adding a new valuePicked flag which is set to true
  when a value is picked from drop down, in this case fullIdentifierEntered is
  not set to true.

---
M modules/org.openbravo.userinterface.selector/web/org.openbravo.userinterface.selector/js/ob-selector-item.js
---
(0090757)
caristu (developer)
2016-10-21 11:40

Code reviewed + tested OK: client side callout is not executed twice anymore after selecting a value from the picking list.
(0092504)
hudsonbot (developer)
2016-12-16 18:37

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/dc8bf00badd0 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-10-13 14:50 alostale New Issue
2016-10-13 14:50 alostale Assigned To => platform
2016-10-13 14:50 alostale Modules => Core
2016-10-13 14:50 alostale Triggers an Emergency Pack => No
2016-10-13 14:50 alostale Relationship added related to 0022821
2016-10-13 14:51 alostale Status new => scheduled
2016-10-13 14:51 alostale Assigned To platform => alostale
2016-10-13 14:51 alostale Review Assigned To => caristu
2016-10-13 16:00 alostale File Added: 34200.export
2016-10-14 07:29 hgbot Checkin
2016-10-14 07:29 hgbot Note Added: 0090560
2016-10-14 07:29 hgbot Status scheduled => resolved
2016-10-14 07:29 hgbot Resolution open => fixed
2016-10-14 07:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/69400c6e986bdcc84368f635553c8f8fe7fbdd5b [^]
2016-10-14 07:32 alostale Tag Attached: Performance
2016-10-21 11:40 caristu Note Added: 0090757
2016-10-21 11:40 caristu Status resolved => closed
2016-10-21 11:40 caristu Fixed in Version => 3.0PR17Q1
2016-10-31 17:42 caristu Relationship added duplicate of 0030808
2016-12-16 18:37 hudsonbot Checkin
2016-12-16 18:37 hudsonbot Note Added: 0092504


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker