Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0034081 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | have not tried | 2016-09-25 14:52 | 2016-09-27 18:44 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR16Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | f27fd70782c9 | ||||
Projection | none | ETA | none | Target Version | RR16Q4 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | Sandrahuguet | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0034081: Data customer/address save: remove code which is never used | |||||||
Description | The data customer and address save js files have some code which is never used and can be removed. datacustomeraddrsave.js has the variable customerAddrListToChange and its usage, it is only set but never used, its declaration and usage ([1]) can be removed datacustomersave.js: has the variable customersListToChange ([2]) which is never used, it can be removed. [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b09d17f57c4b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l30 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/b09d17f57c4b/web/org.openbravo.retail.posterminal/js/data/datacustomersave.js#l30 [^] | |||||||
Steps To Reproduce | Load webpos check the full source code for the above variables | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0090270) hgbot (developer) 2016-09-26 15:56 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: f27fd70782c915d434ec2e33d0ee73705d5dc1a8 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Mon Sep 26 15:55:39 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f27fd70782c915d434ec2e33d0ee73705d5dc1a8 [^] Fixes issue 34081: Data customer/address save: remove code which is never used Removed not-used code --- M web/org.openbravo.retail.posterminal/js/data/datacustomeraddrsave.js M web/org.openbravo.retail.posterminal/js/data/datacustomersave.js --- |
(0090310) Sandrahuguet (developer) 2016-09-27 18:44 |
Reviewed and tested |
Issue History | |||
Date Modified | Username | Field | Change |
2016-09-25 14:52 | mtaal | New Issue | |
2016-09-25 14:52 | mtaal | Assigned To | => mtaal |
2016-09-25 14:52 | mtaal | Triggers an Emergency Pack | => No |
2016-09-26 15:55 | mtaal | Review Assigned To | => Sandrahuguet |
2016-09-26 15:56 | hgbot | Checkin | |
2016-09-26 15:56 | hgbot | Note Added: 0090270 | |
2016-09-26 15:56 | hgbot | Status | new => resolved |
2016-09-26 15:56 | hgbot | Resolution | open => fixed |
2016-09-26 15:56 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f27fd70782c915d434ec2e33d0ee73705d5dc1a8 [^] |
2016-09-27 18:44 | Sandrahuguet | Note Added: 0090310 | |
2016-09-27 18:44 | Sandrahuguet | Status | resolved => closed |
2016-09-27 18:44 | Sandrahuguet | Fixed in Version | => RR16Q4 |
Copyright © 2000 - 2009 MantisBT Group |