Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0033849 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] StoreServer | critical | have not tried | 2016-08-30 09:28 | 2016-09-05 13:23 | |||
Reporter | mtaal | View Status | public | |||||
Assigned To | mtaal | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | ||||
Status | closed | Fix in branch | Fixed in SCM revision | 16bb47434364 | ||||
Projection | none | ETA | none | Target Version | RR16Q4 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | AugustoMauch | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0033849: Infinite loop when exception in SynchronizedServerProcessCaller.afterReturnFromCentral - also check other datas for synced data | |||||||
Description | If an exception occurs here [1] then the retries++ here [2] is never reached and the loop [3] will never end. See an example of an exception [5]. Another improvement is to not return to early [4], continue to check also other data if present. [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/5d4b82d17abe/src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java#l136 [^] [2] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/5d4b82d17abe/src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java#l175 [^] [3] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/5d4b82d17abe/src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java#l130 [^] [4] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/5d4b82d17abe/src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java#l164 [^] [5] 2016-08-30 06:22:59,101 [TP-Processor6] ERROR org.openbravo.mobile.core.servercontroller.SynchronizedServerProcessCaller - No bean found for type class org.openbravo.retail.sessions.OpenSessionPOS java.lang.IllegalArgumentException: No bean found for type class org.openbravo.retail.sessions.OpenSessionPOS at org.openbravo.base.weld.WeldUtils.getInstanceFromStaticBeanManager(WeldUtils.java:97) at org.openbravo.mobile.core.process.MobileServiceProcessor.getServiceClassInstances(MobileServiceProcessor.java:162) at org.openbravo.mobile.core.servercontroller.SynchronizedServerProcessCaller.afterReturnFromCentral(SynchronizedServerProcessCaller.java:134) at org.openbravo.mobile.core.servercontroller.MultiServerJSONProcess.executeFromWebPOSInStore(MultiServerJSONProcess.java:359) at org.openbravo.mobile.core.servercontroller.MultiServerJSONProcess.exec(MultiServerJSONProcess.java:162) at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:59) at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:56) at org.openbravo.mobile.core.process.MobileServiceProcessor.execProcess(MobileServiceProcessor.java:117) at org.openbravo.mobile.core.process.MobileServiceProcessor.execServiceName(MobileServiceProcessor.java:79) at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:89) at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:59) at javax.servlet.http.HttpServlet.service(HttpServlet.java:637) at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228) at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:431) at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:87) at org.openbravo.mobile.core.process.WebServiceAuthenticatedServlet.service(WebServiceAuthenticatedServlet.java:60) | |||||||
Steps To Reproduce | Force an exception in the above code line | |||||||
Proposed Solution | Move the retries++ to just within the outside loop (it was in a wrong place anyway). | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0089562) hgbot (developer) 2016-08-30 22:16 |
Repository: erp/pmods/org.openbravo.mobile.core Changeset: 16bb47434364bfabecf52db0c1aeb98ff55c5666 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Aug 30 22:16:04 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/16bb47434364bfabecf52db0c1aeb98ff55c5666 [^] Fixes issue 33849: Infinite loop when exception in SynchronizedServerProcessCaller.afterReturnFromCentra Fixes issue 33718: NPE in Synchronized Process Caller if DataSynchronizationProcess does not define a valid DataSynchronization Used continue statement (33718), put retries++ after catch block and also try all processors --- M src/org/openbravo/mobile/core/servercontroller/SynchronizedServerProcessCaller.java --- |
(0089755) AugustoMauch (administrator) 2016-09-05 13:23 |
Code reviewed and verified in [1]@85572744adce [1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/ [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2016-08-30 09:28 | mtaal | New Issue | |
2016-08-30 09:28 | mtaal | Assigned To | => mtaal |
2016-08-30 09:28 | mtaal | OBNetwork customer | => No |
2016-08-30 09:28 | mtaal | Triggers an Emergency Pack | => No |
2016-08-30 09:30 | mtaal | Summary | Infinite loop in case of exception in SynchronizedServerProcessCaller.afterReturnFromCentral => Infinite loop when exception in SynchronizedServerProcessCaller.afterReturnFromCentral - also check other datas for synced data |
2016-08-30 09:30 | mtaal | Description Updated | View Revisions |
2016-08-30 22:16 | hgbot | Checkin | |
2016-08-30 22:16 | hgbot | Note Added: 0089562 | |
2016-08-30 22:16 | hgbot | Status | new => resolved |
2016-08-30 22:16 | hgbot | Resolution | open => fixed |
2016-08-30 22:16 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/16bb47434364bfabecf52db0c1aeb98ff55c5666 [^] |
2016-08-30 22:17 | mtaal | Review Assigned To | => AugustoMauch |
2016-08-31 09:22 | mtaal | File Added: but-33849.diff | |
2016-09-05 13:23 | AugustoMauch | Note Added: 0089755 | |
2016-09-05 13:23 | AugustoMauch | Status | resolved => closed |
Copyright © 2000 - 2009 MantisBT Group |