0033677: 'Refresh' of widgets in workspace takes very long with user having access to many organizations

Description

In an environment with 524 organization and a user having access to them (i.e. Openbravo user) the request behind 'Refresh' of widgets of workspace (also done during login) takes very long (4-5seconds)

Also it is doing a very high number of sql-queries as it seems to loop over all those organizations and doing at least
1.) ad org lookup
2.) widget instance search

for the 'copyWidgets' function.

Note: getProxy is not full fix as some code in MyOBUtils.getDefaultWidgetInstances reads client from the org object.

widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_CLIENT,
organization.getClient()));

Steps To Reproduce

Check runtime of that request
Trace sqls done during this request.

Tags

Performance

Attached Files

33677_partial.diff [^] (4,564 bytes) 2016-08-10 11:17 [Show Content] [Hide Content]

diff -r 6df19843e498 modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java
--- a/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java	Thu Jun 30 19:41:31 2016 +0200
+++ b/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOBUtils.java	Wed Aug 10 11:17:37 2016 +0200
@@ -138,10 +138,10 @@
       widgetInstancesCrit.setFilterOnReadableClients(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_RELATIVEPRIORITY, 0L));
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_CLIENT, OBDal.getInstance()
-          .get(Client.class, "0")));
+          .getProxy(Client.class, "0")));
       widgetInstancesCrit.setFilterOnReadableOrganization(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_ORGANIZATION, OBDal
-          .getInstance().get(Organization.class, "0")));
+          .getInstance().getProxy(Organization.class, "0")));
     } else if ("SYSTEM".equals(availableAtLevel)) {
       widgetInstancesCrit.setFilterOnReadableClients(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_RELATIVEPRIORITY, 1L));
@@ -149,14 +149,14 @@
           .get(Client.class, "0")));
       widgetInstancesCrit.setFilterOnReadableOrganization(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_ORGANIZATION, OBDal
-          .getInstance().get(Organization.class, "0")));
+          .getInstance().getProxy(Organization.class, "0")));
     } else if ("CLIENT".equals(availableAtLevel)) {
       widgetInstancesCrit.setFilterOnReadableClients(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_CLIENT, OBDal.getInstance()
           .get(Client.class, availableAtValues[0])));
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_RELATIVEPRIORITY, 2L));
     } else if ("ORG".equals(availableAtLevel)) {
-      final Organization organization = OBDal.getInstance().get(Organization.class,
+      final Organization organization = OBDal.getInstance().getProxy(Organization.class,
           availableAtValues[0]);
       widgetInstancesCrit.setFilterOnReadableClients(false);
       widgetInstancesCrit.add(Restrictions.eq(WidgetInstance.PROPERTY_CLIENT,
@@ -187,12 +187,14 @@
     OBCriteria<WidgetInstance> obc = OBDal.getInstance().createCriteria(WidgetInstance.class);
     obc.setFilterOnReadableClients(false);
     obc.setFilterOnActive(isActive);
-    obc.add(Restrictions.eq(WidgetInstance.PROPERTY_CLIENT,
-        OBDal.getInstance().get(Client.class, OBContext.getOBContext().getCurrentClient().getId())));
+    obc.add(Restrictions.eq(
+        WidgetInstance.PROPERTY_CLIENT,
+        OBDal.getInstance().getProxy(Client.class,
+            OBContext.getOBContext().getCurrentClient().getId())));
     obc.add(Restrictions.eq(WidgetInstance.PROPERTY_VISIBLEATROLE,
-        OBDal.getInstance().get(Role.class, OBContext.getOBContext().getRole().getId())));
+        OBDal.getInstance().getProxy(Role.class, OBContext.getOBContext().getRole().getId())));
     obc.add(Restrictions.eq(WidgetInstance.PROPERTY_VISIBLEATUSER,
-        OBDal.getInstance().get(User.class, OBContext.getOBContext().getUser().getId())));
+        OBDal.getInstance().getProxy(User.class, OBContext.getOBContext().getUser().getId())));
     return obc.list();
   }
 
diff -r 6df19843e498 modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java
--- a/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java	Thu Jun 30 19:41:31 2016 +0200
+++ b/modules/org.openbravo.client.myob/src/org/openbravo/client/myob/MyOpenbravoComponent.java	Wed Aug 10 11:17:37 2016 +0200
@@ -255,11 +255,11 @@
   private void copyWidgets() {
     final List<WidgetInstance> userWidgets = new ArrayList<WidgetInstance>(
         MyOBUtils.getUserWidgetInstances(false));
-    final User user = OBDal.getInstance().get(User.class,
+    final User user = OBDal.getInstance().getProxy(User.class,
         OBContext.getOBContext().getUser().getId());
-    final Role role = OBDal.getInstance().get(Role.class,
+    final Role role = OBDal.getInstance().getProxy(Role.class,
         OBContext.getOBContext().getRole().getId());
-    final Client client = OBDal.getInstance().get(Client.class,
+    final Client client = OBDal.getInstance().getProxy(Client.class,
         OBContext.getOBContext().getCurrentClient().getId());
     final Set<WidgetInstance> defaultWidgets = new HashSet<WidgetInstance>();

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

feature request

0035980

closed

caristu

Improve the time spent to load the widgets after log-in

Notes
(0088938) shuehner (administrator) 2016-08-10 11:18	Partial patch only for a start, not fixing the whole issue.

(0098259) alostale (manager) 2017-07-28 11:20	fixed by 0035980

Issue History
Date Modified	Username	Field	Change
2016-08-10 11:16	shuehner	New Issue
2016-08-10 11:16	shuehner	Assigned To	=> platform
2016-08-10 11:16	shuehner	Modules	=> Core
2016-08-10 11:16	shuehner	Triggers an Emergency Pack	=> No
2016-08-10 11:16	shuehner	Tag Attached: Performance
2016-08-10 11:17	shuehner	File Added: 33677_partial.diff
2016-08-10 11:18	shuehner	Note Added: 0088938
2016-12-01 13:06	alostale	Status	new => acknowledged
2016-12-01 14:03	alostale	Priority	normal => high
2017-07-28 11:20	alostale	Status	acknowledged => scheduled
2017-07-28 11:20	alostale	Note Added: 0098259
2017-07-28 11:20	alostale	Status	scheduled => closed
2017-07-28 11:20	alostale	Resolution	open => out of date
2017-07-28 11:20	alostale	Relationship added	duplicate of 0035980