Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033676
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2016-08-10 10:392016-08-19 10:39
ReportervmromanosView Statuspublic 
Assigned ToRetail 
PriorityimmediateResolutionfixedFixed in VersionRR16Q2.2
StatusclosedFix in branchFixed in SCM revision8d0e69594348
ProjectionnoneETAnoneTarget VersionRR16Q2.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033676: FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner

DescriptionThe FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner.

The ERP always sets the business partner information when creating the PSD from an invoice or an order (through extension points on C_Invoice_Post and C_Order_Post). However the POS doesn't fill it.

When the order is directly paid from the POS there is no problem. However, credit orders generated from POS couldn't be paid in the ERP after fixing 0033629, because that fix requires to have the Business Partner information.
Steps To Reproduce1. Create and pay and order in POS
2. Go to the ERP and search for the associated payment (Sales Order | Payment Plan | Payment Details, and browse to the Payment In window)
3. Inside the Payment In window, go to Lines tab and verify Business Partner field is empty. It should have the order's business partner
Proposed SolutionModify OrderLoader
Ensure created PSD has set the business partner:
paymentScheduleDetail.setBusinessPartner(order.getBusinessPartner());

Wrong data PSD should be updated. You can reuse module script UpdateBpPaymentLine.
It's recommended to modify the update queries to filter by isinvoicepaid = 'N', so it performs faster:

update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_invoice i, fin_payment_schedule ps
                     where ps.fin_payment_schedule_id = fin_payment_schedule_invoice
                     and ps.c_invoice_id = i.c_invoice_id)
where c_bpartner_id is null and fin_payment_schedule_invoice is not null and isinvoicepaid = 'N';


update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_order o, fin_payment_schedule ps
                                                     where ps.fin_payment_schedule_id = fin_payment_schedule_order
                                                     and ps.c_order_id = o.c_order_id)
where c_bpartner_id is null and fin_payment_schedule_order is not null
and fin_payment_schedule_invoice is null and isinvoicepaid = 'N';
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0033671 closedmario_castello FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner 

-  Notes
(0089220)
hgbot (developer)
2016-08-18 16:50

Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: 8d0e695943483738a435cc250e43ed38c41cf7f6
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Aug 17 09:16:59 2016 -0600
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/8d0e695943483738a435cc250e43ed38c41cf7f6 [^]

Fixed issue 0033676: Added Business Partner for FIN_PaymentScheduleDetail for Orders created from POS

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2016-08-10 11:09 Orekaria Type defect => backport
2016-08-10 11:09 Orekaria Target Version => RR16Q2.2
2016-08-18 16:50 hgbot Checkin
2016-08-18 16:50 hgbot Note Added: 0089220
2016-08-18 16:50 hgbot Status scheduled => resolved
2016-08-18 16:50 hgbot Resolution open => fixed
2016-08-18 16:50 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/8d0e695943483738a435cc250e43ed38c41cf7f6 [^]
2016-08-19 10:39 guilleaer Review Assigned To => guilleaer
2016-08-19 10:39 guilleaer Status resolved => closed
2016-08-19 10:39 guilleaer Fixed in Version => RR16Q2.2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker