Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033463
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-07-12 11:242016-08-12 08:44
ReporterSanjotaView Statuspublic 
Assigned Tovmromanos 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb3823e11c33d
ProjectionnoneETAnoneTarget Version
OSAnyDatabasePostgreSQLJava version1.7
OS VersionDatabase version9.3Ant version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033463: API Change Request : Change in the signature of the method selectFactAcct() present in AccountTree_Data.xsql

DescriptionRelated to issue 33460 : Ability to launch the report without comparing it with a previous year

The Balance sheet and PL report always expect reference year(Reference Year is mandatory)

We wanted to make Reference year as optional. So created new field called "Compare To", based on which the reference year field can be put as Optional.

The xsql query in charge of getting the data now has a new parameter to control whether to query or not for the comparative year. Thus we can improve the performance of the query, avoiding to retrieve data that is not going to be shown later on in the report.
 
This xsql file builds a public class and method. The method now has a new parameter which creates the API change:


Missing
method org.openbravo.erpCommon.businessUtility.AccountTreeData.selectFactAcct(org.openbravo.database.ConnectionProvider, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String): missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
method org.openbravo.erpCommon.businessUtility.AccountTreeData.selectFactAcct(org.openbravo.database.ConnectionProvider, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, int, int): missing in /srv/ci/workspace/try-full-pgsql/SANDBOX/api-checks/output/java
Steps To Reproducehttps://ci.openbravo.com//job/try-api/3759/ [^]
Proposed SolutionThe API change has a very low impact.
This method is only used by Core, in the balance sheet & PL report we are modifying.
We have checked that none of the modules in the forge use that method, so the API change can be safely approved.

TagsApproved
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0033460 closedSanjota Ability to launch the report without comparing it with a previous year 

-  Notes
(0088961)
dmitry_mezentsev (developer)
2016-08-10 20:19

Sorry about the delay
(0089067)
hgbot (developer)
2016-08-12 08:42

Repository: erp/devel/api-checks
Changeset: b3823e11c33d79b08659da3bf61990d5daa7168e
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Aug 12 08:35:38 2016 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/b3823e11c33d79b08659da3bf61990d5daa7168e [^]

Fixed bug 33463: Java (from xsql) API change related to issue 33460

The xsql query in charge of getting the data now has a new parameter to control whether to query or not for the comparative year. Thus we can improve the performance of the query, avoiding to retrieve data that is not going to be shown later on in the report.

This xsql file builds a public Java class and method. The method now has a new parameter which creates the API change.

---
M java/reference/java.japi.gz
---

- Issue History
Date Modified Username Field Change
2016-07-12 11:24 Sanjota New Issue
2016-07-12 11:24 Sanjota Assigned To => dmitry_mezentsev
2016-07-12 11:24 Sanjota Modules => Core
2016-07-12 11:24 Sanjota Triggers an Emergency Pack => No
2016-07-12 11:26 Sanjota Relationship added blocks 0033460
2016-07-12 11:27 Sanjota Review Assigned To => dmitry_mezentsev
2016-07-12 11:42 vmromanos Priority none => immediate
2016-07-12 11:42 vmromanos Type feature request => defect
2016-07-12 11:42 vmromanos Description Updated View Revisions
2016-07-12 11:42 vmromanos Proposed Solution updated
2016-08-10 20:19 dmitry_mezentsev Tag Attached: Approved
2016-08-10 20:19 dmitry_mezentsev Assigned To dmitry_mezentsev => Sanjota
2016-08-10 20:19 dmitry_mezentsev Note Added: 0088961
2016-08-12 08:31 vmromanos Status new => scheduled
2016-08-12 08:31 vmromanos Assigned To Sanjota => vmromanos
2016-08-12 08:42 hgbot Checkin
2016-08-12 08:42 hgbot Note Added: 0089067
2016-08-12 08:42 hgbot Status scheduled => resolved
2016-08-12 08:42 hgbot Resolution open => fixed
2016-08-12 08:42 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/b3823e11c33d79b08659da3bf61990d5daa7168e [^]
2016-08-12 08:44 vmromanos Review Assigned To dmitry_mezentsev => vmromanos
2016-08-12 08:44 vmromanos Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker