Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033014
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajoralways2016-05-20 10:502016-05-20 15:13
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version3.0PR16Q1.2
StatusclosedFix in branchFixed in SCM revisioncaf1d686ebe1
ProjectionnoneETAnoneTarget Version3.0PR16Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression levelProduction - QA Approved
Regression date2015-11-23
Regression introduced in release3.0PR16Q1
Regression introduced by commithttp://code.openbravo.com/erp/devel/pi/rev/0533c8d6569d7ca75ba77ecb7bcb224b1ff681a1 [^]
Triggers an Emergency PackNo
Summary

0033014: error in Instance Activation window when using an expired license

DescriptionWhen an instance is activated with an expired license, Instance Activation window displays an internal error in UI instead of the correct one notifying the license has expired.
Steps To ReproduceTry to activate an instance with an expired license.
  1. In UI you get the error attached as screenshot
  2. The following trace appears in log:
  java.lang.IllegalArgumentException: No enum constant org.openbravo.erpCommon.obps.ModuleLicenseRestrictions.MsgSeverity.Error
        at java.lang.Enum.valueOf(Enum.java:236)
        at org.openbravo.erpCommon.obps.ModuleLicenseRestrictions$MsgSeverity.valueOf(ModuleLicenseRestrictions.java:52)
        at org.openbravo.erpCommon.obps.ActivationKey.getActivationMessage(ActivationKey.java:842)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.printPageActive(InstanceManagement.java:326)
        at org.openbravo.erpCommon.ad_forms.InstanceManagement.doPost(InstanceManagement.java:67)
Proposed SolutionIf suffering this situation, please contact Openbravo support.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0033012 closedalostale error in Instance Activation window when using an expired license 

-  Notes
(0086598)
hgbot (developer)
2016-05-20 11:35

Repository: erp/backports/3.0PR16Q1.2
Changeset: caf1d686ebe1aaabe4cfc5ea567b6f9425944593
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Fri May 20 11:08:28 2016 +0200
URL: http://code.openbravo.com/erp/backports/3.0PR16Q1.2/rev/caf1d686ebe1aaabe4cfc5ea567b6f9425944593 [^]

fixed bug 33014: error in Instance Activation when using an expired license

  When using a license within an erroneous state (such as expired), message severity
  was incorrectly obtained from the enum, causing an exception to be thrown.

  Fixed by using MsgSeverity.forType method instead of valueOf. forType method
  was designed with this purpose.

  In addition, some other changes have been done on MsgSeverity enum:
   * valueOf method is static so no need to invoke it on an instance (to may be
     another one, which is weird).
   * checking with actual type rather than with toString (which might change)
   * reversed comparision order to prevent NPE in case param in null

---
M src/org/openbravo/erpCommon/obps/ActivationKey.java
M src/org/openbravo/erpCommon/obps/ModuleLicenseRestrictions.java
---
(0086623)
AugustoMauch (developer)
2016-05-20 15:13

Code reviewed and verified in [1]@caf1d686ebe1

[1] https://code.openbravo.com/erp/backports/3.0PR16Q1.2 [^]

- Issue History
Date Modified Username Field Change
2016-05-20 10:52 alostale Type defect => backport
2016-05-20 10:52 alostale Target Version => 3.0PR16Q1.2
2016-05-20 11:35 hgbot Checkin
2016-05-20 11:35 hgbot Note Added: 0086598
2016-05-20 11:35 hgbot Status scheduled => resolved
2016-05-20 11:35 hgbot Resolution open => fixed
2016-05-20 11:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR16Q1.2/rev/caf1d686ebe1aaabe4cfc5ea567b6f9425944593 [^]
2016-05-20 11:35 alostale Review Assigned To => AugustoMauch
2016-05-20 15:13 AugustoMauch Note Added: 0086623
2016-05-20 15:13 AugustoMauch Status resolved => closed
2016-05-20 15:13 AugustoMauch Fixed in Version => 3.0PR16Q1.2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker