Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031697 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] Z. Others | minor | always | 2015-12-11 12:53 | 2016-02-02 09:43 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | vmromanos | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ad230fc1c0f1 | ||||
| Projection | none | ETA | none | Target Version | 3.0PR16Q1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031697: Bank Statement Line description overwritten with GL Item's description when adding gl item transaction form Match Statement | |||||||
| Description | Bank Statement Line description overwritten with GL Item's description when adding gl item transaction form Match Statement | |||||||
| Steps To Reproduce | 1. Access Cuenta de Banco financial account, create new Bank Statement record 2. Add Bank Statement line setting any amount and Description as "bsl description". Process bank statement 3. Run "Match Statement" process and press Add Transaction button (+) from your line. Realize that Description field "bsl description" 4. Select any GL Item in the combo. Realize that Description field has been overwritten with GL Item's description If you follow similar process in version prior to refctor (for example MP30.3) you can verify that description field is maintained | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0082869) AtulOpenbravo (developer) 2015-12-18 11:06 |
Test Plan A - Access Cuenta de Banco financial account, create new Bank Statement record - Add Bank Statement line setting any amount and Description as "bsl description". Process bank statement - Run "Match Statement" process and press Add Transaction button (+) from your line. Check that Description field "bsl description" - Select any GL Item in the combo. Check that Description field value has been appended with GL Item's description. - Select other GL item in the combo than the previous one. - Check that Description field value exists and appended with new GL Item Description by removing old GL Item Description. Test Plan B - Access Financial Account window, in "Cuenta de Banco" account nagivate to Transaction Tab. - Create new record. set some description as test description. - Select GL Item. - Check that earlier description is appended with GL Item description. - Select other GL Item than the previous one. - Check that earlier description is appended with new GL Item description by removing earlier GL Item description. |
|
(0082950) AtulOpenbravo (developer) 2015-12-22 20:25 |
Test Plan C - Access Cuenta de Banco financial account, create new Bank Statement record - Add Bank Statement line setting any amount and Description as "bsl description". Process bank statement - Run "Match Statement" process and press Add Transaction button (+) from your line. Check that Description field "bsl description" - In payment selector, check whether there is payment select it else using (+) create a new payment. - Check that Description field value exists and appended with new Payment Description. - In payment either select other payment record or using (+) create a another payment. - Check that Description "bsl description" still exists and new payment description is appended to it. - Make the payment field blank and check that "bsl description" exists and payment description added in previous step is removed. |
|
(0082951) AtulOpenbravo (developer) 2015-12-22 20:29 |
Test Plan D - Access Financial Account window, in "Cuenta de Banco" account nagivate to Transaction Tab. - Create new record. set some description as "test description". - Select GL Item. - Check that earlier description is appended with GL Item description. - Select other GL Item than the previous one. - Check that earlier description is appended with new GL Item description by removing earlier GL Item description. - Remove the GL Item from selector and make it blank check that manually entered description still exists. - Now instead of GL Item add payment in payment selector or create new using (+). - Check that "test description" is appended with payment description. - Make payment field blank and check that payment description is removed and manually entered "test description" still exists. |
|
(0082980) hgbot (developer) 2015-12-24 11:27 |
Repository: erp/devel/pi Changeset: 2dfae5bc1ff6557dcd68880d03c8ae8571cd827b Author: Atul Gaware <atul.gaware <at> openbravo.com> Date: Wed Dec 23 01:08:07 2015 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/2dfae5bc1ff6557dcd68880d03c8ae8571cd827b [^] Fixes Issue 31697:Bank Statement Line description overwritten with GL Item's or payment's description when adding gl item or payment in add transaction of Match Statement Process. This issue is fixed in two area's 1. Add Transaction Process Definition window in Match Statement. 2. Transaction Tab of Financial Account window. Whenever there exists a description prior adding gl item or payment in above both cases description is appended with either gl item description or payment description. --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddTransactionOnChangePaymentActionHandler.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/GLItemTransactionActionHandler.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js M src/org/openbravo/erpCommon/ad_callouts/SE_GLItem_Transaction.java M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java --- |
|
(0082981) hgbot (developer) 2015-12-24 11:27 |
Repository: erp/devel/pi Changeset: ad230fc1c0f1641dec56661e756d54812ede9917 Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com> Date: Wed Dec 23 18:48:11 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/ad230fc1c0f1641dec56661e756d54812ede9917 [^] Fixed bug 31697: code review improvements In case of removing a gl item from a transaction, the part of the transaction's description related to the GL Item (and everything else afterwards) will be deleted. The part of the transaction's description before the GL Item description will be always kept. The same behavior is applied when adding a new transaction from the Financial Account window and from the Match Statement --> Add transaction process In case of removing a payment, the behavior is similar to the GL Item described above. However, since the payment description doesn't follow a constant structure (like in the case of GL Item's description), it's very hard to detect the description on the fly. That means that the flow will only work just after saving the transaction or in the first change after loading the transaction, which are the common flows. If the user selects different payments without saving the record, the system will append the different payment's description to the transaction. The getFinAccTransactionDescription() method: 1. won't append multiple times the same description. 2. will add an extra empty line only when it's something to be appended 3. will work fine when the transaction already has a description with multiple lines 4. control any possible exception and returns the text to be append (if not blank), or the original description Applied jsbeautifier to ob-aprm-addTransaction.js --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/GLItemTransactionActionHandler.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js M src/org/openbravo/erpCommon/ad_callouts/SE_GLItem_Transaction.java M src/org/openbravo/erpCommon/ad_callouts/SE_Payment_Transaction.java --- |
|
(0082982) hgbot (developer) 2015-12-24 11:27 |
Repository: erp/devel/pi Changeset: 09cb07130e5b017dfa14da6056ce35ce182e522d Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Dec 24 11:03:13 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/09cb07130e5b017dfa14da6056ce35ce182e522d [^] Related to issue 31697: Avoid append a null description --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java --- |
|
(0082984) aferraz (manager) 2015-12-24 11:35 |
Code review + Testing OK |
|
(0082985) aferraz (manager) 2015-12-24 11:36 |
APRRegression30898In31385In31387In31389In & APRRegression30898Out31385Out31387Out31389Out automated tests adapted |
|
(0083001) hudsonbot (developer) 2015-12-24 18:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/13c94f3d6e25 [^] Maturity status: Test |
|
(0083002) hudsonbot (developer) 2015-12-24 18:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/13c94f3d6e25 [^] Maturity status: Test |
|
(0083003) hudsonbot (developer) 2015-12-24 18:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/13c94f3d6e25 [^] Maturity status: Test |
|
(0083832) hgbot (developer) 2016-02-02 09:43 |
Repository: tools/automation/int Changeset: f88a9e8e4e2f532263be98608707086c01e32efb Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Thu Dec 24 11:29:00 2015 +0100 URL: http://code.openbravo.com/tools/automation/int/rev/f88a9e8e4e2f532263be98608707086c01e32efb [^] Related to issue 31697: Fix APRRegression30898In31385In31387In31389In & APRRegression30898Out31385Out31387Out31389Out tests --- M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APRIn_Regressions/APRRegression30898In31385In31387In31389In.java M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APRRegression30898Out31385Out31387Out31389Out.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-12-11 12:53 | maite | New Issue | |
| 2015-12-11 12:53 | maite | Assigned To | => Triage Finance |
| 2015-12-11 12:53 | maite | Modules | => Core |
| 2015-12-11 12:53 | maite | Triggers an Emergency Pack | => No |
| 2015-12-11 12:54 | maite | Issue Monitored: networkb | |
| 2015-12-11 12:55 | maite | Relationship added | caused by 0029390 |
| 2015-12-11 13:53 | maite | Resolution time | => 1450220400 |
| 2015-12-17 10:00 | AtulOpenbravo | Assigned To | Triage Finance => AtulOpenbravo |
| 2015-12-17 10:39 | AtulOpenbravo | Status | new => scheduled |
| 2015-12-18 11:06 | AtulOpenbravo | Note Added: 0082869 | |
| 2015-12-22 20:25 | AtulOpenbravo | Note Added: 0082950 | |
| 2015-12-22 20:29 | AtulOpenbravo | Note Added: 0082951 | |
| 2015-12-24 11:27 | hgbot | Checkin | |
| 2015-12-24 11:27 | hgbot | Note Added: 0082980 | |
| 2015-12-24 11:27 | hgbot | Status | scheduled => resolved |
| 2015-12-24 11:27 | hgbot | Resolution | open => fixed |
| 2015-12-24 11:27 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/2dfae5bc1ff6557dcd68880d03c8ae8571cd827b [^] |
| 2015-12-24 11:27 | hgbot | Checkin | |
| 2015-12-24 11:27 | hgbot | Note Added: 0082981 | |
| 2015-12-24 11:27 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/2dfae5bc1ff6557dcd68880d03c8ae8571cd827b [^] => http://code.openbravo.com/erp/devel/pi/rev/ad230fc1c0f1641dec56661e756d54812ede9917 [^] |
| 2015-12-24 11:27 | hgbot | Checkin | |
| 2015-12-24 11:27 | hgbot | Note Added: 0082982 | |
| 2015-12-24 11:34 | aferraz | Assigned To | AtulOpenbravo => vmromanos |
| 2015-12-24 11:34 | aferraz | Status | resolved => new |
| 2015-12-24 11:34 | aferraz | Resolution | fixed => open |
| 2015-12-24 11:34 | aferraz | Status | new => scheduled |
| 2015-12-24 11:35 | aferraz | Status | scheduled => resolved |
| 2015-12-24 11:35 | aferraz | Fixed in Version | => 3.0PR16Q1 |
| 2015-12-24 11:35 | aferraz | Resolution | open => fixed |
| 2015-12-24 11:35 | aferraz | Review Assigned To | => aferraz |
| 2015-12-24 11:35 | aferraz | Note Added: 0082984 | |
| 2015-12-24 11:35 | aferraz | Status | resolved => closed |
| 2015-12-24 11:36 | aferraz | Note Added: 0082985 | |
| 2015-12-24 18:39 | hudsonbot | Checkin | |
| 2015-12-24 18:39 | hudsonbot | Note Added: 0083001 | |
| 2015-12-24 18:39 | hudsonbot | Checkin | |
| 2015-12-24 18:39 | hudsonbot | Note Added: 0083002 | |
| 2015-12-24 18:39 | hudsonbot | Checkin | |
| 2015-12-24 18:39 | hudsonbot | Note Added: 0083003 | |
| 2016-02-02 09:43 | hgbot | Checkin | |
| 2016-02-02 09:43 | hgbot | Note Added: 0083832 | |
| 2019-01-31 03:37 | markmm82 | Relationship added | related to 0032148 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |