Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031445
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2015-11-10 09:032015-12-14 08:46
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version3.0PR15Q4.1
StatusclosedFix in branchFixed in SCM revision4883ab9e4334
ProjectionnoneETAnoneTarget Version3.0PR15Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031445: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue

DescriptionIf a low-level error occurs when processing import entries there is a possibility that the run method ([1]) in the ImportEntryProcessRunnable is exited without deregistering.

[1] https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l274 [^]
Steps To ReproduceForce a low level exception, for example throw an exception around this line:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l375 [^]
Proposed SolutionAdd a catch (Throwable logIt) before the finally block in this location:
https://code.openbravo.com/erp/devel/pi/file/710400f71264/src/org/openbravo/service/importprocess/ImportEntryProcessor.java#l381 [^]

Also add more logging statements to log errors/exceptions. Backend threads shallow exceptions/they are not logged.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 00314103.0PR16Q1 closedmtaal Import entry process can have a stopped but not deregistered thread: tickets remain in the queue 

-  Notes
(0082505)
hgbot (developer)
2015-12-01 23:20

Repository: erp/backports/3.0PR15Q4.1
Changeset: 4883ab9e4334ff7add5f15d118431788905bf7b2
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 01 23:19:57 2015 +0100
URL: http://code.openbravo.com/erp/backports/3.0PR15Q4.1/rev/4883ab9e4334ff7add5f15d118431788905bf7b2 [^]

Fixes issue 31445: Import entry process can have a stopped but not deregistered thread: tickets remain in the queue
Adding log statements and catch block to prevent exiting loop

---
M src/org/openbravo/service/importprocess/ImportEntryManager.java
M src/org/openbravo/service/importprocess/ImportEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2015-11-12 11:14 mtaal Type defect => backport
2015-11-12 11:14 mtaal Target Version 3.0PR16Q1 => 3.0PR15Q4
2015-11-13 09:34 mtaal Target Version 3.0PR15Q4 => 3.0PR15Q4.1
2015-12-01 23:20 hgbot Checkin
2015-12-01 23:20 hgbot Note Added: 0082505
2015-12-01 23:20 hgbot Status scheduled => resolved
2015-12-01 23:20 hgbot Resolution open => fixed
2015-12-01 23:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/backports/3.0PR15Q4.1/rev/4883ab9e4334ff7add5f15d118431788905bf7b2 [^]
2015-12-01 23:21 mtaal Review Assigned To => marvintm
2015-12-14 08:46 marvintm Status resolved => closed
2015-12-14 08:46 marvintm Fixed in Version => 3.0PR15Q4.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker