Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031387
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminoralways2015-11-06 10:382015-11-23 21:17
ReportermaiteView Statuspublic 
Assigned Toaferraz 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionfcda68dddca6
ProjectionnoneETAnoneTarget Version3.0PR16Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression levelProduction - Confirmed Stable
Regression date2014-09-23
Regression introduced in release3.0PR14Q4
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
Triggers an Emergency PackNo
Summary

0031387: Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript

DescriptionBefore Match Statement refactor, if you hover over Sender field both bank statement line Business Partner Name and Description are shown
Steps To Reproduce1. Access Cuenta de Banco financial account, create new Bank Statement record
2. Add Bank Statement line seeting Business Partner Name as "name of my bp" and Description as "bsl description". Process bank statement
3. Run "Match Statement" process and hover over Sender field in your line. Realize that only "name of my bp" is shown

If you follow similar process in version prior to refactor (for example MP30.3) you can verify that both values are shown:

"name of my bp
 bsl description"
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 00314403.0PR15Q4 closedaferraz Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript 
depends on backport 00314413.0PR15Q3.4 closedaferraz Hover over Sender field in Match Statement pop-up only shows Business Partner Name instead of Business Partner Name and Descript 
caused by feature request 00293903.0PR14Q4 closedSandrahuguet Reconciliation refactor project 

-  Notes
(0081722)
aferraz (manager)
2015-11-11 17:54
edited on: 2015-11-11 18:19

 Test plan:

As F&B Admin:

- Access Cuenta de Banco financial account, create new Bank Statement record
  Add Bank Statement line seting Business Partner empty, Business Partner Name as "name of my bp" and Description as "bsl description".
  Add Bank Statement line seting Business Partner as "Alimentos y Supermercados", Business Partner Name as "name of my bp" and Description empty.
  Add Bank Statement line seting Business Partner empty, Business Partner Name empty and Description as "bsl description".
  Add Bank Statement line seting Business Partner as "Alimentos y Supermercados", Business Partner Name empty and Description empty.
  Process bank statement

- Run "Match Statement" process and show Business Partner Name and Description columns. Realize the following lines are shown:
- First line: sender = "", business partner name = "name of my bp", description = "bsl description"
- Second line: sender = "Alimentos y Supermercados", business partner name = "name of my bp", description = ""
- Third line: sender = "", business partner name = "", description = "bsl description"
- Fourth line: sender = "Alimentos y Supermercados", business partner name = "", description = ""
(0081781)
hgbot (developer)
2015-11-12 19:20

 Repository: erp/devel/pi
Changeset: fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Wed Nov 11 20:01:21 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^]

Fixes issue 31387 & Fixes issue 31389: Add two new columns in Match Statement

Added Business Partner Name and Transaction Description as new fields in Match Statement P&E window. They will not be shown in grid by default.
HQL Query in aprm_matchstatement table has been modified to retrieve this two new columns from FIN_BankStatementLine and FIN_Finacc_Transaction tables, and to retrieve bp.name as businessPartner also in case it is null.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081783)
hgbot (developer)
2015-11-12 19:20

 Repository: erp/devel/pi
Changeset: fcda68dddca6df0c946d754ec956f7635ce0fe9c
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Thu Nov 12 18:42:04 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/fcda68dddca6df0c946d754ec956f7635ce0fe9c [^]

Fixes issue 31387 & Fixes issue 31389: code review improvements

Reverted back the behavior of the Sender field. It shows the Business Partner Name (from the OB object) or the Business Partner Name string as it was doing before.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081793)
vmromanos (manager)
2015-11-12 19:27

 Code review + testing OK
(0082030)
aferraz (manager)
2015-11-20 15:12

 https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8627 [^]
(0082217)
hudsonbot (developer)
2015-11-23 21:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test
(0082219)
hudsonbot (developer)
2015-11-23 21:17

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-11-06 10:38 maite New Issue
2015-11-06 10:38 maite Assigned To => Triage Finance
2015-11-06 10:38 maite Modules => Advanced Payables and Receivables Mngmt
2015-11-06 10:38 maite Resolution time => 1449702000
2015-11-06 10:38 maite Triggers an Emergency Pack => No
2015-11-06 10:38 maite Issue Monitored: networkb
2015-11-10 13:48 aferraz Assigned To Triage Finance => aferraz
2015-11-10 13:55 aferraz Relationship added caused by 0029390
2015-11-10 13:58 aferraz Regression level => Production - Confirmed Stable
2015-11-10 13:58 aferraz Regression date => 2014-09-23
2015-11-10 13:58 aferraz Regression introduced in release => 3.0PR14Q4
2015-11-10 13:58 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/179d97ee602d [^]
2015-11-11 17:54 aferraz Note Added: 0081722
2015-11-11 17:56 aferraz Note Edited: 0081722 View Revisions
2015-11-11 18:19 aferraz Note Edited: 0081722 View Revisions
2015-11-12 10:14 aferraz Status new => scheduled
2015-11-12 19:20 hgbot Checkin
2015-11-12 19:20 hgbot Note Added: 0081781
2015-11-12 19:20 hgbot Status scheduled => resolved
2015-11-12 19:20 hgbot Resolution open => fixed
2015-11-12 19:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^]
2015-11-12 19:20 hgbot Checkin
2015-11-12 19:20 hgbot Note Added: 0081783
2015-11-12 19:20 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712bcf75d97d44bc313b0d3e6e5d6377 [^] => http://code.openbravo.com/erp/devel/pi/rev/fcda68dddca6df0c946d754ec956f7635ce0fe9c [^]
2015-11-12 19:27 vmromanos Review Assigned To => vmromanos
2015-11-12 19:27 vmromanos Note Added: 0081793
2015-11-12 19:27 vmromanos Status resolved => closed
2015-11-20 15:12 aferraz Note Added: 0082030
2015-11-23 21:17 hudsonbot Checkin
2015-11-23 21:17 hudsonbot Note Added: 0082217
2015-11-23 21:17 hudsonbot Checkin
2015-11-23 21:17 hudsonbot Note Added: 0082219

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker