Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0030535

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

backport

[Retail Modules] Quotations

major

always

2015-07-23 12:59

2015-08-12 15:31

Reporter

lorenzofidalgo

View Status

public

Assigned To

jorge-garcia

Priority

immediate

Resolution

fixed

Fixed in Version

RR15Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

RR15Q3

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

main

SCM revision

Review Assigned To

marvintm

Regression level

Packaging and release

Regression date

Regression introduced in release

main

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0030535: [RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed

Description

To create a Sales Order from quotation if "Firm quotation" is unchecked and some prices has been changed induces errors in the final total amount. This error also reaches POS backend data.
This situation is generated if the product selected in the quotation appears in some discount record. It is not necessary that the discount is being applied in this certain receipt.

Steps To Reproduce

0-Login POS backend and go to "Discounts and promotions" window. Create a new record in that window with the following data:
--
Organization: The White Valley Group
Discount/Promotion Type: Buy X pay Y of same product
Name: Quotation+Discounts error
Printed Name: Quotation+Discounts error
Active: Checked
Starting date: 01-01-2012
Included Products: Only those defined
Included Organizations: Only those defined
X Units: 3
Y Units: 2

In Products tab, add the following record: Camera bag
In Organization tab, add the following record: Vall Blanca Store
--
Save the record.
1- Login POS in VBS terminal and login with vallblanca//openbravo.
2- In dropdown menu, click Create Quotation option.
3- Then click SEARCH option, search camera bag and add 2x "Camera bag".
4- Click the product line and change its price to 1€ each product.
5- Then tap "total amount" button to get that quotation to be under evaluation.
6- In dropdown menu click "Create Sales Order", "Firm quotation" must be UNCHECKED. Then click "Create Sales Order" button in the popup.
7- Defect: Realize Total Amount is wrong.

Tags

No tags attached.

30535.diff [^] (643 bytes) 2015-08-10 14:42 [Show Content] [Hide Content]

diff -r 9103ea8f5f73 -r bd4f337f5e93 web/org.openbravo.retail.posterminal/js/model/order.js
--- a/web/org.openbravo.retail.posterminal/js/model/order.js	Mon Aug 03 09:48:18 2015 +0200
+++ b/web/org.openbravo.retail.posterminal/js/model/order.js	Mon Aug 03 14:29:13 2015 +0200
@@ -1496,7 +1496,6 @@
         this.updatePrices(function (order) {
           OB.Model.Discounts.applyPromotions(order);
           OB.UTIL.showSuccess(OB.I18N.getLabel('OBPOS_QuotationCreatedOrder'));
-          order.trigger('orderCreatedFromQuotation');
         });
       } else {
         OB.UTIL.showSuccess(OB.I18N.getLabel('OBPOS_QuotationCreatedOrder'));

Relationships [ Relation Graph ] [ Dependency Graph ]

depends on	defect	0030564		closed	jorge-garcia	[RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed
blocks	defect	0030412		closed	marvintm	[RR15Q3] Creating a sales order from quotation with "Firm quotation" unchecked creates wrong total amounts if price has changed

Notes
(0079296) hgbot (developer) 2015-08-11 08:45	Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal Changeset: c4fd068a6e7779d494d794388cc4f7d7b34b25a3 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Aug 11 08:43:28 2015 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/c4fd068a6e7779d494d794388cc4f7d7b34b25a3 [^] Fixed issue 30535: Creating a sales order from quotation with "Firm quotation" Backport for the issue 30412 --- M web/org.openbravo.retail.posterminal/js/model/order.js ---

(0079323) marvintm (manager) 2015-08-12 14:57	The fix is not correct. It needs to be reviewed, and repaired.

(0079326) marvintm (manager) 2015-08-12 15:30	Finally the fix is correct, so it can be closed. No further change is needed.

Issue History
Date Modified	Username	Field	Change
2015-08-10 13:44	jorge-garcia	Type	defect => backport
2015-08-10 13:44	jorge-garcia	Target Version	=> RR15Q3
2015-08-10 14:42	jorge-garcia	File Added: 30535.diff
2015-08-11 08:45	hgbot	Checkin
2015-08-11 08:45	hgbot	Note Added: 0079296
2015-08-11 08:45	hgbot	Status	scheduled => resolved
2015-08-11 08:45	hgbot	Resolution	open => fixed
2015-08-11 08:45	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/c4fd068a6e7779d494d794388cc4f7d7b34b25a3 [^]
2015-08-12 14:57	marvintm	Note Added: 0079323
2015-08-12 14:57	marvintm	Status	resolved => new
2015-08-12 14:57	marvintm	Resolution	fixed => open
2015-08-12 15:30	marvintm	Note Added: 0079326
2015-08-12 15:30	marvintm	Status	new => scheduled
2015-08-12 15:30	marvintm	Status	scheduled => resolved
2015-08-12 15:30	marvintm	Resolution	open => fixed
2015-08-12 15:31	marvintm	Review Assigned To	=> marvintm
2015-08-12 15:31	marvintm	Status	resolved => closed
2015-08-12 15:31	marvintm	Fixed in Version	=> RR15Q3
2015-09-24 10:21	Orekaria	Relationship added	causes 0030909
2015-09-24 10:22	Orekaria	Relationship deleted	causes 0030909

Copyright © 2000 - 2009 MantisBT Group