Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030526 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 04. Warehouse management | major | have not tried | 2015-08-07 17:12 | 2015-08-20 23:16 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | aferraz | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | a69810747c37 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | dmiguelez | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030526: potential unneeded storage detail updates on changes for movement lines | |||||||
| Description | m_movementline_trg is invoking M_UPDATE_INVENTORY whenever there is an update/insert or delete. In the case of Update: * it is invoked not taking into consideration which are the fields that are being modified * it can be invoked up to 4 times | |||||||
| Steps To Reproduce | Seen in a customer instance with big volumes and high concurrency using picking module, logs show many times this query: update M_MovementLine set Updated=$1, EM_OBWPL_Itemstatus=$2, EM_OBWPL_Pickedqty=$3 where M_MovementLine_ID=$4 it is usually fast but sometimes becomes slow because it needs to update M_STORAGE_DETAIL which can be locked. Would it be necessary at all to call M_UPDATE_INVENTORY in this case? | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0079346) hgbot (developer) 2015-08-13 13:08 |
Repository: erp/devel/pi Changeset: a69810747c37badc969046af93888d208f028e5f Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Tue Aug 11 10:56:53 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/a69810747c37badc969046af93888d208f028e5f [^] Fixes issue 30526: Unneeded storage detail updates on changes for MovementLines Some checks have been added to M_MOVEMENTLINE_TRG trigger to update M_Storage_Detail only when it is necesary. --- M src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml --- |
|
(0079347) hgbot (developer) 2015-08-13 13:09 |
Repository: erp/devel/pi Changeset: 86f2c21db4894c6745447b6d15d59067c8eb9dd5 Author: David Miguelez <david.miguelez <at> openbravo.com> Date: Thu Aug 13 13:07:02 2015 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/86f2c21db4894c6745447b6d15d59067c8eb9dd5 [^] Related to Issue 30526: Code Review Changes. Modifes ELSEIF sentence to make sure the trigger will be fired for both locator_ID's if both are changed. --- M src-db/database/model/triggers/M_MOVEMENTLINE_TRG.xml --- |
|
(0079348) dmiguelez (developer) 2015-08-13 13:09 |
Code Review + Testing Ok |
|
(0079548) hudsonbot (developer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
|
(0079549) hudsonbot (developer) 2015-08-20 23:16 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/8c91718397a5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-08-07 17:12 | alostale | New Issue | |
| 2015-08-07 17:12 | alostale | Assigned To | => Triage Finance |
| 2015-08-07 17:12 | alostale | Modules | => Core |
| 2015-08-07 17:12 | alostale | Triggers an Emergency Pack | => No |
| 2015-08-07 17:19 | alostale | Tag Attached: Performance | |
| 2015-08-07 17:21 | alostale | Steps to Reproduce Updated | View Revisions |
| 2015-08-10 11:58 | alostale | Issue Monitored: alostale | |
| 2015-08-10 14:27 | aferraz | Assigned To | Triage Finance => aferraz |
| 2015-08-13 13:08 | hgbot | Checkin | |
| 2015-08-13 13:08 | hgbot | Note Added: 0079346 | |
| 2015-08-13 13:08 | hgbot | Status | new => resolved |
| 2015-08-13 13:08 | hgbot | Resolution | open => fixed |
| 2015-08-13 13:08 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/a69810747c37badc969046af93888d208f028e5f [^] |
| 2015-08-13 13:09 | hgbot | Checkin | |
| 2015-08-13 13:09 | hgbot | Note Added: 0079347 | |
| 2015-08-13 13:09 | dmiguelez | Review Assigned To | => dmiguelez |
| 2015-08-13 13:09 | dmiguelez | Note Added: 0079348 | |
| 2015-08-13 13:09 | dmiguelez | Status | resolved => closed |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079548 | |
| 2015-08-20 23:16 | hudsonbot | Checkin | |
| 2015-08-20 23:16 | hudsonbot | Note Added: 0079549 | |
| 2015-09-16 11:44 | egoitz | Relationship added | related to 0030832 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |