Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030338
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-07-10 12:492015-07-20 08:12
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR15Q4
StatusclosedFix in branchFixed in SCM revisionf1de6735fa9f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030338: New postgresql 9.5alpha1 has remove pg_authid.rolcatupdate column changed in openbravo install.source

DescriptionOpenbravo postgres database user creation done during install.source in src-db/database/build-create.xml has the following extra sql after creating the user (as db superuser)

UPDATE pg_authid SET rolcatupdate=true WHERE rolname='${bbdd.user}';

That column is to give that user extra permission going being normal superuser.

It was used a long time ago by core code to disable triggers+fk's without deleting them.

But no known user is known.

Postgres 9.5 now deleted this column as its usefulness was unclear

http://www.postgresql.org/docs/devel/static/release-9-5.html [^]
Remove pg_authid's rolcatupdate field, as it had no value (Adam Brightwell)

However it should be fine to just delete the custom sql from build-create.xml for 2 reasons:
1.) It was not doing anything useful already before as the defaultvalue for rolcatupdate was true already if user is a superuser for all pg versions supported by openbravo
2.) Now normal superuser privs are sufficient to do the same action in case some code should still rely on that.


To check this reason1 a 'create user test superuser' + select * from pg_authid i.e. on pg9.1 can be done to verify that default true value.
Steps To ReproduceRun install.source with postgresql 9.5alpha1

      [sql] Failed to execute: UPDATE pg_authid SET rolcatupdate=true WHERE rolname='try_full_pgsql'
      [sql] org.postgresql.util.PSQLException: ERROR: column "rolcatupdate" of relation "pg_authid" does not exist
Proposed SolutionRemove the extra SQL modifying that now deleted column.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0078775)
hgbot (developer)
2015-07-13 13:55
edited on: 2015-07-16 12:03

 Repository: erp/devel/pi
Changeset: f1de6735fa9f
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Jul 10 12:53:42 2015 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1de6735fa9f [^]

Fixed 30338: Remove not needed pg_authid.rolcatupdate sql to fix pg9.5

Postgresql 9.5 did remove the pg_authid.rolcatupdate column which is
explicitely set during db user creation by openbravo.
As that change is not needed anyway just delete the sql. It is not needed
as value for that boolean defaults to true for db superuser's anyway.

---
M src-db/database/build-create.xml
---
(0078946)
alostale (viewer)
2015-07-20 08:12

 Code reviewed.

Tested:
-Pg 9.5: no error message is shown in create.database
-Pg 9.3: works fine, not found anywhere this setting was needed

- Issue History
Date Modified Username Field Change
2015-07-10 12:49 shuehner New Issue
2015-07-10 12:49 shuehner Assigned To => platform
2015-07-10 12:49 shuehner OBNetwork customer => No
2015-07-10 12:49 shuehner Modules => Core
2015-07-10 12:49 shuehner Triggers an Emergency Pack => No
2015-07-10 12:49 shuehner Assigned To platform => shuehner
2015-07-13 13:55 hgbot Checkin
2015-07-13 13:55 hgbot Note Added: 0078775
2015-07-13 13:55 hgbot Status new => resolved
2015-07-13 13:55 hgbot Resolution open => fixed
2015-07-13 13:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b7bb9b8e82c4430bf99e32c4e1bf2ad9784524a2 [^]
2015-07-13 14:09 shuehner Review Assigned To => alostale
2015-07-16 12:03 gorka_gil Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/b7bb9b8e82c4430bf99e32c4e1bf2ad9784524a2 [^] => http://code.openbravo.com/erp/devel/pi/rev/f1de6735fa9f [^]
2015-07-16 12:03 gorka_gil Note Edited: 0078775 View Revisions
2015-07-20 08:12 alostale Note Added: 0078946
2015-07-20 08:12 alostale Status resolved => closed
2015-07-20 08:12 alostale Fixed in Version => 3.0PR15Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker