Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0030078
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2015-06-02 16:502015-06-24 17:47
ReporteradrianromeroView Statuspublic 
Assigned Toguillermogil 
PriorityurgentResolutionfixedFixed in VersionRR15Q3
StatusclosedFix in branchFixed in SCM revision6fdb69911e26
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression levelProduction - QA Approved
Regression date2015-02-18
Regression introduced in releaseRR15Q2
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/992add0c4ec3 [^]
Triggers an Emergency PackNo
Summary

0030078: Payment methods without financial account configured do not appear in Web POS

DescriptionPayment methods without financial account configured do not appear in Web POS because the HQL sentence that retrieves payment information, relies in an existing financial account. This is wrong because financial account is not mandatory
Steps To ReproduceCreate and configure a payment method for a POS terminal with no financial account configured. Go to Web pos and verify that this payment method does not appear when trying to pay an order
Proposed SolutionIn Payment.java use the follwing HQL sentence:

      String hqlPayments = "select "
          + "p as payment, "
          + "p.paymentMethod as paymentMethod, " //
          + "c_currency_rate(coalesce(c, p.paymentMethod.currency), p.obposApplications.organization.currency, null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as rate, "
          + "c_currency_rate(p.obposApplications.organization.currency, coalesce(c, p.paymentMethod.currency), null, null, p.obposApplications.client.id, p.obposApplications.organization.id) as mulrate, "
          + "coalesce(c.iSOCode, p.paymentMethod.currency.iSOCode) as isocode, " //
          + "coalesce(c.symbol, p.paymentMethod.currency.symbol) as symbol, " //
          + "coalesce(c.currencySymbolAtTheRight, p.paymentMethod.currency.currencySymbolAtTheRight) as currencySymbolAtTheRight, " //
          + "coalesce(f.currentBalance, 0) as currentBalance, " //
          + "c.obposPosprecision as obposPosprecision, " //
          + "img.bindaryData as image, " //
          + "img.mimetype as mimetype " //
          + "from OBPOS_App_Payment as p " //
          + "left outer join p.paymentMethod as pm " //
          + "left outer join pm.image as img " //
          + "left outer join p.financialAccount as f " // If financial Account is null currency
                                                       // values default to organization currency
                                                       // values.
          + "left outer join f.currency as c " //
          + "where p.obposApplications.id=? " //
          + "and p.$readableSimpleCriteria and p.$activeCriteria order by p.line, p.commercialName";

TagsApproved
Attached Files? file icon 30078.export [^] (3,212 bytes) 2015-06-08 17:40

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0030079RR15Q2.2 closedRetail Payment methods without financial account configured do not appear in Web POS 

-  Notes
(0078147)
guillermogil (manager)
2015-06-08 17:40

You can find a proposed solution attached
(0078277)
hgbot (developer)
2015-06-15 09:31

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6fdb69911e265b491e93fb33b1bca004207e83ad
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Mon Jun 08 17:38:33 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6fdb69911e265b491e93fb33b1bca004207e83ad [^]

Fixed issue 30078:Payment methods without fin acc are not showing

hqlPayments query is now looking for null values

---
M src/org/openbravo/retail/posterminal/term/Payments.java
---
(0078493)
migueldejuana (developer)
2015-06-24 17:47

Tested and reviewed in 2d80f8cf8501

- Issue History
Date Modified Username Field Change
2015-06-02 16:50 adrianromero New Issue
2015-06-02 16:50 adrianromero Assigned To => Retail
2015-06-02 16:50 adrianromero Regression level => Production - QA Approved
2015-06-02 16:50 adrianromero Regression date => 2015-02-18
2015-06-02 16:50 adrianromero Regression introduced in release => RR15Q2
2015-06-02 16:50 adrianromero Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/992add0c4ec3 [^]
2015-06-02 16:50 adrianromero Triggers an Emergency Pack => No
2015-06-02 18:34 marvintm Status new => scheduled
2015-06-02 21:21 dmitry_mezentsev Tag Attached: Approved
2015-06-08 17:38 guillermogil Assigned To Retail => guillermogil
2015-06-08 17:40 guillermogil File Added: 30078.export
2015-06-08 17:40 guillermogil Note Added: 0078147
2015-06-15 09:31 hgbot Checkin
2015-06-15 09:31 hgbot Note Added: 0078277
2015-06-15 09:31 hgbot Status scheduled => resolved
2015-06-15 09:31 hgbot Resolution open => fixed
2015-06-15 09:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6fdb69911e265b491e93fb33b1bca004207e83ad [^]
2015-06-23 09:02 guillermogil Review Assigned To => marvintm
2015-06-24 17:47 migueldejuana Review Assigned To marvintm => migueldejuana
2015-06-24 17:47 migueldejuana Note Added: 0078493
2015-06-24 17:47 migueldejuana Status resolved => closed
2015-06-24 17:47 migueldejuana Fixed in Version => RR15Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker