Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029107
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Retail Modules] Discounts and Promotionsminoralways2015-03-03 10:242015-05-13 18:16
ReporterasiermartirenaView Statuspublic 
Assigned Toasiermartirena 
PrioritynormalResolutionfixedFixed in VersionRR15Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029107: Show discount percent in manual discounts lines (Web POS)

DescriptionWhen selecting a manual discount, user needs to include the discount percentage. This percentage is not shown in lines.
This issue is to add the percent number plus "%" icon next to the discount line, in order to be clearer when using this type of discounts.
Steps To ReproduceAdd a manual discount, select the percent which is going to be applied and check that the disctount percent value is not shown.
Proposed SolutionPatch added to solve this problem.
TagsNo tags attached.
Attached Filesdiff file icon discountsPatch2.diff [^] (2,041 bytes) 2015-03-23 13:08 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks feature request 0029465RR16Q1 closedRetail QA: RR15Q3: Add tests for Mobile applications 

-  Notes
(0077021)
hgbot (developer)
2015-05-05 16:25

Repository: tools/automation/pi-mobile
Changeset: 9e902ab48757766441a3f873e7cb8ad0751ca2a1
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Tue May 05 14:33:16 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9e902ab48757766441a3f873e7cb8ad0751ca2a1 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Discount name has been modified
Now it shows the manual percent append to the discount name

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28100_DiscountsNotAppliedToReturnLinesII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/ReceiptDiscount.java
---
(0077033)
hgbot (developer)
2015-05-06 08:20

Repository: tools/automation/pi-mobile
Changeset: 21579d20524551778b97b243d646452d20ba6243
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Wed May 06 08:18:45 2015 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/21579d20524551778b97b243d646452d20ba6243 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Modified wrong discount label

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentI.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/discountsandpromotions/I28164_DiscountsRemovedWhenReturnPresentII.java
---
(0077238)
asiermartirena (developer)
2015-05-08 13:57

This issue is solved by the following commit:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/d946053a006e [^]
(0077353)
marvintm (manager)
2015-05-12 18:50

The standard getIdentifier logic is duplicated in three rules which basically work like the standard case. They need to be removed, only the percentage one should have a getIdentifier definition.
(0077358)
hgbot (developer)
2015-05-12 20:23

Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: e4ef881a7483170662d9520b2d7c14b9b7106a52
Author: Guillermo Gil <guillermo.gil <at> openbravo.com>
Date: Tue May 12 20:22:40 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/e4ef881a7483170662d9520b2d7c14b9b7106a52 [^]

Related to issue 29107:Show discount percent in manual discounts lines

Removed not needed functions due to duplicate code

---
M web/org.openbravo.retail.discounts/js/promotion-manual.js
---

- Issue History
Date Modified Username Field Change
2015-03-03 10:24 asiermartirena New Issue
2015-03-03 10:24 asiermartirena Assigned To => marvintm
2015-03-03 10:24 asiermartirena File Added: posterminalPatch.diff
2015-03-03 10:24 asiermartirena Triggers an Emergency Pack => No
2015-03-03 10:26 asiermartirena File Added: discountsPatch.diff
2015-03-04 11:34 Orekaria Relationship added blocks 0028933
2015-03-23 13:08 asiermartirena File Added: discountsPatch2.diff
2015-03-23 13:09 asiermartirena File Added: posterminalDiscountsPatch.diff
2015-03-23 13:10 asiermartirena File Deleted: discountsPatch.diff
2015-03-23 13:10 asiermartirena File Deleted: posterminalPatch.diff
2015-03-30 18:54 Orekaria Relationship added blocks 0029465
2015-03-30 18:54 Orekaria Relationship deleted blocks 0028933
2015-04-22 10:14 asiermartirena File Deleted: posterminalDiscountsPatch.diff
2015-04-22 11:06 asiermartirena Review Assigned To => marvintm
2015-05-05 16:25 hgbot Checkin
2015-05-05 16:25 hgbot Note Added: 0077021
2015-05-06 08:20 hgbot Checkin
2015-05-06 08:20 hgbot Note Added: 0077033
2015-05-08 13:57 asiermartirena Status new => scheduled
2015-05-08 13:57 asiermartirena Note Added: 0077238
2015-05-08 14:01 asiermartirena Status scheduled => resolved
2015-05-08 14:01 asiermartirena Resolution open => fixed
2015-05-12 18:50 marvintm Note Added: 0077353
2015-05-12 20:21 guillermogil Issue Monitored: marvintm
2015-05-12 20:23 hgbot Checkin
2015-05-12 20:23 hgbot Note Added: 0077358
2015-05-13 18:16 marvintm Assigned To marvintm => asiermartirena
2015-05-13 18:16 marvintm Status resolved => closed
2015-05-13 18:16 marvintm Fixed in Version => RR15Q3


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker