Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028593
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] AEAT 349minoralways2015-01-13 17:092015-03-03 14:12
ReportermaiteView Statuspublic 
Assigned Tovmromanos 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision139829d2b375
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0028593: getBusinessPartnerInfo method should firstly consider locations defined as "tax locations"

DescriptiongetBusinessPartnerInfo method should firstly consider locations defined as "tax locations"
Steps To Reproduce1. Define following locations for same Business Partner:
  - Location1 as "tax location"= yes and "ship location"= yes
  - Location2 as "tax location"= no and "ship location"= no
2. Run 349 report and realize that Location2 is considered when locations defined as "tax location" should be considered
Proposed SolutionAdd code similar to 340 code in "getBusinessPartnerInfo" method of "AEAT3492010ReportDao" java:

for (Location loc : bp.getBusinessPartnerLocationList()) {
        if (loc.isTaxLocation())
          return loc.getLocationAddress();
      }
      return bp.getBusinessPartnerLocationList().get(0).getLocationAddress();
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0075042)
vmromanos (manager)
2015-02-27 14:14

Test plan:
1. Create a business partner (customer). Create 3 bp locations: Spain, Greece, France. Select only Greece as Tax Location = Y
2. Create a Sales Invoice for this bp.
Enter any product and select tax rate = Entregas intracomunitarias (%N=>0%)
3. Process and post the invoice
4. Launch the 349 report and verify the NOI code for this bp is "EL", which corresponds to Greece
(0075043)
hgbot (developer)
2015-02-27 14:19

Repository: erp/pmods/org.openbravo.module.aeat349.es
Changeset: 139829d2b3752ab5a526a605562363e4a9490e82
Author: Víctor Martínez Romanos <victor.martinez <at> openbravo.com>
Date: Fri Feb 27 14:16:19 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/139829d2b3752ab5a526a605562363e4a9490e82 [^]

Fixes issue 28593: Get Tax Location as Business Partner location when defined

If a BP has a Tax location defined, we use it as the default bp location. If no location is defined as tax location we apply the same criteria used before

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/module/aeat349/es/AEAT3492010ReportDao.java
M src/org/openbravo/module/aeat349/es/AEAT349ReportDao.java
---
(0075118)
psanjuan (manager)
2015-03-03 14:12

Verified.

Location taken is the one set as Tax Location.

- Issue History
Date Modified Username Field Change
2015-01-13 17:09 maite New Issue
2015-01-13 17:09 maite Assigned To => jonalegriaesarte
2015-01-13 17:09 maite Assigned To jonalegriaesarte => vmromanos
2015-01-13 17:10 maite Resolution time => 1427238000
2015-01-13 17:10 maite Issue Monitored: networkb
2015-02-26 17:53 vmromanos Status new => scheduled
2015-02-26 17:53 vmromanos fix_in_branch => pi
2015-02-27 14:14 vmromanos Note Added: 0075042
2015-02-27 14:19 hgbot Checkin
2015-02-27 14:19 hgbot Note Added: 0075043
2015-02-27 14:19 hgbot Status scheduled => resolved
2015-02-27 14:19 hgbot Resolution open => fixed
2015-02-27 14:19 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.module.aeat349.es/rev/139829d2b3752ab5a526a605562363e4a9490e82 [^]
2015-03-03 14:12 psanjuan Note Added: 0075118
2015-03-03 14:12 psanjuan Status resolved => closed
2015-03-03 14:12 psanjuan fix_in_branch pi =>


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker