Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028250
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-11-21 16:162015-03-20 13:06
ReporteradrianromeroView Statuspublic 
Assigned Toadrianromero 
PriorityurgentResolutionfixedFixed in VersionRR15Q1
StatusclosedFix in branchpiFixed in SCM revisiond536de1438c1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028250: During the process of closing a receipt UI remains responsive allowing to execute actions

DescriptionIf the process to close a receipt in Web POS takes few seconds because printer is not available or there are hooks that execute asynchronous actions, the done button is disabled but other buttons in the application remains active. Then the cashier can execute other actions before actually closing the receipt and wrong data can be created or the Web POS can be in an inconsistent state.
Steps To ReproduceJust close a receipt and try to execute other actions while the "Done" button is inactive
Proposed SolutionShow the "Loading" window that blocks all UI actions while the close receipt process is in execution
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0028312 closedmarvintm "Loading" window is hidden before than the receipt has been send to the backend 
blocks feature request 0029377RR15Q3 closedOrekaria Stabilization: RR15Q2 related 
causes defect 0029034 closedOrekaria The loading window is being shown when the ticket is closed 

-  Notes
(0071897)
hgbot (developer)
2014-11-21 16:20

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d536de1438c197bbcf90e8c8902b5fd2a9153a17
Author: Adrián Romero <adrianromero <at> openbravo.com>
Date: Fri Nov 21 16:20:09 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d536de1438c197bbcf90e8c8902b5fd2a9153a17 [^]

Fixes issue 0028250: During the process of closing a receipt UI remains responsive allowing to execute actions
Showing the *loading* window while the closing receipt is executing

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0072177)
adrianromero (manager)
2014-12-01 10:52

 Not properly fixed. Loading window disappears when showing an error, for example when hardware manager is not configured. It needs to be fixed.
(0072216)
malsasua (developer)
2014-12-01 18:33

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4583a01d6acb310e81f30a6e25e3b2f29f9eb2ef
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Mon Dec 01 18:28:35 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4583a01d6acb310e81f30a6e25e3b2f29f9eb2ef [^] [^]

fixed issue 28312: the called to deleteCurrent function now is executed without wait to the callback to print

when the even 'print' is triggered, the called to deleteCurrent is executed immediatly, no is executed in the callback
To support it, the function 'print' use the parameter 'order', before it used the main receipt

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-print.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0072365)
adrianromero (manager)
2014-12-09 17:05

 Verified.
(0074820)
hgbot (developer)
2015-02-23 19:20

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3619f5ca8495f0ec7f54969cb6fa24a994092c96
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Mon Feb 23 18:46:40 2015 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3619f5ca8495f0ec7f54969cb6fa24a994092c96 [^]

Fixes issue 29034, Backed out changeset: d536de1438c1 of issue 28250: Loading window is shown when the receipt is closed

The problem was that the fix found for the causing issue was trying to fix receipt inconsistences when the user was trying to create a new order just after having finished a previous one and 2 changesets were introduced
The first changeset tried a work around (blocking the UI), but the second one tried to fix the real issue

Note: If the issue tried to fix in the causing issue referred by this issue arises again, a proper fix has to be found. Blocking the UI is not an option

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0075797)
hgbot (developer)
2015-03-20 13:06

 Repository: retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal
Changeset: 39cb0e5c68e19de0f06c1149a048a0d83ea5c9e6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Mar 20 13:06:36 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q1.2/org.openbravo.retail.posterminal/rev/39cb0e5c68e19de0f06c1149a048a0d83ea5c9e6 [^]

Fixes issue 29034, Backed out changeset: d536de1438c1 of issue 28250: Loading window is shown when the receipt is closed

The problem was that the fix found for the causing issue was trying to fix receipt inconsistences when the user was trying to create a new order just after having finished a previous one and 2 changesets were introduced
The first changeset tried a work around (blocking the UI), but the second one tried to fix the real issue

Note: If the issue tried to fix in the causing issue referred by this issue arises again, a proper fix has to be found. Blocking the UI is not an option

Note: Backport to RR15Q1.2

---
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---

- Issue History
Date Modified Username Field Change
2014-11-21 16:16 adrianromero New Issue
2014-11-21 16:16 adrianromero Assigned To => adrianromero
2014-11-21 16:16 adrianromero Triggers an Emergency Pack => No
2014-11-21 16:16 adrianromero Review Assigned To => malsasua
2014-11-21 16:20 hgbot Checkin
2014-11-21 16:20 hgbot Note Added: 0071897
2014-11-21 16:20 hgbot Status new => resolved
2014-11-21 16:20 hgbot Resolution open => fixed
2014-11-21 16:20 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d536de1438c197bbcf90e8c8902b5fd2a9153a17 [^]
2014-12-01 10:52 adrianromero Note Added: 0072177
2014-12-01 10:52 adrianromero Status resolved => new
2014-12-01 10:52 adrianromero Resolution fixed => open
2014-12-01 10:54 malsasua Relationship added related to 0028312
2014-12-01 10:55 malsasua Relationship deleted related to 0028312
2014-12-01 10:55 malsasua Relationship added has duplicate 0028312
2014-12-01 18:32 malsasua Status new => scheduled
2014-12-01 18:32 malsasua fix_in_branch => pi
2014-12-01 18:33 malsasua Note Added: 0072216
2014-12-01 18:33 malsasua Status scheduled => resolved
2014-12-01 18:33 malsasua Fixed in Version => RR15Q1
2014-12-01 18:33 malsasua Resolution open => fixed
2014-12-09 17:05 adrianromero Review Assigned To malsasua => adrianromero
2014-12-09 17:05 adrianromero Note Added: 0072365
2014-12-09 17:05 adrianromero Status resolved => closed
2015-02-23 19:20 hgbot Checkin
2015-02-23 19:20 hgbot Note Added: 0074820
2015-02-26 20:19 dmitry_mezentsev Relationship added causes 0029034
2015-03-20 13:06 hgbot Checkin
2015-03-20 13:06 hgbot Note Added: 0075797
2015-03-23 18:07 Orekaria Relationship added blocks 0029377

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker