Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028164
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajorhave not tried2014-11-12 18:332014-11-14 10:44
ReportermalsasuaView Statuspublic 
Assigned Tomigueldejuana 
PriorityurgentResolutionfixedFixed in VersionRR14Q3.1
StatusclosedFix in branchFixed in SCM revision2930de98c063
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned ToOrekaria
Regression levelProduction - QA Approved
Regression date2014-06-10
Regression introduced in releaseRR14Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/ff64aefab4b0 [^]
Triggers an Emergency PackNo
Summary

0028164: discount is removed when exists other line negative

Descriptionwhen there are lines negatives in receipt, and one positive line has got a discretionary discount and also automatic discount, the automatic discount is removed in positive line, and it should not be removed
Steps To Reproduce. in F&B
. add Avalanche Receiver
  . qty 1
. add GPS handheld (automatic discount: "GPS_10_per" is added)
  . qty 1
. apply discretionary discount disc_5_var_perc to all lines
the receipt:
   . Avalance Receiver: qty 1
     - discounts: disc_5_var_perc
   . GPS handheld: qty 1
     - discounts: disc_5_var_perc
                   GPS_10_per

. return line Avalance Receiver
expected receipt:
   . Avalance Receiver: qty -1
   . GPS handheld: qty 1
     - discounts: disc_5_var_perc
                   GPS_10_per
receipt:
   . Avalance Receiver: qty -1
   . GPS handheld: qty 1
     - discounts: disc_5_var_perc

the discount GPS_10_per has been removed, and it should not be removed
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0028120RR14Q3.1 closedmalsasua Discounts related to packs are not properly related to order lines when sharing products 
related to defect 0028100 closedOrekaria [RR14Q4] Discretionary discounts not applied in Return receipts 

-  Notes
(0071647)
hgbot (developer)
2014-11-14 09:01

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 2930de98c0637d8202a10d368cc72686b45ccd54
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Fri Nov 14 09:00:30 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2930de98c0637d8202a10d368cc72686b45ccd54 [^]

Fixed issue 0028164: discount is removed when exists other line negative

Order lines by qty desc before applying discount rules in order to have first higher qty and positive lines.

---
M web/org.openbravo.retail.posterminal/js/model/discounts.js
---
(0071650)
hgbot (developer)
2014-11-14 10:43

 Repository: tools/automation/pi-mobile
Changeset: ee610ff136be31caff6a95361a682c11c1a9176f
Author: Rafa Alonso <rafael.alonso <at> openbravo.com>
Date: Fri Nov 14 10:43:18 2014 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ee610ff136be31caff6a95361a682c11c1a9176f [^]

Related to issue 28164: 2 tests have been added

These tests verify that the discounts are correctly applied and that a receipt with a return in the first or the second line, will give the same results

---
M src-test/org/openbravo/retail/standard/automation/suites/DiscountsAndPromotionsSuite.java
A src-test/org/openbravo/retail/standard/automation/level20/discountsandpromotions/issues/I28164_DiscountsRemovedWhenReturnPresentI.java
A src-test/org/openbravo/retail/standard/automation/level20/discountsandpromotions/issues/I28164_DiscountsRemovedWhenReturnPresentII.java
---

- Issue History
Date Modified Username Field Change
2014-11-12 18:33 malsasua New Issue
2014-11-12 18:33 malsasua Assigned To => marvintm
2014-11-12 18:33 malsasua Regression level => Production - QA Approved
2014-11-12 18:33 malsasua Regression date => 2014-06-10
2014-11-12 18:33 malsasua Regression introduced in release => RR14Q3
2014-11-12 18:33 malsasua Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/ff64aefab4b0 [^]
2014-11-12 18:33 malsasua Triggers an Emergency Pack => No
2014-11-14 08:56 migueldejuana Assigned To marvintm => migueldejuana
2014-11-14 08:59 Orekaria Relationship added depends on 0028120
2014-11-14 09:01 hgbot Checkin
2014-11-14 09:01 hgbot Note Added: 0071647
2014-11-14 09:01 hgbot Status new => resolved
2014-11-14 09:01 hgbot Resolution open => fixed
2014-11-14 09:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/2930de98c0637d8202a10d368cc72686b45ccd54 [^]
2014-11-14 09:11 Orekaria Relationship added related to 0028100
2014-11-14 10:43 hgbot Checkin
2014-11-14 10:43 hgbot Note Added: 0071650
2014-11-14 10:44 Orekaria Review Assigned To => Orekaria
2014-11-14 10:44 Orekaria Status resolved => closed
2014-11-14 10:44 Orekaria Fixed in Version => RR14Q3.1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker