Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027826
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POScriticalhave not tried2014-10-10 10:292014-12-05 16:28
ReportermtaalView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision
ProjectionnoneETAnoneTarget VersionRR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027826: When browser cache is cleared, new cashup id is created, link non-reconciled tickets to this new cashupid

DescriptionWhen the browser cache is cleared the cashup information in the client is also cleared. This includes the current cashup id.

There can already be tickets stored on the server with a cashup id which is not valid anymore. These are so-called 'orphaned' tickets.

The next valid cashup should find these orphaned tickets and link them to the latest valid cashup.

A special case is that multiple tickets and multiple cashups are created offline. Then when syncing first the tickets are synced and then the cashups. In this case the first cashup will see all the tickets and could assume part of them are orphaned while they in fact belong to a cashup which is synced next.
The system should take this into account and detect orphaned tickets taking into account all cashup ids of one sync (multiple offline cashups are synced in one webservice request).

See also the attached skype chat between Antonio and Martin
Steps To Reproduce- login into WebPOS
- create tickets without doing cashup
- clear the browser cache and remove local db
- login into WebPOS
- create new ticket
- do cashup

See that the previous tickets are not invoiced or reconciled.
Proposed Solution
When doing cash close detect which orders are orphaned and update their cashup id to the first/upcoming cashup which is being done in the cashup.

There should be a patch created for as well Q2.4 and Q3.1

The decision to really include it in Q2.4 or Q3.1 is done later.
TagsNo tags attached.
Attached Filestxt file icon skype_chat_antonio_martin.txt [^] (9,864 bytes) 2014-10-10 10:29 [Show Content]
diff file icon issue27826.diff [^] (3,814 bytes) 2014-11-10 10:39 [Show Content]
diff file icon issue27826_forQ2.diff [^] (3,745 bytes) 2014-11-10 15:36 [Show Content]
diff file icon issue27826_forQ2_2.diff [^] (1,106 bytes) 2014-11-12 22:44 [Show Content]
diff file icon issue27826_forQ2_finaldiff.diff [^] (4,826 bytes) 2014-12-05 16:28 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0028008 closedmarvintm Cash up does not create the reconciliation 

-  Notes
(0071618)
mtaal (manager)
2014-11-12 22:50

The fix process is included in this module:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.fixcashupdata [^]

The additional changeset (issue27826_forQ2_2.diff) is needed because the ordergrouping processor in the Q2 version disables the triggers while this is also done in the fix process.

The additional changeset moves the trigger disabling to the ProcessCashClose where it belongs.
(0071689)
hgbot (developer)
2014-11-17 11:48

Repository: erp/pmods/org.openbravo.retail.fixcashupdata
Changeset: 551d4bc17c7fc5e77cbce422850e15f94c003914
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Nov 17 11:47:24 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.fixcashupdata/rev/551d4bc17c7fc5e77cbce422850e15f94c003914 [^]

Related to issue 27826: When browser cache is cleared, new cashup id is created, link non-reconciled tickets to this new cashupid
Filter on the selected organization in the order query

---
M src/org/openbravo/retail/fixcashupdata/FixCashUpDataProcess.java
---
(0071690)
mtaal (manager)
2014-11-17 11:49

Code was checked by me, found one issue (order query was not filtering on selected organization). I pushed a change for this.

Will ask Antonio to only review that last change, issue can then be closed.
(0071703)
marvintm (manager)
2014-11-17 13:28

Final change in the process reviewed. Issue can be closed.

- Issue History
Date Modified Username Field Change
2014-10-10 10:29 mtaal New Issue
2014-10-10 10:29 mtaal Assigned To => marvintm
2014-10-10 10:29 mtaal File Added: skype_chat_antonio_martin.txt
2014-10-10 10:29 mtaal Triggers an Emergency Pack => No
2014-11-10 10:39 marvintm File Added: issue27826.diff
2014-11-10 15:36 marvintm File Added: issue27826_forQ2.diff
2014-11-12 22:44 mtaal File Added: issue27826_forQ2_2.diff
2014-11-12 22:50 mtaal Note Added: 0071618
2014-11-12 22:51 mtaal Relationship added blocks 0028008
2014-11-12 22:51 mtaal Relationship deleted blocks 0028008
2014-11-12 22:52 mtaal Relationship added blocks 0028008
2014-11-12 23:26 mtaal Relationship deleted blocks 0028008
2014-11-16 23:17 mtaal Status new => scheduled
2014-11-16 23:17 mtaal fix_in_branch => pi
2014-11-16 23:18 mtaal Status scheduled => resolved
2014-11-16 23:18 mtaal Resolution open => fixed
2014-11-17 11:48 hgbot Checkin
2014-11-17 11:48 hgbot Note Added: 0071689
2014-11-17 11:49 mtaal Note Added: 0071690
2014-11-17 11:50 mtaal Relationship added blocks 0028008
2014-11-17 13:28 marvintm Review Assigned To => marvintm
2014-11-17 13:28 marvintm Note Added: 0071703
2014-11-17 13:28 marvintm Status resolved => closed
2014-12-05 16:28 marvintm File Added: issue27826_forQ2_finaldiff.diff


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker