Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0027614
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2014-09-16 13:222014-10-01 10:59
ReporterumartirenaView Statuspublic 
Assigned ToSandrahuguet 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionc1857251731f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toeduardo_Argal
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0027614: API Break on Reconciliation Project (try-api 673)

DescriptionLook at:

* API Break due to following columns have been marked as mandatory and not null in Fin_Finacc_Transaction table:
 - statementdate
 - dateacct
 - trxtype
* Also due to a new constraint in Fin_Finacc_Transaction table:
Constraint: FIN_TRANS_AMOUNTS_CHK defined as: (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0)
* The size of table AD_COLUMN Column ENTITY_ALIAS has changed from 60 to 2000
* Not Allowed insertions in AD_PROCESS_PARA table. ID: 993E5D1AE89649648DFE15C27360CD52 is a false positive. Action param now is created in application dictionary previously is hardcoded.

Risk api-changes:

* statementdate: There should not be any transaction without Transaction Date. Before this project is was not possible to add transactions with this field empty from the application.
* dateacct: The Accounting Date field it was possible to leave empty, but it should not be a common case, because this would mean a transaction not used in accounting, and this is an error and should be fixed.
If statementdate or dateacct a buildvalidation fails and to solve this it is very helpful to visit http://wiki.openbravo.com/wiki/Update_Transaction_Refactor [^]
* trxtype: The Transaction Type field it should not be a problem because there is a modulescript that inserts a value there in case is needed.
* (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0): there should not be any record with both amounts Zero, the application does not allow it. But we found that retail allowed to insert transactions with both amounts Zero. To fix this transactions we provide a new modulescript.
* Size of entity_alias in ad_column, it should not be a problem because the size is bigger.

Steps To ReproduceLook at: http://ci.openbravo.com/view/try/job/try-api/673/consoleFull [^]

 [checkAPI] 29166 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29170 ERROR - Errors in API model validation
 [checkAPI] 29173 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29178 ERROR - Check Constraint addition: table: FIN_FINACC_TRANSACTION - Constraint: FIN_TRANS_AMOUNTS_CHK defined as: (PAYMENTAMT <> 0) OR (DEPOSITAMT <> 0)
 [checkAPI] 29181 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.DATEACCT
 [checkAPI] 29185 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.TRXTYPE
 [checkAPI] 29189 ERROR - Column change from not required to required: column: FIN_FINACC_TRANSACTION.STATEMENTDATE
 [checkAPI] 29192 ERROR -
 [checkAPI]
 [checkAPI] 29195 WARN -
 [checkAPI]
 [checkAPI] 29199 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29202 WARN - Warnings in API model validation
 [checkAPI] 29205 WARN - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29208 WARN - Column size changed from 60 to 2000: column: AD_COLUMN.ENTITY_ALIAS
 [checkAPI] 29213 WARN -
 [checkAPI]
 [checkAPI] 29218 ERROR -
 [checkAPI]
 [checkAPI] 29222 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29225 ERROR - Errors in API data validation
 [checkAPI] 29228 ERROR - +++++++++++++++++++++++++++++++++++++++++++++++++++
 [checkAPI] 29232 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:7DC34559B416B45BE040007F0100784A from [N] to [Y]
 [checkAPI] 29237 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:828EE0AE801C5FA1E040007F010067C7 from [N] to [Y]
 [checkAPI] 29242 ERROR - Changed column value AD_COLUMN.ISMANDATORY -ID:828EE0AE801D5FA1E040007F010067C7 from [N] to [Y]
 [checkAPI] 29247 ERROR - Not Allowed insertions in AD_PROCESS_PARA table. ID: 993E5D1AE89649648DFE15C27360CD52
 [checkAPI] 29252 ERROR -
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0027694 closedSandrahuguet Constraint: FIN_TRANS_AMOUNTS_CHK should not be managed in the buildvalidation 

-  Notes
(0070207)
dmitry_mezentsev (developer)
2014-09-19 13:04

Approved.
Additional action. Add a link to the build validation to the wiki document so that user has explanations about actions to do.
(0070268)
hgbot (developer)
2014-09-23 10:17

Repository: erp/devel/api-checks
Changeset: c1857251731f87e51018ec81ba0208377579d15b
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Sep 23 10:12:48 2014 +0200
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c1857251731f87e51018ec81ba0208377579d15b [^]

Fixed issue 27614: API Break on Reconciliation Project (try-api 648)

---
M model/modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_PROCESS_PARA.xml
M model/src-db/database/model/tables/AD_COLUMN.xml
M model/src-db/database/model/tables/FIN_FINACC_TRANSACTION.xml
M model/src-db/database/sourcedata/AD_COLUMN.xml
---
(0070299)
Sandrahuguet (developer)
2014-09-24 09:38

Reopened to update the description
(0070605)
eduardo_Argal (developer)
2014-10-01 10:58

Code Reviewed and tested. These API changes were agreed and approved.

- Issue History
Date Modified Username Field Change
2014-09-16 13:22 umartirena New Issue
2014-09-16 13:22 umartirena Assigned To => dmiguelez
2014-09-16 13:22 umartirena Modules => Core
2014-09-16 13:22 umartirena Triggers an Emergency Pack => No
2014-09-19 13:04 dmitry_mezentsev Note Added: 0070207
2014-09-19 13:48 dmitry_mezentsev Assigned To dmiguelez => umartirena
2014-09-23 10:17 hgbot Checkin
2014-09-23 10:17 hgbot Note Added: 0070268
2014-09-23 10:17 hgbot Status new => resolved
2014-09-23 10:17 hgbot Resolution open => fixed
2014-09-23 10:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/c1857251731f87e51018ec81ba0208377579d15b [^]
2014-09-23 10:49 Sandrahuguet Assigned To umartirena => Sandrahuguet
2014-09-23 10:50 Sandrahuguet Review Assigned To => eduardo_Argal
2014-09-24 09:37 Sandrahuguet Status resolved => new
2014-09-24 09:37 Sandrahuguet Resolution fixed => open
2014-09-24 09:38 Sandrahuguet Note Added: 0070299
2014-09-24 10:01 Sandrahuguet Summary API Break on Reconciliation Project (try-api 648) => API Break on Reconciliation Project (try-api 673)
2014-09-24 10:01 Sandrahuguet Description Updated View Revisions
2014-09-24 10:01 Sandrahuguet Steps to Reproduce Updated View Revisions
2014-09-24 10:06 Sandrahuguet Description Updated View Revisions
2014-09-24 10:07 Sandrahuguet Description Updated View Revisions
2014-09-24 10:08 Sandrahuguet Description Updated View Revisions
2014-09-24 11:06 Sandrahuguet Description Updated View Revisions
2014-09-24 11:07 Sandrahuguet Status new => scheduled
2014-09-24 11:07 Sandrahuguet fix_in_branch => pi
2014-09-24 11:07 Sandrahuguet Status scheduled => resolved
2014-09-24 11:07 Sandrahuguet Resolution open => fixed
2014-09-26 12:05 Sandrahuguet Relationship added related to 0027694
2014-10-01 10:58 eduardo_Argal Note Added: 0070605
2014-10-01 10:58 eduardo_Argal Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker