0026389: Best Deal case has performance problems with Combos

diff -r 986e52f21807 web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
--- a/web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js	Mon Jan 27 12:19:58 2014 +0100
+++ b/web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js	Tue May 06 10:23:15 2014 +0200
@@ -11,6 +11,55 @@
 
 OB.Model.Discounts.discountRules[OB.OBCOMBO.comboRuleId] = {
   async: true,
+
+  isCandidate: function (discountRule, receipt, line, isCandidateCallback, isNotCandidateCallback) {
+    var familyCriteria = { // Query local DB to know detail about the rule
+      priceAdjustment: discountRule.id
+    },
+        isCandidateForNow = true;
+
+    OB.Dal.findUsingCache('ComboFamilyQuery', OB.Model.ComboFamily, familyCriteria, function (families) {
+      var familyCount = families.length;
+      families.forEach(function (family) {
+        var productCriteria = {
+          obcomboFamily: family.id
+        },
+            numOfUnits = 0,
+            line, i, productsInFamily = [];
+        if (!isCandidateForNow) {
+          return;
+        }
+
+        OB.Dal.findUsingCache('ComboProductQuery', OB.Model.ComboProduct, productCriteria, function (products) {
+          var foundProduct = false;
+
+          familyCount -= 1;
+
+          products.forEach(function (product) {
+            var currentLine;
+            for (i = 0; i < receipt.get('lines').length; i++) {
+              currentLine = receipt.get('lines').at(i);
+              if (currentLine.get('product').id === product.get('product')) {
+                numOfUnits += currentLine.get('qty');
+              }
+            }
+          }); // end loop products in family
+          if (family.get('quantity') > numOfUnits) {
+            isCandidateForNow = false;
+          }
+          if (familyCount === 0 || !isCandidateForNow) {
+            if (isCandidateForNow) {
+              isCandidateCallback();
+            } else {
+              isNotCandidateCallback();
+            }
+
+          }
+        }); // end find product
+      }); // end loop family
+    }); // end find family
+  },
+
   implementation: function (discountRule, receipt, line, listener) {
     var lineCandidates = new Backbone.Collection(),
         promotionCandidates = line.get('promotionCandidates') || [],

diff -r d92bcd92b38d web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
--- a/web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js	Thu Apr 03 13:51:50 2014 +0200
+++ b/web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js	Tue May 06 10:25:35 2014 +0200
@@ -703,6 +703,26 @@
     OB.trace('groups', groups);
     splitLines(candidates, groups);
   }
+  /**
+   * Recursively goes through all the discount rules in the collection, and executes the isCandidate function for each rule (if it exists), and removes the rule if it's not a candidate
+   */
+
+  function filterDiscountRules(discountRules, index, receipt, line, callback) {
+    if (index === discountRules.length) {
+      return callback();
+    }
+    var rule = OB.Model.Discounts.discountRules[discountRules.at(index).get('discountType')];
+    if (!rule.isCandidate) {
+      return filterDiscountRules(discountRules, index + 1, receipt, line, callback);
+    }
+
+    rule.isCandidate(discountRules.at(index), receipt, line, function () {
+      return filterDiscountRules(discountRules, index + 1, receipt, line, callback);
+    }, function () {
+      discountRules.remove(discountRules.at(index));
+      return filterDiscountRules(discountRules, index, receipt, line, callback);
+    })
+  }
 
   /**
    * Gets all the discount candidates that can be applied to each line in the ticket
@@ -732,13 +752,19 @@
       };
 
       OB.Dal.find(OB.Model.Discount, criteria, function (discountRules) {
+        var callbackAfterFiltering = function () {
+            i += 1;
+            if (i === lines.length) {
+              // we're done with all the lines, continue with next step
+              //splitLines(candidates);
+              doGroups(candidates);
+            }
+
+            };
+
         candidates[line.get('product').id] = discountRules;
-        i += 1;
-        if (i === lines.length) {
-          // we're done with all the lines, continue with next step
-          //splitLines(candidates);
-          doGroups(candidates);
-        }
+        filterDiscountRules(discountRules, 0, receipt, line, callbackAfterFiltering);
+
       });
     });
   }

diff -r b53280250e16 web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js
--- a/web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js	Mon May 05 16:48:52 2014 +0200
+++ b/web/org.openbravo.retail.discounts.combo/source/combo-rule-impl.js	Thu May 15 16:58:01 2014 +0200
@@ -8,9 +8,102 @@
  */
 
 /*global enyo, _, Backbone */
-
 OB.Model.Discounts.discountRules[OB.OBCOMBO.comboRuleId] = {
   async: true,
+
+  isCandidate: function (discountRule, receipt, line, isCandidateCallback, isNotCandidateCallback) {
+    var familyCriteria = { // Query local DB to know detail about the rule
+      priceAdjustment: discountRule.id
+    },
+        isCandidateForNow = true;
+
+    OB.Dal.findUsingCache('ComboFamilyQuery', OB.Model.ComboFamily, familyCriteria, function (families) {
+      var familyCount = families.length;
+      families.forEach(function (family) {
+        var productCriteria = {
+          obcomboFamily: family.id
+        },
+            numOfUnits = 0,
+            line, i, productsInFamily = [];
+
+        OB.Dal.findUsingCache('ComboProductQuery', OB.Model.ComboProduct, productCriteria, function (products) {
+          var foundProduct = false;
+
+          familyCount -= 1;
+
+          products.forEach(function (product) {
+            var currentLine;
+            for (i = 0; i < receipt.get('lines').length; i++) {
+              currentLine = receipt.get('lines').at(i);
+              if (currentLine.get('product').id === product.get('product')) {
+                numOfUnits += currentLine.get('qty');
+              }
+            }
+          }); // end loop products in family
+          if (family.get('quantity') > numOfUnits) {
+            isCandidateForNow = false;
+          }
+          if (familyCount === 0) {
+            if (isCandidateForNow) {
+              isCandidateCallback();
+            } else {
+              isNotCandidateCallback();
+            }
+
+          }
+        }); // end find product
+      }); // end loop family
+    }); // end find family
+  },
+  isCandidateFullReceipt: function (discountRule, combination, lineNo, isCandidateCallback, isNotCandidateCallback) {
+    var familyCriteria = { // Query local DB to know detail about the rule
+      priceAdjustment: discountRule.id
+    },
+        ruleId = discountRule.id,
+        isCandidateForNow = true;
+
+    OB.Dal.findUsingCache('ComboFamilyQuery', OB.Model.ComboFamily, familyCriteria, function (families) {
+      var familyCount = families.length,
+          theRuleId = ruleId;
+      families.forEach(function (family) {
+        var productCriteria = {
+          obcomboFamily: family.id
+        },
+            numOfUnits = 0,
+            line, i, productsInFamily = [];
+
+        OB.Dal.findUsingCache('ComboProductQuery', OB.Model.ComboProduct, productCriteria, function (products) {
+          var foundProduct = false;
+          var ruleId = theRuleId;
+          familyCount -= 1;
+
+          products.forEach(function (product) {
+            var currentLine, i;
+            for (i = 0; i < combination.length; i++) {
+              currentLine = combination[i].line.line;
+              if (currentLine.get('product').id === product.get('product')) {
+                if (ruleId === combination[i].rule.get('id')) {
+                  numOfUnits += currentLine.get('qty');
+                }
+              }
+            }
+          }); // end loop products in family
+          if (family.get('quantity') > numOfUnits) {
+            isCandidateForNow = false;
+          }
+          if (familyCount === 0) {
+            if (isCandidateForNow) {
+              isCandidateCallback();
+            } else {
+              isNotCandidateCallback();
+            }
+
+          }
+        }); // end find product
+      }); // end loop family
+    }); // end find family
+  },
+
   implementation: function (discountRule, receipt, line, listener) {
     var lineCandidates = new Backbone.Collection(),
         promotionCandidates = line.get('promotionCandidates') || [],
@@ -193,7 +286,7 @@
         });
       }
     });
-    OB.Dal.find(OB.Model.ComboFamily, familyCriteria, function (families) {
+    OB.Dal.findUsingCache('ComboFamilyQuery', OB.Model.ComboFamily, familyCriteria, function (families) {
       var familyCount = families.length;
       families.forEach(function (family) {
         var productCriteria = {
@@ -205,7 +298,7 @@
           return;
         }
 
-        OB.Dal.find(OB.Model.ComboProduct, productCriteria, function (products) {
+        OB.Dal.findUsingCache('ComboProductQuery', OB.Model.ComboProduct, productCriteria, function (products) {
           var foundProduct = false;
 
           familyCount -= 1;

diff -r a385edb70dbd web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js
--- a/web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js	Tue May 06 09:44:23 2014 -0300
+++ b/web/org.openbravo.retail.discounts.bestdeal/source/discounts-best-deal-case.js	Thu May 15 17:15:50 2014 +0200
@@ -350,17 +350,17 @@
    * shows a case in trace log as rule identifier -> product identifier
    */
   var simpleJSONCase = function (theCase) {
-    var ret = [],
-        i, it;
-    if (!OB.UTIL.checkPermissionLog("Trace", "console")) {
-      return theCase;
-    }
-    for (i = 0; i < theCase.length; i++) {
-      it = theCase[i];
-      ret.push(it.rule.get('_identifier') + " -> " + it.line.line.get('product').get('_identifier'));
-    }
-    return ret;
-  };
+      var ret = [],
+          i, it;
+      if (!OB.UTIL.checkPermissionLog("Trace", "console")) {
+        return theCase;
+      }
+      for (i = 0; i < theCase.length; i++) {
+        it = theCase[i];
+        ret.push(it.rule.get('_identifier') + " -> " + it.line.line.get('product').get('_identifier'));
+      }
+      return ret;
+      };
 
   nextCase = function (evaluatedCase) {
     var currentDiscount, bestLines, lines = receipt.get('lines');
@@ -482,33 +482,74 @@
       return combine(result);
     }
 
-    _.forEach(groups, function (group) {
-      var grpCombinations = calculate(group.subGrps);
+    function filterCombination(combination, lineNo, correctCombinationCallback, wrongCombinationCallback) {
+      var rule;
+      if (lineNo == combination.length) {
+        return correctCombinationCallback();
+      }
+      rule = OB.Model.Discounts.discountRules[combination[lineNo].rule.get('discountType')];
 
-      OB.trace(grpCombinations.length, 'combinations for grp', group, grpCombinations);
-      totalNumOfCombinations += grpCombinations.length;
-      allCombinations.push(grpCombinations);
-    });
-
-    OB.trace(totalNumOfCombinations, 'allCombinations', allCombinations);
-
-    if (totalNumOfCombinations > OB.Model.Discounts.OBPOSBD.maxCombinations) {
-      if (OB.POS.modelterminal.get('terminal').stopLongBDCEx) {
-        OB.warn('Not executing BDC with', totalNumOfCombinations, 'combinations');
-        OB.UTIL.showWarning(OB.I18N.getLabel('OBPOSBD_NotExecutedDueToNumOfCombinations'));
-        finalize();
-        return;
+      if (rule.isCandidateFullReceipt) {
+        rule.isCandidateFullReceipt(combination[lineNo].rule, combination, lineNo, function () {
+          return filterCombination(combination, lineNo + 1, correctCombinationCallback, wrongCombinationCallback);
+        }, function () {
+          wrongCombinationCallback();
+        });
       } else {
-        OB.warn('BDC execution found', totalNumOfCombinations, 'combinations. Executing anyway');
+        return filterCombination(combination, lineNo + 1, correctCombinationCallback, wrongCombinationCallback);
       }
     }
 
-    if (allCombinations.length > 0) {
-      evaluateSubBestDealCase(allCombinations[0]);
-    } else {
-      // nothing to do
-      finalize();
+    function filterGroupCombinations(grpCombinations, combinationNo, callback) {
+      var isValidCombination = true,
+          combination = grpCombinations[combinationNo];
+      isValidCombination = true;
+      if (combinationNo >= grpCombinations.length) {
+        return callback();
+      }
+      filterCombination(combination, 0, function () {
+        return filterGroupCombinations(grpCombinations, combinationNo + 1, callback);
+      }, function () {
+        grpCombinations.splice(combinationNo, 1);
+        return filterGroupCombinations(grpCombinations, combinationNo, callback);
+      })
     }
+
+    function calculateCombinationsForGroup(groups, indGroup, callback) {
+      if (indGroup >= groups.length) {
+        return callback();
+      }
+      group = groups[indGroup];
+      var grpCombinations = calculate(group.subGrps);
+      filterGroupCombinations(grpCombinations, 0, function () {
+        OB.trace(grpCombinations.length, 'combinations for grp', group, grpCombinations);
+        totalNumOfCombinations += grpCombinations.length;
+        allCombinations.push(grpCombinations);
+        calculateCombinationsForGroup(groups, indGroup + 1, callback);
+      });
+    }
+
+    calculateCombinationsForGroup(groups, 0, function () {
+      if (totalNumOfCombinations > OB.Model.Discounts.OBPOSBD.maxCombinations) {
+        if (OB.POS.modelterminal.get('terminal').stopLongBDCEx) {
+          OB.warn('Not executing BDC with', totalNumOfCombinations, 'combinations');
+          OB.UTIL.showWarning(OB.I18N.getLabel('OBPOSBD_NotExecutedDueToNumOfCombinations'));
+          finalize();
+          return;
+        } else {
+          OB.warn('BDC execution found', totalNumOfCombinations, 'combinations. Executing anyway. ', receipt.toJSON());
+        }
+      }
+      OB.warn('BDC execution found', totalNumOfCombinations, 'combinations. Executing anyway. ', receipt.get('documentNo'));
+
+      if (allCombinations.length > 0) {
+        evaluateSubBestDealCase(allCombinations[0]);
+      } else {
+        // nothing to do
+        finalize();
+      }
+    });
+
   }
 
   /**
@@ -707,6 +748,26 @@
     OB.trace('groups', groups);
     splitLines(candidates, groups);
   }
+  /**
+   * Recursively goes through all the discount rules in the collection, and executes the isCandidate function for each rule (if it exists), and removes the rule if it's not a candidate
+   */
+
+  function filterDiscountRules(discountRules, index, receipt, line, callback) {
+    if (index === discountRules.length) {
+      return callback();
+    }
+    var rule = OB.Model.Discounts.discountRules[discountRules.at(index).get('discountType')];
+    if (!rule.isCandidate) {
+      return filterDiscountRules(discountRules, index + 1, receipt, line, callback);
+    }
+
+    rule.isCandidate(discountRules.at(index), receipt, line, function () {
+      return filterDiscountRules(discountRules, index + 1, receipt, line, callback);
+    }, function () {
+      discountRules.remove(discountRules.at(index));
+      return filterDiscountRules(discountRules, index, receipt, line, callback);
+    })
+  }
 
   /**
    * Gets all the discount candidates that can be applied to each line in the ticket
@@ -736,13 +797,19 @@
       };
 
       OB.Dal.find(OB.Model.Discount, criteria, function (discountRules) {
+        var callbackAfterFiltering = function () {
+            i += 1;
+            if (i === lines.length) {
+              // we're done with all the lines, continue with next step
+              //splitLines(candidates);
+              doGroups(candidates);
+            }
+
+            };
+
         candidates[line.get('product').id] = discountRules;
-        i += 1;
-        if (i === lines.length) {
-          // we're done with all the lines, continue with next step
-          //splitLines(candidates);
-          doGroups(candidates);
-        }
+        filterDiscountRules(discountRules, 0, receipt, line, callbackAfterFiltering);
+
       });
     });
   }