Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025449
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Otherscriticalalways2014-01-08 17:042014-04-01 11:31
ReporterjecharriView Statuspublic 
Assigned Tojecharri 
PriorityimmediateResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchpiFixed in SCM revisionc2b00c4876c5
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tojonalegriaesarte
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0025449: int-3.0-api fails because I need to change 2 columns definition

DescriptionDue to this issue

https://issues.openbravo.com/view.php?id=24685 [^]

I have to make an api change. Below you will find the changeset and api change:
-https://code.openbravo.com/erp/devel/try/rev/48befdcb4245 [^]

-http://builds.openbravo.com/view/try/job/try-api/1728/console [^]

-The changes are the followings:
I have changed the definition of column processing to column processed and the definition of processed to processing. Apart from that, I have created a sqllofic field to be able to filter in the grid view by column "Processed"

-The risk of this api change is medium because of the following reason:
The problem was that button "Process/Unprocess" expense sheet was using column processing and it was wrong, because the button needs to change from processing to unprocess when processed has value 'Y' and the only way to do that is using processed column.
Apart from that the risk is medium because both columns only allow to save values 'Y' or 'N' but there are modules that are already using and we should do little changes
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00246853.0PR14Q2 closedjecharri After an Expense Sheet is processed, processing column stays 'Y'. 

-  Notes
(0063327)
dmitry_mezentsev (developer)
2014-01-09 10:32

 Approved with the need to rise the risk of the change to medium and to check about the way Processing column is handled by Openbravo.
(0063328)
dmitry_mezentsev (developer)
2014-01-09 10:39

 Sorry, does not work. If we change the way you propose we will introduce another regression then. Now Processed column is used in the grid for filtering which is handy and with this change we will delete this feature.

We need to do sth else.
(0063825)
dmitry_mezentsev (developer)
2014-01-31 13:26

 Approved.
(0063884)
hgbot (developer)
2014-02-04 11:57

 Repository: erp/devel/api-checks
Changeset: c2b00c4876c5dadadb5ae05ed514f15df4a70b9b
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Tue Feb 04 11:57:13 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/c2b00c4876c5dadadb5ae05ed514f15df4a70b9b [^]

Fixes issue 25449: int-3.0-api fails because I need to change 2 columns definition

---
M model/src-db/database/sourcedata/AD_COLUMN.xml
M model/src-db/database/sourcedata/AD_FIELD.xml
---
(0063910)
hgbot (developer)
2014-02-05 01:51

 Repository: erp/devel/api-checks
Changeset: 47d63c7ce10be9efa32b8e01ddfedeea0223df21
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Wed Feb 05 01:51:28 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/47d63c7ce10be9efa32b8e01ddfedeea0223df21 [^]

issue 25449: int-3.0-api fails because
I need to change 2 columns definition

---
M java/reference/java.japi.gz
---
(0064006)
hgbot (developer)
2014-02-06 18:41

 Repository: erp/devel/api-checks
Changeset: 5b1b3f343cc6e168ce66982248b14fcffd099d8d
Author: Javier Etxarri <javier.echarri <at> openbravo.com>
Date: Thu Feb 06 18:42:00 2014 +0100
URL: http://code.openbravo.com/erp/devel/api-checks/rev/5b1b3f343cc6e168ce66982248b14fcffd099d8d [^]

issue 25449: int-3.0-api fails because
I need to change 2 columns definition

---
M model/src-db/database/model/tables/S_TIMEEXPENSE.xml
---

- Issue History
Date Modified Username Field Change
2014-01-08 17:04 jecharri New Issue
2014-01-08 17:04 jecharri Assigned To => dmitry_mezentsev
2014-01-08 17:04 jecharri Web browser => Google Chrome
2014-01-08 17:04 jecharri Modules => Core
2014-01-08 17:04 jecharri Triggers an Emergency Pack => No
2014-01-09 10:33 dmitry_mezentsev Note Added: 0063327
2014-01-09 10:39 dmitry_mezentsev Note Added: 0063328
2014-01-09 10:40 dmitry_mezentsev Assigned To dmitry_mezentsev => jecharri
2014-01-09 10:47 jecharri Web browser Google Chrome => Google Chrome
2014-01-09 10:47 jecharri Description Updated View Revisions
2014-01-31 12:27 jecharri Web browser Google Chrome => Google Chrome
2014-01-31 12:27 jecharri Description Updated View Revisions
2014-01-31 13:26 dmitry_mezentsev Note Added: 0063825
2014-01-31 14:11 jecharri Status new => scheduled
2014-01-31 14:11 jecharri fix_in_branch => pi
2014-02-04 11:57 hgbot Checkin
2014-02-04 11:57 hgbot Note Added: 0063884
2014-02-04 11:57 hgbot Status scheduled => resolved
2014-02-04 11:57 hgbot Resolution open => fixed
2014-02-04 11:57 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/api-checks/rev/c2b00c4876c5dadadb5ae05ed514f15df4a70b9b [^]
2014-02-05 01:51 hgbot Checkin
2014-02-05 01:51 hgbot Note Added: 0063910
2014-02-06 18:41 hgbot Checkin
2014-02-06 18:41 hgbot Note Added: 0064006
2014-02-27 18:21 jecharri Relationship added related to 0024685
2014-04-01 11:31 jonalegriaesarte Review Assigned To => jonalegriaesarte
2014-04-01 11:31 jonalegriaesarte Status resolved => closed
2014-04-01 11:31 jonalegriaesarte Fixed in Version => PR14Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker