Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0024800

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

design defect

[Openbravo ERP] 09. Financial management

trivial

always

2013-09-19 17:40

2014-03-17 13:41

Reporter

chelipf

View Status

public

Assigned To

dmiguelez

Priority

normal

Resolution

fixed

Fixed in Version

3.0PR14Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

3.0PR14Q2

OS

Linux 64 bit

Database

PostgreSQL

Java version

1.6.0_27

OS Version

Debian Wheezy

Database version

9.1

Ant version

1.8.2

Product Version

3.0MP26.2

SCM revision

Merge Request Status

Review Assigned To

egoitz

OBNetwork customer

OBPS

Web browser

Mozilla Firefox

Modules

Core

Support ticket

26375

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0024800: createAccDefExpenseFact and computeTaxUndeductableLine methods of DocInvoice class must be public

Description

These two methods must be public so that we can use them when overriding the accounting process.

Steps To Reproduce

Create a DocInvoiceTemplate class and try to execute these lines:

docInvoice.createAccDefExpenseFact(something);
docInvoice.computeTaxUndeductableLine(something);

Proposed Solution

Set these methods as public.

Tags

DocInvoice.diff [^] (1,144 bytes) 2014-02-19 18:07 [Show Content] [Hide Content]

--- /home/cheli/Openbravo-3.0MP28.5/src/org/openbravo/erpCommon/ad_forms/DocInvoice.java	2013-12-23 06:58:33.000000000 -0500
+++ ../src/org/openbravo/erpCommon/ad_forms/DocInvoice.java	2013-12-02 10:10:13.863980632 -0500
@@ -978,7 +978,7 @@
     return plan;
   }
 
-  String createAccDefExpenseFact(Fact fact, DocLine_Invoice line, Account prodExpAccount,
+  public String createAccDefExpenseFact(Fact fact, DocLine_Invoice line, Account prodExpAccount,
       Account prodDefExpAccount, String lineAmount, String strCurrencyId, ConnectionProvider conn) {
     BigDecimal amount = new BigDecimal(lineAmount);
     String Fact_Acct_Group_ID = SequenceIdData.getUUID();
@@ -1245,7 +1245,7 @@
     return "Servlet for the accounting";
   } // end of getServletInfo() method
 
-  private void computeTaxUndeductableLine(ConnectionProvider conn, AcctSchema as, Fact fact,
+  public void computeTaxUndeductableLine(ConnectionProvider conn, AcctSchema as, Fact fact,
       DocLine docLine, String Fact_Acct_Group_ID, String taxId, String strTaxAmount) {
     int invoiceLineTaxCount = 0;
     int totalInvoiceLineTax = getTaxLineCount(conn, taxId);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

createAccDefRevenueFact function should be public in DocInvoice class

Notes
(0065039) hgbot (developer) 2014-03-11 12:18	Repository: erp/devel/pi Changeset: 6599ad0244963cc142621315c23805d447646a8e Author: Jon Alegría <jon.alegria <at> openbravo.com> Date: Tue Mar 11 12:18:27 2014 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/6599ad0244963cc142621315c23805d447646a8e [^] Fixes issue 0024800: createAccDefExpenseFact and computeTaxUndeductableLine methods of DocInvoice class must be public --- M src/org/openbravo/erpCommon/ad_forms/DocInvoice.java ---

(0065073) hudsonbot (viewer) 2014-03-12 05:19	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/82d89b03cb26 [^] Maturity status: Test

(0065229) egoitz (viewer) 2014-03-17 13:41	verified

Issue History
Date Modified	Username	Field	Change
2013-09-19 17:40	chelipf	New Issue
2013-09-19 17:40	chelipf	Assigned To	=> dmiguelez
2013-09-19 17:40	chelipf	Web browser	=> Mozilla Firefox
2013-09-19 17:40	chelipf	Modules	=> Core
2013-09-19 17:40	chelipf	Triggers an Emergency Pack	=> No
2013-10-03 19:19	chelipf	Tag Attached: Sidesoft
2014-02-19 18:07	jonalegriaesarte	Web browser	Mozilla Firefox => Mozilla Firefox
2014-02-19 18:07	jonalegriaesarte	OBNetwork customer	=> Yes
2014-02-19 18:07	jonalegriaesarte	Support ticket	=> 26375
2014-02-19 18:07	jonalegriaesarte	Target Version	=> 3.0MP32
2014-02-19 18:07	jonalegriaesarte	File Added: DocInvoice.diff
2014-03-11 12:18	hgbot	Checkin
2014-03-11 12:18	hgbot	Note Added: 0065039
2014-03-11 12:18	hgbot	Status	new => resolved
2014-03-11 12:18	hgbot	Resolution	open => fixed
2014-03-11 12:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/6599ad0244963cc142621315c23805d447646a8e [^]
2014-03-12 05:19	hudsonbot	Checkin
2014-03-12 05:19	hudsonbot	Note Added: 0065073
2014-03-17 13:41	egoitz	Review Assigned To	=> egoitz
2014-03-17 13:41	egoitz	Note Added: 0065229
2014-03-17 13:41	egoitz	Status	resolved => closed
2014-03-17 13:41	egoitz	Fixed in Version	=> PR14Q2
2017-02-07 11:11	ngarcia	Relationship added	related to 0035181

Copyright © 2000 - 2009 MantisBT Group