Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0024796 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | always | 2013-09-19 14:00 | 2014-06-20 17:54 | |||
| Reporter | maite | View Status | public | |||||
| Assigned To | caristu | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 88ddb52efe04 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP28 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Advanced Payables and Receivables Mngmt | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0024796: New recalculated Exchange Rate should be rounded when inserted in fin_payment table, when working with multicurrency | |||||||
| Description | New recalculated Exchange Rate should be rounded when inserted in fin_payment table, when working with multicurrency | |||||||
| Steps To Reproduce | 1. Configure "Transferencia" Payment Method as "Receive Payment in multiple currencies" in Financial Account "Cuenta de Banco" 2. Define conversion rate between USD and EUR as 1.12345678 3. Create new Payment In header for any BP using Transferencia and Cuenta de Banco and set currency=USD . set Amount=15 . Conversion rate information will be automatically loaded 4. "Add details" and set amount =15 and any gl item. Process. Realize that conversion rate has been recalculated to 1.12333333 5. Try to edit payment's description and error "Payment processed/posted" will be raised when it should not (problem is that value of finacc_txn_convert_rate field in database is not rounded) | |||||||
| Proposed Solution | Problem is in "setFinancialTransactionAmountAndRate" method in FIN_AddPayment file. Conversion rate is recalculated using following formula: finTxnConvertRate = finTxnAmount.divide(paymentAmount, MathContext.DECIMAL64); Variable "finTxnConvertRate" needs to be rounded to number of decimals defined in Format.xml for "generalQty" type reference | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0061299) hgbot (developer) 2013-09-19 19:09 |
Repository: erp/devel/pi Changeset: 88ddb52efe0448e758620b656096584d7fc2a2c2 Author: Carlos Aristu <carlos.aristu <at> openbravo.com> Date: Thu Sep 19 19:08:41 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/88ddb52efe0448e758620b656096584d7fc2a2c2 [^] fixes issue 24796: New recalculated Exchange Rate should be rounded when inserted in fin_payment table, when working with multicurrency --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java --- |
|
(0061318) maite (developer) 2013-09-20 14:15 |
verified |
|
(0061323) hudsonbot (developer) 2013-09-20 16:14 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9adf8dd6aa1b [^] Maturity status: Test |
|
(0068174) hgbot (developer) 2014-06-19 17:04 |
Repository: erp/devel/pi Changeset: 1fe0e783e8513738f1993962798bee3f6253e8e9 Author: Unai Martirena <unai.martirena <at> openbravo.com> Date: Wed Jun 11 18:32:43 2014 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/1fe0e783e8513738f1993962798bee3f6253e8e9 [^] [aprm-windows] Prevent Issue 0024796 --- M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/AddPaymentActionHandler.java --- |
|
(0068233) hudsonbot (developer) 2014-06-20 17:54 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/089e5cbefd60 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2013-09-19 14:00 | maite | New Issue | |
| 2013-09-19 14:00 | maite | Assigned To | => dmiguelez |
| 2013-09-19 14:00 | maite | Modules | => Advanced Payables and Receivables Mngmt |
| 2013-09-19 14:00 | maite | Triggers an Emergency Pack | => No |
| 2013-09-19 14:00 | maite | Target Version | => 3.0MP28 |
| 2013-09-19 14:00 | maite | Issue Monitored: networkb | |
| 2013-09-19 14:11 | jonalegriaesarte | Assigned To | dmiguelez => caristu |
| 2013-09-19 19:09 | hgbot | Checkin | |
| 2013-09-19 19:09 | hgbot | Note Added: 0061299 | |
| 2013-09-19 19:09 | hgbot | Status | new => resolved |
| 2013-09-19 19:09 | hgbot | Resolution | open => fixed |
| 2013-09-19 19:09 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/88ddb52efe0448e758620b656096584d7fc2a2c2 [^] |
| 2013-09-20 14:15 | maite | Note Added: 0061318 | |
| 2013-09-20 14:15 | maite | Status | resolved => closed |
| 2013-09-20 16:14 | hudsonbot | Checkin | |
| 2013-09-20 16:14 | hudsonbot | Note Added: 0061323 | |
| 2014-06-19 17:04 | hgbot | Checkin | |
| 2014-06-19 17:04 | hgbot | Note Added: 0068174 | |
| 2014-06-20 17:54 | hudsonbot | Checkin | |
| 2014-06-20 17:54 | hudsonbot | Note Added: 0068233 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |