0024600: Dead code removal needed

Description

There is some code added due to old Smartclient issues, that since we upgraded to 8.3d in May-2012 it is not needed anymore. These duplicities should be remove to avoid conflicts with newer Smartclient versions that could add new logic to these functions that probably we want to take advantage of.

Case a)
https://code.openbravo.com/erp/devel/pi/file/2ca13963417f/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js#l541 [^]

already present here:
https://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/file/52de15b81e59/web/org.openbravo.userinterface.smartclient/isomorphic/client/language/Date.js#l123 [^]

Case b)
https://code.openbravo.com/erp/devel/pi/file/2ca13963417f/modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js#l743 [^]

already present here:
https://code.openbravo.com/erp/mods/org.openbravo.userinterface.smartclient.dev/file/52de15b81e59/web/org.openbravo.userinterface.smartclient/isomorphic/client/widgets/form/FormItem.js#l5487 [^]

Steps To Reproduce

Case a)
Open any read only window (fex: booked 'Sales Order') and ensure that everything displays in the same way

Case b)
Open any window containing date inputs (fex: 'Sales Order') and ensure that everything works in the same way

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0060795) hgbot (developer) 2013-08-28 01:18	Repository: erp/devel/pi Changeset: 74e284988f4204e1904ad9a6ae478a60670452c9 Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Wed Aug 28 01:17:39 2013 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/74e284988f4204e1904ad9a6ae478a60670452c9 [^] Fixed issue 24600: Removed not needed code --- M modules/org.openbravo.userinterface.smartclient/web/org.openbravo.userinterface.smartclient/js/ob-smartclient.js ---

(0060814) hudsonbot (developer) 2013-08-29 13:17	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0268756c9c4a [^] Maturity status: Test

(0060817) AugustoMauch (manager) 2013-08-29 13:29	Code reviewed and verified in pi@cf4de3045215

Issue History
Date Modified	Username	Field	Change
2013-08-28 01:14	dbaz	New Issue
2013-08-28 01:14	dbaz	Assigned To	=> dbaz
2013-08-28 01:14	dbaz	Modules	=> Core
2013-08-28 01:14	dbaz	Triggers an Emergency Pack	=> No
2013-08-28 01:15	dbaz	Review Assigned To	=> AugustoMauch
2013-08-28 01:16	dbaz	Issue Monitored: AugustoMauch
2013-08-28 01:17	dbaz	Summary	Death code removal needed => Dead code removal needed
2013-08-28 01:18	hgbot	Checkin
2013-08-28 01:18	hgbot	Note Added: 0060795
2013-08-28 01:18	hgbot	Status	new => resolved
2013-08-28 01:18	hgbot	Resolution	open => fixed
2013-08-28 01:18	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/74e284988f4204e1904ad9a6ae478a60670452c9 [^]
2013-08-29 13:17	hudsonbot	Checkin
2013-08-29 13:17	hudsonbot	Note Added: 0060814
2013-08-29 13:29	AugustoMauch	Note Added: 0060817
2013-08-29 13:29	AugustoMauch	Status	resolved => closed
2013-08-29 13:29	AugustoMauch	Fixed in Version	=> 3.0MP27