Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0023869
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2013-05-21 18:032013-06-18 19:11
ReporterOrekariaView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRMP24
StatusclosedFix in branchFixed in SCM revision2f801ac9ceb7
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionWindowsDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023869: Events are registered multiple times when they should be registered once

DescriptionEvents are registered multiple times when they should be registered once, causing the same function to be called multiple times.
Unexpected behavior after some POS use is expected.
Steps To ReproduceIn the ob-terminal-model.js

In the renderGenericWindow

Set a console.log('I was here') line into the function

 this.on('window:ready', function (w) {


Login into the POS
Navigate from pointofsale to cashup to pointofsale

Check the log
Proposed SolutionImplement an eventHelper to centralize backbone event registering
or
Fine tune objects destruction



TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0058736)
Orekaria (administrator)
2013-05-21 18:05
edited on: 2013-05-21 18:06

Check:
http://lostechies.com/derickbailey/2011/09/15/zombies-run-managing-page-transitions-in-backbone-apps/ [^]
http://stackoverflow.com/questions/7883947/event-triggered-multiple-times-after-using-back-button-in-backbone-js [^]

(0059081)
Orekaria (administrator)
2013-05-30 19:18
edited on: 2013-05-30 19:18

Need closer look/change:

- ob-terminal-model.js: cleaned but renderLogin is still there
- ob-datasource.js: OB.DS.DataSource.prototype.find and OB.DS.DataSource.prototype.exec
- ob-retail-searchproducts.js: receiptChanged
- listreceiptscounter.js: orderListChanged
- tabcashtokeep.js: paymentToKeepChanged
- tabpostprintclose.js: modelChanged
- bussinesspartner.js: orderChanged
- listreceiptscounter.js: orderListChanged
- modalreceipts.js: receiptsListChanged
- order.js: orderChanged
- orderdetails.js: orderChanged
- salesrepresentative.js: orderChanged
- login-model.js: renderMain 'seqNoReady'
- executor.js: nextEvent, applyRule?
- pointofsale-print.js: PrintReceiptLine
- editline.js: selectedListener, receiptChanged
- keyboardorder.js: receiptChanged
- payment.js: receiptChanged
- scan.js: receiptChanged
- toolbar-right.js: receiptChanged
- dal.js: asyncTest
- offline-data.js: asyncTest

(0059287)
hgbot (developer)
2013-06-10 10:29

Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 2f801ac9ceb7b6dce478275da8147f387a3bf4c4
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Jun 10 10:04:19 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f801ac9ceb7b6dce478275da8147f387a3bf4c4 [^]

Fixed issue 0023869. Now, events in the terminal-model are being registered once.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0059351)
hgbot (developer)
2013-06-11 13:29

Repository: erp/pmods/org.openbravo.mobile.core.multiorder
Changeset: 2f801ac9ceb7b6dce478275da8147f387a3bf4c4
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Mon Jun 10 10:04:19 2013 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core.multiorder/rev/2f801ac9ceb7b6dce478275da8147f387a3bf4c4 [^]

Fixed issue 0023869. Now, events in the terminal-model are being registered once.

---
M web/org.openbravo.mobile.core/source/model/ob-terminal-model.js
---
(0059501)
guilleaer (manager)
2013-06-18 19:11

verified

- Issue History
Date Modified Username Field Change
2013-05-21 18:03 Orekaria New Issue
2013-05-21 18:03 Orekaria Assigned To => marvintm
2013-05-21 18:05 Orekaria Note Added: 0058736
2013-05-21 18:05 Orekaria Proposed Solution updated
2013-05-21 18:06 Orekaria Note Edited: 0058736 View Revisions
2013-05-29 09:47 Orekaria Type design defect => defect
2013-05-30 19:18 Orekaria Note Added: 0059081
2013-05-30 19:18 Orekaria Note Edited: 0059081 View Revisions
2013-06-10 10:29 hgbot Checkin
2013-06-10 10:29 hgbot Note Added: 0059287
2013-06-10 10:29 hgbot Status new => resolved
2013-06-10 10:29 hgbot Resolution open => fixed
2013-06-10 10:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f801ac9ceb7b6dce478275da8147f387a3bf4c4 [^]
2013-06-11 13:29 hgbot Checkin
2013-06-11 13:29 hgbot Note Added: 0059351
2013-06-11 13:29 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/2f801ac9ceb7b6dce478275da8147f387a3bf4c4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core.multiorder/rev/2f801ac9ceb7b6dce478275da8147f387a3bf4c4 [^]
2013-06-18 19:11 guilleaer Review Assigned To => guilleaer
2013-06-18 19:11 guilleaer Note Added: 0059501
2013-06-18 19:11 guilleaer Status resolved => closed
2013-06-18 19:11 guilleaer Fixed in Version => RMP24


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker