Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0023087
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2013-02-15 13:372013-03-02 05:48
ReportermiruritaView Statuspublic 
Assigned Topramakrishnan 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiona4b042d99920
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned ToSandrahuguet
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0023087: Doubtful Debt Run pick and edit not working properly with comma configured as decimal separator

DescriptionDoubtful Debt Run pick and edit not working properly with comma configured as decimal separator
Steps To Reproduce1) Go to Doubtful Debt Run window
2) Create a new record (leave fields with default value)
3) Click on "Select Doubtful Debt" button
4) Select any row with decimals in Outstanding Amount
5) Realize that proposed amount is wrong.
6) See attached screenshot
Proposed Solutionsee attached patch.

Considerations:
1) The resulting number must be cast to Number. done in the patch.
2) The division must be rounded (done in the patch)
3) The division must be rounded to the standard precision of the currency of the selected invoice. pending to be done.

In the attached patch it is using an static precision (2).
If you do not round the amount stored in database will contain a lot of decimals although you only see 2 in the grid (this is because the format defined in Format.xml is being applied).
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2013-02-15 13:36:48.png [^] (51,590 bytes) 2013-02-15 13:37


diff file icon partial_proposed_solution.diff [^] (1,128 bytes) 2013-02-18 11:29 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0056683)
pramakrishnan (developer)
2013-02-21 14:44

 Test Plan:
1) Configure the decimal separator as comma in Format.xml
2) Go to Doubtful Debt Run window
3) Create a new record (leave fields with default value)
4) Click on "Select Doubtful Debt" button
5) Select any row with decimals in Outstanding Amount
6) Realize that the doubtful debt amount is proposed correctly
(0056780)
hgbot (developer)
2013-02-26 16:34

 Repository: erp/devel/pi
Changeset: a4b042d99920a73f540477b470b652fbb42a1794
Author: Pandeeswari Ramakrishnan <pandeeswari.ramakrishnan <at> openbravo.com>
Date: Thu Feb 21 19:08:52 2013 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a4b042d99920a73f540477b470b652fbb42a1794 [^]

Fixes Issue 23087: Doubtful Debt Run pick and edit not working properly

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/DoubtFulDebtPickEditLines.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-utilities.js
---
(0056781)
hgbot (developer)
2013-02-26 16:34

 Repository: erp/devel/pi
Changeset: 7f5b39dd5784feb76908b242e756869be332fdec
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Tue Feb 26 16:32:45 2013 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7f5b39dd5784feb76908b242e756869be332fdec [^]

Related to issue 23087

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
---
(0056782)
Sandrahuguet (developer)
2013-02-26 16:37

 Code review + testing OK
(0056916)
hudsonbot (developer)
2013-03-02 05:48

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test
(0056917)
hudsonbot (developer)
2013-03-02 05:48

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/f5db629e7058 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2013-02-15 13:37 mirurita New Issue
2013-02-15 13:37 mirurita Assigned To => mirurita
2013-02-15 13:37 mirurita File Added: Screenshot from 2013-02-15 13:36:48.png
2013-02-15 13:37 mirurita Modules => Core
2013-02-15 13:37 mirurita Triggers an Emergency Pack => No
2013-02-15 13:55 mirurita Assigned To mirurita => dmiguelez
2013-02-15 13:56 mirurita File Added: partial_proposed_solution.patch
2013-02-15 14:00 mirurita Proposed Solution updated
2013-02-18 11:28 mirurita File Deleted: partial_proposed_solution.patch
2013-02-18 11:29 mirurita File Added: partial_proposed_solution.diff
2013-02-20 13:05 pramakrishnan Assigned To dmiguelez => pramakrishnan
2013-02-20 13:05 pramakrishnan Status new => scheduled
2013-02-20 13:05 pramakrishnan fix_in_branch => pi
2013-02-21 14:44 pramakrishnan Note Added: 0056683
2013-02-26 16:34 hgbot Checkin
2013-02-26 16:34 hgbot Note Added: 0056780
2013-02-26 16:34 hgbot Status scheduled => resolved
2013-02-26 16:34 hgbot Resolution open => fixed
2013-02-26 16:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a4b042d99920a73f540477b470b652fbb42a1794 [^]
2013-02-26 16:34 hgbot Checkin
2013-02-26 16:34 hgbot Note Added: 0056781
2013-02-26 16:37 Sandrahuguet Review Assigned To => Sandrahuguet
2013-02-26 16:37 Sandrahuguet Note Added: 0056782
2013-02-26 16:37 Sandrahuguet Status resolved => closed
2013-03-02 05:48 hudsonbot Checkin
2013-03-02 05:48 hudsonbot Note Added: 0056916
2013-03-02 05:48 hudsonbot Checkin
2013-03-02 05:48 hudsonbot Note Added: 0056917

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker