Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0022006
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] 09. Financial managementcriticalalways2012-10-19 09:462012-11-21 18:13
Reportereduardo_ArgalView Statuspublic 
Assigned Toeduardo_Argal 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisiond9d11507b086
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2012-08-01
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/c8f8fc23ae0b [^]
Triggers an Emergency Packyes
Summary

0022006: DueDate column of FIN_PaymentSchedule table has changed its semantic

DescriptionDueDate column of FIN_PaymentSchedule table has changed its semantic.
When re-factoring editable payment plan a new column was added ("origduedate"), this new column now holds the semantic "duedate" column was holding before. This is UNACCEPTABLE. Changes in semantic are API changes as logic based on prior semantic continues working but not as expected, resulting into non consistent data analysis.
Steps To ReproduceIf you print now an invoice in which you have changed expected due date, invoice form holds expected date when it should hold due date as per contract
Proposed SolutionCreate a new column called "expectedduedate" which will hold "duedate" value, deprecate "origduedate" and move "origduedate" value into "duedate" column.

Review everywhere where this is being used and fix expected behavior.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0053955)
hgbot (developer)
2012-10-31 19:30

Repository: erp/devel/pi
Changeset: d9d11507b086fc1b8a0d38470e449beb8913f876
Author: Eduardo Argal Guibert <eduardo.argal <at> openbravo.com>
Date: Wed Oct 31 17:44:20 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d9d11507b086fc1b8a0d38470e449beb8913f876 [^]

Fixes issue 22006

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_INV.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/model/functions/APRM_GEN_PAYMENTSCHEDULE_ORD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/model/views/APRM_PAYMENT_PROP_PICK_EDIT.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TAB.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TEXTINTERFACES.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/actionHandler/ModifyPaymentPlanActionHandler.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddOrderOrInvoice.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransactionGrid.srpt
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransactionGrid.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentGrid.srpt
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentGrid.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentProposalGrid.srpt
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentProposalGrid.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/SelectExpectedPayments.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/SelectExpectedPayments.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/dao/AdvPaymentMngtDao.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_AddPayment.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/process/FIN_PaymentMonitorProcess.java
M src-db/database/model/tables/FIN_PAYMENT_SCHEDULE.xml
M src-db/database/model/views/FIN_PAYMENT_DETAIL_V.xml
M src-db/database/model/views/FIN_PAYMENT_PROP_DETAIL_V.xml
M src-db/database/model/views/FIN_PAYMENT_SCHED_INV_V.xml
M src-db/database/model/views/FIN_PAYMENT_SCHED_ORD_V.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_PROCESS_PARA.xml
M src-db/database/sourcedata/AD_REFERENCE.xml
M src-db/database/sourcedata/OBUISEL_SELECTOR.xml
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateDueDate.class
A src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateDueDateData.class
A src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/UpdateDueDateData.java
A src-util/modulescript/src/org/openbravo/modulescript/UpdateDueDate.java
A src-util/modulescript/src/org/openbravo/modulescript/UpdateDueDate_data.xsql
---
(0054023)
hudsonbot (developer)
2012-11-06 10:47

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/905762a34c04 [^]

Maturity status: Test
(0054268)
dmiguelez (developer)
2012-11-15 12:58

Code Review + Testing OK
(0054331)
hgbot (developer)
2012-11-19 20:15

Repository: erp/mods/org.openbravo.agingbalance
Changeset: cac195608f49a940cab0afa747599b6171259100
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Nov 13 17:06:09 2012 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.agingbalance/rev/cac195608f49a940cab0afa747599b6171259100 [^]

Related to Issue 0022006: Editable Payment Plan Refractor.

---
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/agingbalance/ad_reports/AgingDao.java
---
(0054436)
hgbot (developer)
2012-11-21 18:13

Repository: erp/mods/org.openbravo.erputil.aprmigrationtool
Changeset: f2b709938579bd6c94e7f046b2c424b3bae211f8
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Tue Nov 13 17:05:48 2012 +0100
URL: http://code.openbravo.com/erp/mods/org.openbravo.erputil.aprmigrationtool/rev/f2b709938579bd6c94e7f046b2c424b3bae211f8 [^]

Related to Issue 0022006: Editable Payment Plan Refractor.

---
M src-db/database/model/functions/APRMT_MANAGE_DEBTPAYMENTS.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/AD_MODULE.xml
M src/org/openbravo/erputil/aprmigrationtool/dao/MigrationToolDao.java
---

- Issue History
Date Modified Username Field Change
2012-10-19 09:46 eduardo_Argal New Issue
2012-10-19 09:46 eduardo_Argal Assigned To => eduardo_Argal
2012-10-19 09:46 eduardo_Argal Modules => Core
2012-10-19 09:50 eduardo_Argal Regression level => Production - Confirmed Stable
2012-10-19 09:50 eduardo_Argal Regression date => 2012-08-01
2012-10-19 09:50 eduardo_Argal Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/c8f8fc23ae0b [^]
2012-10-19 16:35 dmitry_mezentsev Issue Monitored: dmitry_mezentsev
2012-10-22 17:18 gorka_gil Issue Monitored: gorka_gil
2012-10-23 10:53 eduardo_Argal Status new => scheduled
2012-10-23 10:53 eduardo_Argal fix_in_branch => pi
2012-10-31 19:30 hgbot Checkin
2012-10-31 19:30 hgbot Note Added: 0053955
2012-10-31 19:30 hgbot Status scheduled => resolved
2012-10-31 19:30 hgbot Resolution open => fixed
2012-10-31 19:30 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d9d11507b086fc1b8a0d38470e449beb8913f876 [^]
2012-11-06 10:47 hudsonbot Checkin
2012-11-06 10:47 hudsonbot Note Added: 0054023
2012-11-15 12:58 dmiguelez Review Assigned To => dmiguelez
2012-11-15 12:58 dmiguelez Note Added: 0054268
2012-11-15 12:58 dmiguelez Status resolved => closed
2012-11-19 20:15 hgbot Checkin
2012-11-19 20:15 hgbot Note Added: 0054331
2012-11-21 18:13 hgbot Checkin
2012-11-21 18:13 hgbot Note Added: 0054436


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker