Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021922
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2012-10-11 18:512012-10-23 14:40
ReportercaristuView Statuspublic 
Assigned Toshankarb 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchpiFixed in SCM revisionf1f0bcb3e992
ProjectionnoneETAnoneTarget Version3.0MP17
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Todbaz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021922: Synchronize Terminology does not work properly with MERGE modules

DescriptionSynchronize Terminology does not work properly with MERGE modules

There is a MAX in this line of the PL AD_SYNCHRONIZE:

https://code.openbravo.com/erp/devel/pi/file/80586c65a422/src-db/database/model/functions/AD_SYNCHRONIZE.xml#l235 [^]

So if you have more than one dbprefix in your module and you are trying to update the name of a column for a module that are not the MAX the processes fail trying
to put a name like: EM_PREFIXOFTHEMAXMODULE_EM_YOURREAL_PREFIX_CoulumnNAme and this is not allowed by the trigger AD_COLUMN_TRG2 so the
process fails.
Steps To Reproduce1) Create a merged module with 2 different dbprefixes

2) Create two columns one of each module

3) Create two external columns, one of each module

4) Execute Synchronize Terminology
Proposed SolutionModify the query adding a restriction from:

AND P.AD_MODULE_DBPREFIX_ID = (SELECT MAX(AD_MODULE_DBPREFIX_ID)
FROM AD_MODULE_DBPREFIX P1
WHERE P1.AD_MODULE_ID = C.Ad_MODULE_ID))

to

AND P.AD_MODULE_DBPREFIX_ID = (SELECT MAX(AD_MODULE_DBPREFIX_ID)
FROM AD_MODULE_DBPREFIX P1
WHERE P1.AD_MODULE_ID = C.Ad_MODULE_ID
++ AND ((instr(upper(C.columnname), 'EM_'||upper(P1.name)||'_') = 1)
++ OR (MT.AD_MODULE_ID = C.AD_MODULE_ID))
))

Adding this restriction we ensure that in the 'EM case' the prefix is the right one OR in a 'normal column case' that the prefix belong to their module.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0053423)
hgbot (developer)
2012-10-17 14:55

Repository: erp/devel/pi
Changeset: f1f0bcb3e992a8b407760018a1f3c6611250461f
Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com>
Date: Wed Oct 17 14:53:38 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/f1f0bcb3e992a8b407760018a1f3c6611250461f [^]

Fixes Issue 0021922: Synchronize Terminology does not work properly with MERGE modules

Modifed case where the merge module was referred and it was not the MAX record in DB prefix table, Synchronize terminology fails.

---
M src-db/database/model/functions/AD_SYNCHRONIZE.xml
---
(0053513)
hudsonbot (developer)
2012-10-22 13:27

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/483f2e6dc1af [^]

Maturity status: Test
(0053578)
dbaz (developer)
2012-10-23 14:40

Reviewed @ changeset: 18268 - 5e3903a17a28

- Issue History
Date Modified Username Field Change
2012-10-11 18:51 caristu New Issue
2012-10-11 18:51 caristu Assigned To => AugustoMauch
2012-10-11 18:51 caristu Modules => Core
2012-10-11 18:51 caristu Resolution time => 1352674800
2012-10-11 18:51 caristu Issue Monitored: networkb
2012-10-16 15:57 AugustoMauch Assigned To AugustoMauch => shankarb
2012-10-17 14:55 hgbot Checkin
2012-10-17 14:55 hgbot Note Added: 0053423
2012-10-17 14:55 hgbot Status new => resolved
2012-10-17 14:55 hgbot Resolution open => fixed
2012-10-17 14:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1f0bcb3e992a8b407760018a1f3c6611250461f [^]
2012-10-17 14:55 shankarb Review Assigned To => dbaz
2012-10-17 14:55 shankarb Status resolved => new
2012-10-17 14:55 shankarb Resolution fixed => open
2012-10-17 14:55 shankarb Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/f1f0bcb3e992a8b407760018a1f3c6611250461f [^] =>
2012-10-17 14:56 shankarb Issue Monitored: dbaz
2012-10-17 14:56 shankarb Status new => scheduled
2012-10-17 14:56 shankarb fix_in_branch => pi
2012-10-17 14:57 shankarb Status scheduled => resolved
2012-10-17 14:57 shankarb Fixed in Version => pi
2012-10-17 14:57 shankarb Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/f1f0bcb3e992a8b407760018a1f3c6611250461f [^]
2012-10-17 14:57 shankarb Resolution open => fixed
2012-10-22 13:27 hudsonbot Checkin
2012-10-22 13:27 hudsonbot Note Added: 0053513
2012-10-23 14:40 dbaz Note Added: 0053578
2012-10-23 14:40 dbaz Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker