Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0021468 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Openbravo ERP] A. Platform | minor | always | 2012-08-28 14:25 | 2012-10-25 12:39 | |||
| Reporter | azabaleta | View Status | public | |||||
| Assigned To | shankarb | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0MP17 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | ab39dd401cd5 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | pi | SCM revision | ||||||
| Review Assigned To | dbaz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0021468: Ability to disable buttons like "delete" and "attach" in the toolbar | |||||||
| Description | Recently, a nice feature has been developed to allow the admin to configure a preference so you can disable the "Export to CSV" button in the toolbar for a specific role, window or user. As the code seemed quite trivial, IMO it would add so much power also to let the ability to delete and attach buttons to be configured via preferences. Thanks in advance. | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | Add preference properties to allow to disable DELETE and ATTACH toolbar buttons in the windows. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0052944) azabaleta (developer) 2012-10-01 09:57 |
Hi, to elaborate a bit more on this issue, I have to say that they are 2 separate set of preferences: - A preference allowing an user to be able to delete records: This preference would show or hide the toolbar button for deleting records. The "trash" button. - A preference allowing an user to be able use attachments: This preference would enable/disable the toolbar button of attachments. If the preference is disables for an user, he wont be able to see or add attachments on a window. Hope it helps. Asier |
|
(0053417) hgbot (developer) 2012-10-17 11:12 |
Repository: erp/devel/pi Changeset: 6df94ef450f7cdc4f47a566a8f142e865a397a08 Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Wed Oct 17 11:08:27 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/6df94ef450f7cdc4f47a566a8f142e865a397a08 [^] Fixes Issue 0021468: disable buttons "delete" and "attach" using preferences. 2 properties have been added. 'Allow Delete Records' and 'Allow Attachment' that will decide whether the actions should be enabled or disabled. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js M src-db/database/sourcedata/AD_REF_LIST.xml --- |
|
(0053418) shankarb (reporter) 2012-10-17 11:12 |
Reopened to add Review Assigned to |
|
(0053419) shankarb (reporter) 2012-10-17 11:23 |
Test Plan: Attachments: 1. Login as client admin 2. Create a new preference with the property 'Allow Attachment' with value 'N'. 3. Logout and login as client admin. 4. In all windows, the attachment option will not be available. 5. Login as system admin. Attachments can be added. Allow Delete: 1. Login as client admin 2. Create a new preference with the property 'Allow Delete Records' with value 'N'. 3. Logout and login as client admin. 4. In all windows, the delete option will not be available (even through shortcuts). 5. Login as system admin. Delete option will be available. Note that by default these options are enabled. |
|
(0053511) hudsonbot (developer) 2012-10-22 13:27 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/483f2e6dc1af [^] Maturity status: Test |
|
(0053575) dbaz (developer) 2012-10-23 13:59 |
It seems that the fix has been also reverted https://code.openbravo.com/erp/devel/pi/diff/ba911ec8d8ac/modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js#l1.40 [^] |
|
(0053581) hgbot (developer) 2012-10-23 15:14 |
Repository: erp/devel/pi Changeset: ec10f528e45f4d29484ddfb0f6f679d43bf8fe4b Author: Martin Taal <martin.taal <at> openbravo.com> Date: Tue Oct 23 15:14:04 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ec10f528e45f4d29484ddfb0f6f679d43bf8fe4b [^] Related to issue 21468: Ability to disable buttons like "delete" and "attach" in the toolbar Put back lines which were removed by accident, replaced standardWindow.id with standardWindow.windowId --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js --- |
|
(0053628) hgbot (developer) 2012-10-24 14:07 |
Repository: erp/devel/pi Changeset: ab39dd401cd5f88e6d83e3543d3b306f87ecf5ac Author: Shankar Balachandran <shankar.balachandran <at> openbravo.com> Date: Wed Oct 24 14:02:55 2012 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/ab39dd401cd5f88e6d83e3543d3b306f87ecf5ac [^] Fixes Issue 0021468 : Ability to disable buttons like "delete" and "attach" in the toolbar Refactored code to include two properties 'allowDelete' and 'allowAttachment' in OBStandardWindow and set them using preference value. Added logic to prevent delete using contextual menu (right click in grid). --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/grid/ob-view-grid.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-window.js M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/toolbar/ob-toolbar.js --- |
|
(0053678) dbaz (developer) 2012-10-25 10:41 |
Reviewed @ changeset: 18282 - 804841e22642 |
|
(0053703) hudsonbot (developer) 2012-10-25 12:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4a27e27689bc [^] Maturity status: Test |
|
(0053710) hudsonbot (developer) 2012-10-25 12:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4a27e27689bc [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-08-28 14:25 | azabaleta | New Issue | |
| 2012-08-28 14:25 | azabaleta | Assigned To | => alostale |
| 2012-08-28 14:25 | azabaleta | Modules | => Core |
| 2012-09-24 16:38 | shankarb | Issue Monitored: shankarb | |
| 2012-10-01 09:57 | azabaleta | Note Added: 0052944 | |
| 2012-10-01 13:11 | RafaelCruz | Issue Monitored: RafaelCruz | |
| 2012-10-08 18:29 | shankarb | Assigned To | alostale => shankarb |
| 2012-10-17 11:12 | shankarb | Status | new => scheduled |
| 2012-10-17 11:12 | shankarb | fix_in_branch | => pi |
| 2012-10-17 11:12 | hgbot | Checkin | |
| 2012-10-17 11:12 | hgbot | Note Added: 0053417 | |
| 2012-10-17 11:12 | hgbot | Status | scheduled => resolved |
| 2012-10-17 11:12 | hgbot | Resolution | open => fixed |
| 2012-10-17 11:12 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/6df94ef450f7cdc4f47a566a8f142e865a397a08 [^] |
| 2012-10-17 11:12 | shankarb | Status | resolved => new |
| 2012-10-17 11:12 | shankarb | Resolution | fixed => open |
| 2012-10-17 11:12 | shankarb | Status | new => scheduled |
| 2012-10-17 11:12 | shankarb | Note Added: 0053418 | |
| 2012-10-17 11:13 | shankarb | Review Assigned To | => dbaz |
| 2012-10-17 11:13 | shankarb | fix_in_branch | pi => |
| 2012-10-17 11:13 | shankarb | Issue Monitored: dbaz | |
| 2012-10-17 11:13 | shankarb | Status | scheduled => resolved |
| 2012-10-17 11:13 | shankarb | Resolution | open => fixed |
| 2012-10-17 11:23 | shankarb | Note Added: 0053419 | |
| 2012-10-17 13:49 | shankarb | Issue End Monitor: shankarb | |
| 2012-10-22 13:27 | hudsonbot | Checkin | |
| 2012-10-22 13:27 | hudsonbot | Note Added: 0053511 | |
| 2012-10-23 13:59 | dbaz | Note Added: 0053575 | |
| 2012-10-23 13:59 | dbaz | Status | resolved => new |
| 2012-10-23 13:59 | dbaz | Resolution | fixed => open |
| 2012-10-23 15:14 | hgbot | Checkin | |
| 2012-10-23 15:14 | hgbot | Note Added: 0053581 | |
| 2012-10-24 14:07 | hgbot | Checkin | |
| 2012-10-24 14:07 | hgbot | Note Added: 0053628 | |
| 2012-10-24 14:07 | hgbot | Status | new => resolved |
| 2012-10-24 14:07 | hgbot | Resolution | open => fixed |
| 2012-10-24 14:07 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/devel/pi/rev/6df94ef450f7cdc4f47a566a8f142e865a397a08 [^] => http://code.openbravo.com/erp/devel/pi/rev/ab39dd401cd5f88e6d83e3543d3b306f87ecf5ac [^] |
| 2012-10-25 10:41 | dbaz | Note Added: 0053678 | |
| 2012-10-25 10:41 | dbaz | Status | resolved => closed |
| 2012-10-25 10:41 | dbaz | Fixed in Version | => 3.0MP17 |
| 2012-10-25 12:38 | hudsonbot | Checkin | |
| 2012-10-25 12:38 | hudsonbot | Note Added: 0053703 | |
| 2012-10-25 12:39 | hudsonbot | Checkin | |
| 2012-10-25 12:39 | hudsonbot | Note Added: 0053710 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |