Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0021109
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2012-07-16 11:472012-07-27 02:18
ReportermiruritaView Statuspublic 
Assigned Tomirurita 
PriorityhighResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisiond6afbc421ad8
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionpiSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0021109: Multicurrency: exchange rate is not properly calculated using commas as decimal separator

DescriptionHaving commas (,) configured as decimal separator (see attached Format.xml file) the exchange rate is always retrieved with dot as decimal separator.

Reproducible on:
- Add Payment From Invoice
- Add Payment From Transaction
Steps To ReproduceScenario 1 (Add Payment From Transaction)
1) Configure Format.xml document to use comma (,) as decimal separator (use attaches Format.xml file)
2) Go to "Tarifa de ventas" price list and change the currency to USD
3) Create a new sales invoice and complete
  - BP: Alimentos y Supermercados, S.A
  - Currency: USD
  - Total: 10 USD
4) Go to "Cuenta de Banco" financial account
5) Configure Transferencia payment method to allow multicurrency transactions
  - Receive Payments in Multiple Currencies
6) Click on Add Transaction
7) Click on Add Payment In/Out
8) Select Alimentos y Supermercados, S.A
9) Select USD in currency combo
10) Realize that the Exchange Rate has an invalid format (dot as decimal separator)


Scenario 2 (Add Payment From Invoice)
1) Configure Format.xml document to use comma (,) as decimal separator (use attaches Format.xml file)
2) Go to "Tarifa de ventas" price list and change the currency to USD
3) Create a new sales invoice and complete
  - BP: Alimentos y Supermercados, S.A
  - Currency: USD
  - Total: 10 USD
4) Go to "Cuenta de Banco" financial account
5) Configure Transferencia payment method to allow multicurrency transactions
  - Receive Payments in Multiple Currencies
6) Click on Add payment on Sales Invoice window
7) Realize that the Exchange Rate is not loaded
a3196480 3301361 [TP-Processor3] ERROR org.openbravo.xmlEngine.ParameterValue - print() - Could not parse to string to BigDecimal: 0,689655
java.lang.NumberFormatException
    at java.math.BigDecimal.<init>(BigDecimal.java:470)
    at java.math.BigDecimal.<init>(BigDecimal.java:739)
TagsNo tags attached.
Attached Filesxml file icon Format.xml [^] (2,184 bytes) 2012-07-16 11:47
png file icon Exchange Rate comma decimal.png [^] (60,301 bytes) 2012-07-16 11:48


png file icon Exchange Rate comma decimal2.png [^] (47,831 bytes) 2012-07-16 12:09

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0050747)
hgbot (developer)
2012-07-19 11:07

Repository: erp/devel/pi
Changeset: d6afbc421ad8c6705f1394314052a20f6958d475
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Thu Jul 19 11:03:08 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d6afbc421ad8c6705f1394314052a20f6958d475 [^]

Fixes issue 21109: Multicurrency: exchange rate problem with comma as dec separator

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.html
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.java
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromTransaction.xml
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/utility/FIN_Utility.java
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/FIN_Utilities.js
---
(0050859)
hudsonbot (developer)
2012-07-26 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050908)
hgbot (developer)
2012-07-26 16:13

Repository: erp/devel/pi
Changeset: 65ba83da0c665ebc9ef11a998ecfe17e445625ae
Author: David Miguelez <david.miguelez <at> openbravo.com>
Date: Thu Jul 26 16:11:11 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/65ba83da0c665ebc9ef11a998ecfe17e445625ae [^]

Related to issue 0021109: Removes code that is never reached.

---
M modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/ad_actionbutton/AddPaymentFromInvoice.html
---
(0050909)
dmiguelez (developer)
2012-07-26 16:13

Code Review + Test OK
(0050922)
hudsonbot (developer)
2012-07-27 02:18

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/4cfe6f4cd84a [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-07-16 11:47 mirurita New Issue
2012-07-16 11:47 mirurita Assigned To => mirurita
2012-07-16 11:47 mirurita File Added: Format.xml
2012-07-16 11:47 mirurita Modules => Core
2012-07-16 11:48 mirurita File Added: Exchange Rate comma decimal.png
2012-07-16 12:07 mirurita Steps to Reproduce Updated View Revisions
2012-07-16 12:09 mirurita File Added: Exchange Rate comma decimal2.png
2012-07-19 11:07 hgbot Checkin
2012-07-19 11:07 hgbot Note Added: 0050747
2012-07-19 11:07 hgbot Status new => resolved
2012-07-19 11:07 hgbot Resolution open => fixed
2012-07-19 11:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d6afbc421ad8c6705f1394314052a20f6958d475 [^]
2012-07-26 02:42 hudsonbot Checkin
2012-07-26 02:42 hudsonbot Note Added: 0050859
2012-07-26 16:13 hgbot Checkin
2012-07-26 16:13 hgbot Note Added: 0050908
2012-07-26 16:13 dmiguelez Note Added: 0050909
2012-07-26 16:13 dmiguelez Status resolved => closed
2012-07-26 16:13 dmiguelez Fixed in Version => pi
2012-07-27 02:18 hudsonbot Checkin
2012-07-27 02:18 hudsonbot Note Added: 0050922


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker