Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020780
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformmajorhave not tried2012-06-15 10:122012-07-30 11:00
ReporterjecharriView Statuspublic 
Assigned ToAugustoMauch 
PriorityurgentResolutionfixedFixed in Versionpi
StatusclosedFix in branchFixed in SCM revisionc7f7fd1bcc69
ProjectionnoneETAnoneTarget Version3.0MP14
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Web browserGoogle Chrome
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020780: Bug in HBFix_data.xsql insert statement

Descriptionfollowing code:
<SqlMethod name="insert" type="preparedStatement" return="rowCount">
<Sql>
<![CDATA[
INSERT INTO ad_process_request
VALUES (get_uuid(), '0', '0', 'Y',
NOW(), '100', NOW(), '100', '1005800000',
NULL, '100', 'Y', ? ,
'SCH', NULL, NULL, NULL, 'Process Scheduler', 'S', NOW(),
NOW(), '4', NULL, NULL, NULL, 7, NULL, NULL, NULL, 'N', 'N', 'N', 'N', 'N', 'N','N', 'S', NULL, NULL, 'N', NULL, NULL, 'N', NULL, NULL, 'N', 'N', 'N', NULL)]]>
The insert statement tries to insert into ad_process_request table without specifying columns, so if a module adds a new column to the table, the
insert statement fails
Steps To Reproduce-
Proposed SolutionThe solution is to change the insert statement to:

INSERT INTO ad_process_request(ad_process_request_id, ad_client_id, ad_org_id, ... [name of all core columns] ) VALUES (get_uuid(), etc.)
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0050837)
hgbot (developer)
2012-07-25 15:58

Repository: erp/devel/pi
Changeset: c7f7fd1bcc69afe5349820fb3204aa99c15e0984
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Jul 25 15:58:04 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c7f7fd1bcc69afe5349820fb3204aa99c15e0984 [^]

Fixes issue 20780: Insert statement modified in xsql

The insert statement in HBFix_data.xsql has been modified, and now specifies the columns where the values are being inserted.

---
M src-util/modulescript/build/classes/org/openbravo/modulescript/HBFixData.class
M src-util/modulescript/src/org/openbravo/modulescript/HBFix_data.xsql
---
(0050885)
hudsonbot (developer)
2012-07-26 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test
(0050978)
migueldejuana (developer)
2012-07-30 11:00

Code reviewed: b6862b1e8f54.

- Issue History
Date Modified Username Field Change
2012-06-15 10:12 jecharri New Issue
2012-06-15 10:12 jecharri Assigned To => alostale
2012-06-15 10:12 jecharri Web browser => Google Chrome
2012-06-15 10:12 jecharri Modules => Core
2012-06-15 10:12 jecharri Resolution time => 1339538400
2012-07-18 13:23 shuehner Issue Monitored: shuehner
2012-07-25 15:55 AugustoMauch Assigned To alostale => AugustoMauch
2012-07-25 15:58 hgbot Checkin
2012-07-25 15:58 hgbot Note Added: 0050837
2012-07-25 15:58 hgbot Status new => resolved
2012-07-25 15:58 hgbot Resolution open => fixed
2012-07-25 15:58 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/c7f7fd1bcc69afe5349820fb3204aa99c15e0984 [^]
2012-07-26 02:42 hudsonbot Checkin
2012-07-26 02:42 hudsonbot Note Added: 0050885
2012-07-30 11:00 migueldejuana Note Added: 0050978
2012-07-30 11:00 migueldejuana Status resolved => closed
2012-07-30 11:00 migueldejuana Fixed in Version => pi


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker