Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020460
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Localization Pack: Spain] Taxesminoralways2012-05-09 18:502012-07-26 02:42
ReporterVictorVillarView Statuspublic 
Assigned ToioritzCia 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision5b8d7382e4da
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Regression date
Regression introduced by commit
Regression level
Review Assigned To
Regression introduced in release
Summary

0020460: wrong definition of some taxes in the dataset

Descriptionwe can see after execute the following query [1] of the DB function c_gettax, that we obtain more than one register, and this is not correct because the only tax that should be appear is 'Ventas exentas', the only one that should be checked as istaxexempt.

SELECT t.C_Tax_ID, T.NAME
          FROM C_Tax t
          INNER JOIN AD_Org o
            ON(t.AD_Client_ID = o.AD_Client_ID)
          WHERE t.ISTAXEXEMPT = 'Y'
          and t.sopotype ='S'
            AND o.AD_Org_ID = p_org_id
            AND t.ValidFrom <= shipdate
            AND t.isActive = 'Y'
          ORDER BY t.VALIDFROM DESC
We have realised about this behaviour if you configure one Business partner as Exempt and you are doing a sales transaction.

Also, this query is not correct because it is necessary to have a where clause with t.sopotype ='S' and t.sopotype ='B' in order to search only the tax sales transactions created by user
Steps To ReproduceAs group admin role,

Configure a BP as exempt and then create a sales order with that BP, in combo taxes we can see more than one register.
The only tax which should be appear is "Ventas exentas"
Proposed Solutiononly check as taxexempt "Ventas exentas" in the dataset.
Review the query indicated in the Description, add some kind of restriction about sales transaction.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0050709)
hgbot (developer)
2012-07-18 09:31

Repository: erp/devel/pi
Changeset: 5b8d7382e4da67658d62bd854188a42dabbcc992
Author: Ioritz Cia <ioritz.cia <at> openbravo.com>
Date: Thu Jul 12 17:40:35 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/5b8d7382e4da67658d62bd854188a42dabbcc992 [^]

Fixes issue 20460: C_GetTax function results restricted for exempt taxes.

---
M src-db/database/model/functions/C_GETTAX.xml
---
(0050784)
VictorVillar (developer)
2012-07-20 15:08

Verified
(0050848)
hudsonbot (developer)
2012-07-26 02:42

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5edf203d5780 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-09 18:50 VictorVillar New Issue
2012-05-09 18:50 VictorVillar Assigned To => jonalegriaesarte
2012-05-09 18:53 VictorVillar Issue Monitored: networkb
2012-05-09 19:18 VictorVillar Description Updated View Revisions
2012-06-07 12:34 jonalegriaesarte Assigned To jonalegriaesarte => ioritzCia
2012-06-11 13:08 ioritzCia Assigned To ioritzCia => caristu
2012-07-06 11:13 caristu Assigned To caristu => VictorVillar
2012-07-06 11:14 caristu Assigned To VictorVillar => ioritzCia
2012-07-16 18:34 ioritzCia Status new => scheduled
2012-07-16 18:34 ioritzCia fix_in_branch => pi
2012-07-18 09:31 hgbot Checkin
2012-07-18 09:31 hgbot Note Added: 0050709
2012-07-18 09:31 hgbot Status scheduled => resolved
2012-07-18 09:31 hgbot Resolution open => fixed
2012-07-18 09:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/5b8d7382e4da67658d62bd854188a42dabbcc992 [^]
2012-07-20 15:08 VictorVillar Note Added: 0050784
2012-07-20 15:08 VictorVillar Status resolved => closed
2012-07-26 02:42 hudsonbot Checkin
2012-07-26 02:42 hudsonbot Note Added: 0050848


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker