Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020400
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminoralways2012-05-03 12:392012-05-28 09:21
ReporterrgorisView Statuspublic 
Assigned Tonaiaramartinez 
PriorityhighResolutionno change requiredFixed in Version
StatusclosedFix in branchpiFixed in SCM revisione3eca21395e5
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020400: Associate Modify Payment Plan button with the Payment Plan tabs

DescriptionAs it is now, the Modify Payment Plan button is always present for completed Sales Invoices (and Purchase Invoices)which takes up space and is very dominant for a feature that is little used. The idea is to only show this button when the focus is on one of the child Payment Plan or Archived Payment Plan tabs.
Steps To ReproduceComplete an invoice. Look at orange buttons.
Proposed SolutionAssociate button (process) with the aforementioned tabs.
TagsMIR-Reviewed
Attached Fileswmv file icon ModifyPPbuttonDoesNotAppear.wmv [^] (817,252 bytes) 2012-05-14 10:33

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0048451)
naiaramartinez (developer)
2012-05-08 15:13

Test Plan:
  Go to Sales Invoice window and create a new header.
  Create a new line.
  Complete the invoice.
  Go to 'Payment in Plan' tab. Notice that the 'Modify Payment In Plan' is shown when the focus is in that tab. Moreover, even though the focus is that tab you won't be able to see the button if the invoice is not completed and it is paid.

  Go to Purchase Invoice window and create a new header.
  Create a new line.
  Complete the invoice.
  Go to 'Payment Out Plan' tab. Notice that the 'Modify Payment Out Plan' is shown when the focus is in that tab. Moreover, even though the focus is that tab you won't be able to see the button if the invoice is not completed and it is paid.
(0048553)
hgbot (developer)
2012-05-10 13:31

Repository: erp/devel/pi
Changeset: e3eca21395e54770aaf7436d10db0812d4ea72ca
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Tue May 08 13:21:36 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/e3eca21395e54770aaf7436d10db0812d4ea72ca [^]

fixed bug 20400 Move 'Modify Payment Plan' button to child tab
the button was in invoice Header tab and it has been moved to 'Payment Plan'

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/model/views/FIN_PAYMENT_SCHED_INV_V.xml
M src-db/database/sourcedata/AD_COLUMN.xml
---
(0048607)
rgoris (developer)
2012-05-14 10:33

Basic functionality works but there is one thing that needs to be fixed still: when completing a sales invoice while looking at the Payment Plan tab, the Modify PP button does not appear by itself. You now need to switch child tabs in order to see it. See attached video.

It should appear by itself after completion.
(0048877)
naiaramartinez (developer)
2012-05-23 08:48

After executing a process belonging to the header (i.e. click on Complete button) the header tab gets focussed regardless of the selected tab at the moment of executing it (in your example, Payment Plan tab). This is the current behaviour on Openbravo, any change here will require platform team review.
Once the focus is on header tab, you cannot see buttons of child tabs.

Because of previous platform limitations we cannot change the tab that will get the focus after executing a process.

Furthermore, this functionality has been recently classified as advanced functionality (Paolo's request) and so the 'Modify Payment Plan' button (and Archived Payment Plan tab) is hidden by default.

We will proceed to close the issue.
(0049090)
hudsonbot (developer)
2012-05-25 12:11

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/5401e185a8b0 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-05-03 12:39 rgoris New Issue
2012-05-03 12:39 rgoris Assigned To => alostale
2012-05-03 12:39 rgoris Modules => Core
2012-05-03 13:02 alostale Assigned To alostale => mirurita
2012-05-03 13:13 mirurita Tag Attached: MIR-Reviewed
2012-05-08 09:33 naiaramartinez Assigned To mirurita => naiaramartinez
2012-05-08 09:33 naiaramartinez Status new => scheduled
2012-05-08 09:33 naiaramartinez fix_in_branch => pi
2012-05-08 15:13 naiaramartinez Note Added: 0048451
2012-05-10 13:31 hgbot Checkin
2012-05-10 13:31 hgbot Note Added: 0048553
2012-05-10 13:31 hgbot Status scheduled => resolved
2012-05-10 13:31 hgbot Resolution open => fixed
2012-05-10 13:31 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/e3eca21395e54770aaf7436d10db0812d4ea72ca [^]
2012-05-14 10:33 rgoris Note Added: 0048607
2012-05-14 10:33 rgoris Status resolved => new
2012-05-14 10:33 rgoris Resolution fixed => open
2012-05-14 10:33 rgoris File Added: ModifyPPbuttonDoesNotAppear.wmv
2012-05-23 08:48 naiaramartinez Note Added: 0048877
2012-05-25 12:11 hudsonbot Checkin
2012-05-25 12:11 hudsonbot Note Added: 0049090
2012-05-28 09:21 naiaramartinez Status new => closed
2012-05-28 09:21 naiaramartinez Resolution open => no change required


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker