Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0020038
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2012-03-15 16:022012-06-12 12:18
ReporterchelipfView Statuspublic 
Assigned Tonaiaramartinez 
PriorityhighResolutionfixedFixed in Version3.0MP13
StatusclosedFix in branchpiFixed in SCM revisiond83794bd89ee
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_23
OS VersionDatabase version8.4.9Ant version1.8.2
Product Version2.50MP34SCM revision 
Review Assigned To
Web browserMozilla Firefox
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0020038: Create Lines From in Sales invoices doesn't set taxamt and taxbaseamt fields properly

DescriptionCreate Lines From process doesn't set taxamt and taxbaseamt columns of C_INVOICELINE table.
Steps To Reproduce- Create a new sales invoice header.
- Push create lines from button.
- Select a order or a shipment.
- Process.
Proposed SolutionI had no time to wait for your fix, then I have just fixed the problem and the patch is in the attachment file. It is based on SL_Invoice_Amt callout calculation.
TagsVMA-Reviewed
Attached Filesdiff file icon 3.diff [^] (3,945 bytes) 2012-03-15 16:02 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0020015 closedSandrahuguet Create Lines From in Sales invoices doesn't set Excludeforwithholding field properly 

-  Notes
(0046461)
chelipf (reporter)
2012-03-15 16:04
edited on: 2012-04-04 15:50

The same thing happens for purchase invoice. It is related to 0020015 issue.

(0047521)
naiaramartinez (developer)
2012-04-12 12:52

Test Plan:
    Go to sales order.
    Create a header. Set invoice terms as Immediate.
    Create a new line.
    Book the sales order.

    Go to Sales Invoice.
    Create a new header. Select the same BP as you selected in the previously created sales order.
    Press 'Create Lines From'. A popup is opened.
    Select the sales order you created previously.
    Select the lines and press OK.

    Go to the database and execute the folowing SQL:
         select taxamt, taxbaseamt
         from c_invoiceline
         order by created desc

Notice that the taxamt and taxbaseamt have the correct values.
(0047524)
naiaramartinez (developer)
2012-04-12 13:06

Thank you for your effort and your fix. We will push it to pi
(0049732)
hgbot (developer)
2012-06-11 16:10

Repository: erp/devel/pi
Changeset: d83794bd89ee0f548324fbd3b8bf6a2f217730b7
Author: Naiara Martinez <naiara.martinez <at> openbravo.com>
Date: Wed Jun 06 12:45:52 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/d83794bd89ee0f548324fbd3b8bf6a2f217730b7 [^]

Fixed bug 20038: Cheli Pineda's contribution. Set taxamt/taxbaseamt fields in Create Lines From

---
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom.java
M src/org/openbravo/erpCommon/ad_actionButton/CreateFrom_Invoice_data.xsql
---
(0049733)
mirurita (developer)
2012-06-11 16:13

thanks again for your contribution!

code review + testing OK
(0049756)
hgbot (developer)
2012-06-12 12:18

Repository: erp/devel/pi
Changeset: 53c53ee333bb2d5b7add861925068e67dc24ca4a
Author: Mikel Irurita <mikel.irurita <at> openbravo.com>
Date: Tue Jun 12 12:16:40 2012 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/53c53ee333bb2d5b7add861925068e67dc24ca4a [^]

Related to issue 20038: add a new contributor

---
M CONTRIBUTORS
---

- Issue History
Date Modified Username Field Change
2012-03-15 16:02 chelipf New Issue
2012-03-15 16:02 chelipf Assigned To => vmromanos
2012-03-15 16:02 chelipf File Added: 3.diff
2012-03-15 16:02 chelipf Web browser => Mozilla Firefox
2012-03-15 16:02 chelipf Modules => Core
2012-03-15 16:04 chelipf Note Added: 0046461
2012-03-15 16:04 chelipf Issue Monitored: chelipf
2012-04-04 15:50 chelipf Note Edited: 0046461 View Revisions
2012-04-04 15:59 Sandrahuguet Relationship added related to 0020015
2012-04-04 16:02 Sandrahuguet Relationship deleted related to 0020015
2012-04-10 13:19 vmromanos Tag Attached: VMA-Reviewed
2012-04-12 09:42 vmromanos Relationship added related to 0020015
2012-04-12 12:52 naiaramartinez Note Added: 0047521
2012-04-12 12:52 naiaramartinez Assigned To vmromanos => naiaramartinez
2012-04-12 12:53 naiaramartinez Status new => scheduled
2012-04-12 12:53 naiaramartinez fix_in_branch => pi
2012-04-12 13:06 naiaramartinez Note Added: 0047524
2012-06-11 16:10 hgbot Checkin
2012-06-11 16:10 hgbot Note Added: 0049732
2012-06-11 16:10 hgbot Status scheduled => resolved
2012-06-11 16:10 hgbot Resolution open => fixed
2012-06-11 16:10 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d83794bd89ee0f548324fbd3b8bf6a2f217730b7 [^]
2012-06-11 16:13 mirurita Note Added: 0049733
2012-06-11 16:13 mirurita Status resolved => closed
2012-06-11 16:13 mirurita Fixed in Version => 3.0MP13
2012-06-12 12:18 hgbot Checkin
2012-06-12 12:18 hgbot Note Added: 0049756


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker