Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019985 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | have not tried | 2012-03-08 16:09 | 2012-04-01 20:39 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | de657cf78aa7 | ||||
| Projection | none | ETA | none | Target Version | 3.0MP10 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019985: AlertActionHandler response is unnecessary big | |||||||
| Description | Each 50s each client is sending a request to AlertActionHandler to obtain active alerts for current user/role. The response of to this request contains not only the counter of alerts but also the complete list of them. In case of many active alerts, the response can be huge and the only used part is the counter. Increasing considerably the bandwidth used by Openbravo, note that this increases by each session. | |||||||
| Steps To Reproduce | -Add an alert rule that creates many alert instances *In alert window add the following alert: -Name: dummy -SQL: select ad_column_id as referencekey_id, name as record_id, 0 as ad_role_id, null as ad_user_id, name ||' is a column' as description, 'Y' as isActive, ad_org_id, ad_client_id, now() as created, 0 as createdBy, now() as updated, 0 as updatedBy from ad_column -Tab: Column - Tables and Columns -Assign System Admin role to this alert -Login with System Admin. Check network calls to AlertActionHandler. | |||||||
| Proposed Solution | AlertActionHandler should return just the count of active alerts | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  Selection_041.png [^] (28,644 bytes) 2012-03-08 17:11
After_fix.png [^] (33,727 bytes) 2012-03-08 17:27
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0046207) alostale (manager) 2012-03-08 17:34 |
This changeset does not introduce regression risk as the only part actually used in the response was the count which is the only preserved part. Executed test plan. -Ensure previous statement is true. This is not actually used anywhere else. * Code review of AlertActionHandler usage * Use Alert Management window by changing alert status -Repeat steps to reproduce and check the difference: * The improvement depends on the actual number of active alerts for the user. In the example there are around 10K. The reductions are: * From 7.20MB to 205B in the response. * From ~1.3 seconds in the server to generate the response to ~30ms. |
|
(0046208) hgbot (developer) 2012-03-08 17:44 |
Repository: erp/devel/pi Changeset: de657cf78aa790028cbf554fb4f19ddda3f26d97 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Mar 08 17:43:26 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/de657cf78aa790028cbf554fb4f19ddda3f26d97 [^] fixed bug 19985: AlertActionHandler response is unnecessary big AlertActionHandler returns now just the count of active alerts, but not the complete list of them. --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/AlertActionHandler.java --- |
|
(0046218) alostale (manager) 2012-03-09 09:20 |
Note this fix introduces issue 0019989 in Oracle! |
|
(0047074) hudsonbot (developer) 2012-04-01 20:39 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/640de9acc2d5 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-03-08 16:09 | alostale | New Issue | |
| 2012-03-08 16:09 | alostale | Assigned To | => alostale |
| 2012-03-08 16:09 | alostale | Modules | => Core |
| 2012-03-08 17:11 | alostale | Steps to Reproduce Updated | View Revisions |
| 2012-03-08 17:11 | alostale | Steps to Reproduce Updated | View Revisions |
| 2012-03-08 17:11 | alostale | File Added: Selection_041.png | |
| 2012-03-08 17:27 | alostale | File Added: After_fix.png | |
| 2012-03-08 17:34 | alostale | Note Added: 0046207 | |
| 2012-03-08 17:44 | hgbot | Checkin | |
| 2012-03-08 17:44 | hgbot | Note Added: 0046208 | |
| 2012-03-08 17:44 | hgbot | Status | new => resolved |
| 2012-03-08 17:44 | hgbot | Resolution | open => fixed |
| 2012-03-08 17:44 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/de657cf78aa790028cbf554fb4f19ddda3f26d97 [^] |
| 2012-03-09 09:16 | alostale | Relationship added | related to 0019989 |
| 2012-03-09 09:20 | alostale | Note Added: 0046218 | |
| 2012-03-16 16:42 | marvintm | Status | resolved => closed |
| 2012-03-29 10:58 | alostale | Relationship added | related to 0020146 |
| 2012-04-01 20:39 | hudsonbot | Checkin | |
| 2012-04-01 20:39 | hudsonbot | Note Added: 0047074 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |