Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0019729
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Y. DBSourceManagerminorhave not tried2012-02-10 20:462012-03-02 15:36
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision42ab557adad4
ProjectionnoneETAnoneTarget Version3.0MP9
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019729: dbsm: Function- & Trigger-Standardisation should be made faster

DescriptionThat standardisation step i quite slow (i.e. 41s seconds) on a specific laptop.

The change planned in this issue reduces this time to around 26s on that same system (around 40% less) by rewriting one specific standardisation steps which changes end last system-provided 'END' line after the function body to read 'END <functionname/triggername>' for both the function & trigger standardisation.

That change does introduce 2 formal changes when applied to all PL-functions & -trigger present in pi.

Formal change: If the last line of the body does have trailing spaces those trailing spaces will be removed in the standardisation.

That change is deemed reasonable & acceptable compared to the speed-up which is achieved by the change.
Steps To ReproduceRun update.database and check runtime of the standardisation step done during the model-loading.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0045047)
hgbot (developer)
2012-02-12 14:09

Repository: erp/devel/dbsm-main
Changeset: 9ce40055b2c7acd41f87f29ed386e669a0e5c827
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 10 20:48:17 2012 +0100
URL: http://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^]

Fixed 19729: Speedup function- & trigger-standardization by around 40%
Rewrite regex changing 'END' to 'END <function/trigger-name>' which is applied
to the last system-provided line after the function body.
This changes slightly the standardization so does introduce 2 formal changes
when applied to all files in pi.
- Formal change: If last line of function-body does contain trailing spaces,
then those are removed on export.database

---
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLFunctionStandarization.java
M src/org/apache/ddlutils/platform/postgresql/PostgrePLSQLTriggerStandarization.java
---
(0045048)
hgbot (developer)
2012-02-12 14:11

Repository: erp/devel/pi
Changeset: 42ab557adad4f03184fd0eef044034da90cfc763
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Feb 10 20:49:42 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/42ab557adad4f03184fd0eef044034da90cfc763 [^]

Fixed 19729: Speedup function- & trigger-standardization by around 40%
Rewrite regex changing 'END' to 'END <function/trigger-name>' which is applied
to the last system-provided line after the function body.
This changes slightly the standardization so does introduce 2 formal changes
when applied to all files in pi.
- Formal change: If last line of function-body does contain trailing spaces,
then those are removed on export.database
Those formal changes are also directly committed to pi in this cset.

---
M modules/org.openbravo.userinterface.selector/src-db/database/model/functions/OBUISEL_SYNCHRONIZE.xml
M src-db/database/lib/dbsourcemanager.jar
M src-db/database/model/functions/AD_UPDATE_TABLE_IDENTIFIER0.xml
---
(0045831)
hudsonbot (developer)
2012-03-02 15:36

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-02-10 20:46 shuehner New Issue
2012-02-10 20:46 shuehner Assigned To => shuehner
2012-02-10 20:46 shuehner Modules => Core
2012-02-12 14:09 hgbot Checkin
2012-02-12 14:09 hgbot Note Added: 0045047
2012-02-12 14:09 hgbot Status new => resolved
2012-02-12 14:09 hgbot Resolution open => fixed
2012-02-12 14:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^]
2012-02-12 14:11 hgbot Checkin
2012-02-12 14:11 hgbot Note Added: 0045048
2012-02-12 14:11 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/dbsm-main/rev/9ce40055b2c7acd41f87f29ed386e669a0e5c827 [^] => http://code.openbravo.com/erp/devel/pi/rev/42ab557adad4f03184fd0eef044034da90cfc763 [^]
2012-03-01 14:08 marvintm Status resolved => closed
2012-03-02 15:36 hudsonbot Checkin
2012-03-02 15:36 hudsonbot Note Added: 0045831


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker