Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0019462 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | major | always | 2012-01-11 16:17 | 2012-03-02 15:34 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | dbaz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 87a191c834a2 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0019462: "Pick & Execute" "Pin" icon should be inside skin folder and path not hardcoded in sources | |||||||
| Description | "Pick & Execute" "Pin" icon should be inside skin folder and path not hardcoded in sources, in order to be able to be skinned in the same way other components do: http://wiki.openbravo.com/wiki/Skins [^] Currently iconPin.png is inside modules/org.openbravo.client.application/web/org.openbravo.client.application/images/ (this "images" folder should be removed too) and it should be inside modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/ Also the path currently is inside modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js and it should be inside modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process.js in a way similar like: OB.Styles.skinsPath + 'Default/org.openbravo.client.application/images/process/iconPin.png' | |||||||
| Steps To Reproduce | Look at paths mentioned in "Description" | |||||||
| Proposed Solution | Move to the paths mentioned in "Description" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0044816) hgbot (developer) 2012-02-02 15:49 |
Repository: erp/devel/pi Changeset: 87a191c834a29a6a1b85687094fd52d78f1c6aca Author: David Baz Fayos <david.baz <at> openbravo.com> Date: Wed Feb 01 23:08:53 2012 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/87a191c834a29a6a1b85687094fd52d78f1c6aca [^] Fixed issue 19462: moved hardcoded 'pick and execute' values to the skin --- M modules/org.openbravo.client.application/src/org/openbravo/client/application/ApplicationComponentProvider.java M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-view.js A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/images/process/iconPin.png A modules/org.openbravo.client.application/web/org.openbravo.userinterface.smartclient/openbravo/skins/Default/org.openbravo.client.application/ob-process-styles.js R modules/org.openbravo.client.application/web/org.openbravo.client.application/images/iconPin.png --- |
|
(0044976) iperdomo (reporter) 2012-02-09 17:00 |
Tested on pi @ rev 2d73d1ed6bf1 |
|
(0045734) hudsonbot (developer) 2012-03-02 15:34 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/544d64e0c159 [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2012-01-11 16:17 | dbaz | New Issue | |
| 2012-01-11 16:17 | dbaz | Assigned To | => iperdomo |
| 2012-01-11 16:17 | dbaz | Modules | => Core |
| 2012-01-24 13:49 | iperdomo | Assigned To | iperdomo => dbaz |
| 2012-02-02 15:49 | hgbot | Checkin | |
| 2012-02-02 15:49 | hgbot | Note Added: 0044816 | |
| 2012-02-02 15:49 | hgbot | Status | new => resolved |
| 2012-02-02 15:49 | hgbot | Resolution | open => fixed |
| 2012-02-02 15:49 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/87a191c834a29a6a1b85687094fd52d78f1c6aca [^] |
| 2012-02-09 17:00 | iperdomo | Note Added: 0044976 | |
| 2012-02-09 17:00 | iperdomo | Status | resolved => closed |
| 2012-03-02 15:34 | hudsonbot | Checkin | |
| 2012-03-02 15:34 | hudsonbot | Note Added: 0045734 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |