Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019426
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2012-01-09 10:082012-01-14 21:21
ReporterrgorisView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revisionea78618e25e9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019426: Change message text - attachments deletion

DescriptionWhen trying to delete an attachment, the system prompts the user with a confirmation message. The text is not 100% accurate as it says "Delete" in stead of "Remove". Same for the button label.

Remove is the preferred term here to avoid confusion with deletion of the file itself (from the file system). Removing here means taking it out from the ERP but it (probably) still exists elsewhere.

Also I propose to use titles that refer to the action to be taken: "Remove Attachment".
Steps To Reproducedelete an attachment
Proposed SolutionMessage title: "Remove Attachment"
Message: "Are you sure you want to permanently remove this attachment?"

and same for plural:

"Are you sure you want to permanently remove all the attachments of this record?"

and the button must be [ Remove ] and [ Remove All ]

TagsNo tags attached.
Attached Filespng file icon Remove-Question-attachment.png [^] (10,490 bytes) 2012-01-09 10:08

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0019423 closeddbaz Change message text - record deletion 

-  Notes
(0044181)
dbaz (developer)
2012-01-10 14:20

 To test it:
As "Openbravo Admin"
* Go to any window: Example "Sales Order"
* Go to form view
* Add one attachment
* Click in the "Remove" button
Notice that the dialog message and dialog title is the expected one

* Add more than one attachment
* Click in the "Remove All" button
Notice that the dialog message and dialog title is the expected one
(0044188)
hgbot (developer)
2012-01-10 15:14

 Repository: erp/devel/pi
Changeset: ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Tue Jan 10 15:14:15 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7 [^]

Fixed issue 19426: 'Remove attachment' message changed

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
---
(0044190)
mtaal (manager)
2012-01-10 15:28

 Reviewed
(0044245)
rgoris (developer)
2012-01-11 11:34

 I noticed one detail that would be good to fix still:

When removing multiple attachments at once, the message title should be:

"Remove Attachments" (with an additional s)
(0044247)
rgoris (developer)
2012-01-11 11:42

 as per last note
(0044258)
hgbot (developer)
2012-01-11 13:49

 Repository: erp/devel/pi
Changeset: ba03356ff1fa8f8038c1b4a281cc347e48b1d026
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jan 11 13:48:51 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ba03356ff1fa8f8038c1b4a281cc347e48b1d026 [^]

Related to issue 19426: Added plural dialog title case

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/ob-view-form-attachments.js
---
(0044262)
mtaal (manager)
2012-01-11 14:18

 Reviewed
(0044297)
rgoris (developer)
2012-01-12 11:30

 tested and considered solved
(0044350)
hudsonbot (developer)
2012-01-14 21:21

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044371)
hudsonbot (developer)
2012-01-14 21:21

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-01-09 10:08 rgoris New Issue
2012-01-09 10:08 rgoris Assigned To => dbaz
2012-01-09 10:08 rgoris File Added: Remove-Question-attachment.png
2012-01-09 10:08 rgoris Modules => Core
2012-01-09 10:08 rgoris Issue generated from 0019423
2012-01-09 10:08 rgoris Relationship added related to 0019423
2012-01-10 11:48 rgoris Description Updated View Revisions
2012-01-10 11:48 rgoris Proposed Solution updated
2012-01-10 14:20 dbaz Note Added: 0044181
2012-01-10 15:14 hgbot Checkin
2012-01-10 15:14 hgbot Note Added: 0044188
2012-01-10 15:14 hgbot Status new => resolved
2012-01-10 15:14 hgbot Resolution open => fixed
2012-01-10 15:14 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/ea78618e25e9c510f83d6b6941cc1ed7d0d3ddc7 [^]
2012-01-10 15:28 mtaal Note Added: 0044190
2012-01-11 11:34 rgoris Note Added: 0044245
2012-01-11 11:42 rgoris Note Added: 0044247
2012-01-11 11:42 rgoris Status resolved => new
2012-01-11 11:42 rgoris Resolution fixed => open
2012-01-11 13:49 hgbot Checkin
2012-01-11 13:49 hgbot Note Added: 0044258
2012-01-11 13:50 dbaz Status new => scheduled
2012-01-11 13:50 dbaz fix_in_branch => pi
2012-01-11 13:50 dbaz Status scheduled => resolved
2012-01-11 13:50 dbaz Resolution open => fixed
2012-01-11 14:18 mtaal Note Added: 0044262
2012-01-12 11:30 rgoris Note Added: 0044297
2012-01-12 11:30 rgoris Status resolved => closed
2012-01-14 21:21 hudsonbot Checkin
2012-01-14 21:21 hudsonbot Note Added: 0044350
2012-01-14 21:21 hudsonbot Checkin
2012-01-14 21:21 hudsonbot Note Added: 0044371

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker