Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0019423
TypeCategorySeverityReproducibilityDate SubmittedLast Update
feature request[Openbravo ERP] A. Platformminoralways2012-01-08 13:512012-01-14 21:21
ReporterrgorisView Statuspublic 
Assigned Todbaz 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchpiFixed in SCM revision33855ed49422
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0019423: Change message text - record deletion

DescriptionWhen trying to delete a row, the system prompts the user with a confirmation message. The text is not 100% accurate as it says "Remove" in stead of delete, whereas the tooltip on the delete button in the toolbar says "Delete".

Also the "Question" label in the title bar is a bit silly, I propose to use titles that refer to the action to be taken: "Delete Record".
Steps To Reproducedelete a row in a grid
Proposed SolutionMessage title: "Delete Record"
Message: "Are you sure that you want to delete the selected record?"

TagsNo tags attached.
Attached Filespng file icon Remove-Question.png [^] (8,822 bytes) 2012-01-08 13:51

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0019426 closeddbaz Change message text - attachments deletion 

-  Notes
(0044173)
hgbot (developer)
2012-01-10 12:46

 Repository: erp/devel/pi
Changeset: 33855ed49422d96afc2ec9a9df7ccad92d232bd5
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Mon Jan 09 21:26:24 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/33855ed49422d96afc2ec9a9df7ccad92d232bd5 [^]

Fixed issue 19423: 'Delete selected record' message changed

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0044178)
mtaal (manager)
2012-01-10 13:59

 Reviewed
(0044184)
dbaz (developer)
2012-01-10 14:26

 To test it:
As "Openbravo Admin"
* Go to any window: Example "Sales Order"
* Select one record in grid
* Click in the "Delete" toolbar icon.
Notice that the dialog message and dialog title is the expected one

* Select more than one record in grid
* Click in the "Delete" toolbar icon.
Notice that the dialog message and dialog title is the expected one
(0044242)
rgoris (developer)
2012-01-11 11:33

 I noticed one detail that would be good to fix still:

When deleting multiple records at once, the message title should be:

"Delete Records" (with an additional s)
(0044248)
rgoris (developer)
2012-01-11 11:42

 as per last note
(0044261)
hgbot (developer)
2012-01-11 14:15

 Repository: erp/devel/pi
Changeset: ea807479cfa86bf1af9c05a49f5a75919b0aed93
Author: David Baz Fayos <david.baz <at> openbravo.com>
Date: Wed Jan 11 14:15:20 2012 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/ea807479cfa86bf1af9c05a49f5a75919b0aed93 [^]

Related to issue 19423: Added plural dialog title case

---
M modules/org.openbravo.client.application/src-db/database/sourcedata/AD_MESSAGE.xml
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0044264)
mtaal (manager)
2012-01-11 14:23

 Reviewed
(0044296)
rgoris (developer)
2012-01-12 11:30

 tested and considered solved
(0044344)
hudsonbot (developer)
2012-01-14 21:20

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test
(0044372)
hudsonbot (developer)
2012-01-14 21:21

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0f91795528e4 [^]

Maturity status: Test

- Issue History
Date Modified Username Field Change
2012-01-08 13:51 rgoris New Issue
2012-01-08 13:51 rgoris Assigned To => dbaz
2012-01-08 13:51 rgoris File Added: Remove-Question.png
2012-01-08 13:51 rgoris Modules => Core
2012-01-09 10:08 rgoris Issue cloned 0019426
2012-01-09 10:08 rgoris Relationship added related to 0019426
2012-01-09 10:09 rgoris Summary Change message text => Change message text - record deletion
2012-01-10 12:46 hgbot Checkin
2012-01-10 12:46 hgbot Note Added: 0044173
2012-01-10 12:46 hgbot Status new => resolved
2012-01-10 12:46 hgbot Resolution open => fixed
2012-01-10 12:46 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/33855ed49422d96afc2ec9a9df7ccad92d232bd5 [^]
2012-01-10 13:59 mtaal Note Added: 0044178
2012-01-10 14:26 dbaz Note Added: 0044184
2012-01-11 11:33 rgoris Note Added: 0044242
2012-01-11 11:42 rgoris Note Added: 0044248
2012-01-11 11:42 rgoris Status resolved => new
2012-01-11 11:42 rgoris Resolution fixed => open
2012-01-11 14:15 hgbot Checkin
2012-01-11 14:15 hgbot Note Added: 0044261
2012-01-11 14:16 dbaz Status new => scheduled
2012-01-11 14:16 dbaz fix_in_branch => pi
2012-01-11 14:16 dbaz Status scheduled => resolved
2012-01-11 14:16 dbaz Resolution open => fixed
2012-01-11 14:23 mtaal Note Added: 0044264
2012-01-12 11:30 rgoris Note Added: 0044296
2012-01-12 11:30 rgoris Status resolved => closed
2012-01-14 21:20 hudsonbot Checkin
2012-01-14 21:20 hudsonbot Note Added: 0044344
2012-01-14 21:21 hudsonbot Checkin
2012-01-14 21:21 hudsonbot Note Added: 0044372

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker